From 5731aa87acd6f017d206e1ac177ebe88a273d41a Mon Sep 17 00:00:00 2001
From: Stenzek <stenzek@gmail.com>
Date: Mon, 4 May 2026 13:34:04 +1000
Subject: [PATCH] CI: Pass --fail to curl downloads

Ensure a download failing actually cancels the job.
---
 .github/workflows/linux-appimage-build.yml    |  2 +-
 .../workflows/linux-cross-appimage-build.yml  |  4 ++--
 .github/workflows/macos-build.yml             |  2 +-
 .github/workflows/windows-build.yml           | 24 +++++++++----------
 4 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/.github/workflows/linux-appimage-build.yml b/.github/workflows/linux-appimage-build.yml
index 50d7d5d55..7788ec8a2 100644
--- a/.github/workflows/linux-appimage-build.yml
+++ b/.github/workflows/linux-appimage-build.yml
@@ -35,7 +35,7 @@ jobs:
       run: |
         DEPS_VERSION=$(cat dep/PREBUILT-VERSION)
         cd dep/prebuilt
-        curl --retry 5 --retry-all-errors -LO "https://github.com/duckstation/dependencies/releases/download/$DEPS_VERSION/deps-linux-x64.tar.xz"
+        curl --fail --retry 5 --retry-all-errors -LO "https://github.com/duckstation/dependencies/releases/download/$DEPS_VERSION/deps-linux-x64.tar.xz"
         sha256sum --check --ignore-missing ../PREBUILT-SHA256SUMS
         tar -xf "deps-linux-x64.tar.xz"
         rm "deps-linux-x64.tar.xz"
diff --git a/.github/workflows/linux-cross-appimage-build.yml b/.github/workflows/linux-cross-appimage-build.yml
index 233098bd6..6114cf22a 100644
--- a/.github/workflows/linux-cross-appimage-build.yml
+++ b/.github/workflows/linux-cross-appimage-build.yml
@@ -29,8 +29,8 @@ jobs:
       run: |
         DEPS_VERSION=$(cat dep/PREBUILT-VERSION)
         cd dep/prebuilt
-        curl --retry 5 --retry-all-errors -LO "https://github.com/duckstation/dependencies/releases/download/$DEPS_VERSION/deps-linux-x64.tar.xz"
-        curl --retry 5 --retry-all-errors -LO "https://github.com/duckstation/dependencies/releases/download/$DEPS_VERSION/deps-linux-cross-${{matrix.arch}}.tar.xz"
+        curl --fail --retry 5 --retry-all-errors -LO "https://github.com/duckstation/dependencies/releases/download/$DEPS_VERSION/deps-linux-x64.tar.xz"
+        curl --fail --retry 5 --retry-all-errors -LO "https://github.com/duckstation/dependencies/releases/download/$DEPS_VERSION/deps-linux-cross-${{matrix.arch}}.tar.xz"
         sha256sum --check --ignore-missing ../PREBUILT-SHA256SUMS
         tar -xf "deps-linux-x64.tar.xz"
         tar -xf "deps-linux-cross-${{matrix.arch}}.tar.xz"
diff --git a/.github/workflows/macos-build.yml b/.github/workflows/macos-build.yml
index 0ea66c5d0..974c78645 100644
--- a/.github/workflows/macos-build.yml
+++ b/.github/workflows/macos-build.yml
@@ -27,7 +27,7 @@ jobs:
       run: |
         DEPS_VERSION=$(cat dep/PREBUILT-VERSION)
         cd dep/prebuilt
-        curl --retry 5 --retry-all-errors -LO "https://github.com/duckstation/dependencies/releases/download/$DEPS_VERSION/deps-macos-universal.tar.xz"
+        curl --fail --retry 5 --retry-all-errors -LO "https://github.com/duckstation/dependencies/releases/download/$DEPS_VERSION/deps-macos-universal.tar.xz"
         sha256sum --check --ignore-missing ../PREBUILT-SHA256SUMS
         tar -xf "deps-macos-universal.tar.xz"
         rm "deps-macos-universal.tar.xz"
diff --git a/.github/workflows/windows-build.yml b/.github/workflows/windows-build.yml
index 149ccdace..6d1608049 100644
--- a/.github/workflows/windows-build.yml
+++ b/.github/workflows/windows-build.yml
@@ -54,23 +54,23 @@ jobs:
         fetch-depth: 0
 
     - name: Download x64 Dependencies
-      shell: cmd
+      shell: bash
       run: |
-        set /p DEPS_VERSION=<dep\PREBUILT-VERSION
-        curl --retry 5 --retry-all-errors -LO "https://github.com/duckstation/dependencies/releases/download/%DEPS_VERSION%/deps-windows-x64.7z"
-        sha256sum --check --ignore-missing dep\PREBUILT-SHA256SUMS
-        "C:\Program Files\7-Zip\7z.exe" x -odep\prebuilt deps-windows-x64.7z
-        del /Q deps-windows-x64.7z
+        DEPS_VERSION=$(cat dep/PREBUILT-VERSION)
+        curl --fail --retry 5 --retry-all-errors -LO "https://github.com/duckstation/dependencies/releases/download/$DEPS_VERSION/deps-windows-x64.7z"
+        sha256sum --check --ignore-missing dep/PREBUILT-SHA256SUMS
+        7z x -odep/prebuilt deps-windows-x64.7z
+        rm deps-windows-x64.7z
 
     - name: Download ARM64 Dependencies
-      shell: cmd
+      shell: bash
       if: matrix.arch == 'arm64'
       run: |
-        set /p DEPS_VERSION=<dep\PREBUILT-VERSION
-        curl --retry 5 --retry-all-errors -LO "https://github.com/duckstation/dependencies/releases/download/%DEPS_VERSION%/deps-windows-arm64.7z"
-        sha256sum --check --ignore-missing dep\PREBUILT-SHA256SUMS
-        "C:\Program Files\7-Zip\7z.exe" x -odep\prebuilt deps-windows-arm64.7z
-        del /Q deps-windows-arm64.7z
+        DEPS_VERSION=$(cat dep/PREBUILT-VERSION)
+        curl --fail --retry 5 --retry-all-errors -LO "https://github.com/duckstation/dependencies/releases/download/$DEPS_VERSION/deps-windows-arm64.7z"
+        sha256sum --check --ignore-missing dep/PREBUILT-SHA256SUMS
+        7z x -odep/prebuilt deps-windows-arm64.7z
+        rm deps-windows-arm64.7z
 
     - name: Download Patch Archives
       shell: cmd