From 4f347bf626a317e6b8838d8a58368a765e5d4aa3 Mon Sep 17 00:00:00 2001 From: Stenzek Date: Wed, 24 Jan 2024 13:56:22 +1000 Subject: [PATCH] Qt: Add missing display setting help text --- src/core/fullscreen_ui.cpp | 2 ++ src/duckstation-qt/displaysettingswidget.cpp | 6 +++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/core/fullscreen_ui.cpp b/src/core/fullscreen_ui.cpp index 9cc7f5b18..9d4663f77 100644 --- a/src/core/fullscreen_ui.cpp +++ b/src/core/fullscreen_ui.cpp @@ -6952,6 +6952,7 @@ TRANSLATE_NOOP("FullscreenUI", "Show Controller Input"); TRANSLATE_NOOP("FullscreenUI", "Show Enhancement Settings"); TRANSLATE_NOOP("FullscreenUI", "Show FPS"); TRANSLATE_NOOP("FullscreenUI", "Show Frame Times"); +TRANSLATE_NOOP("FullscreenUI", "Show GPU Statistics"); TRANSLATE_NOOP("FullscreenUI", "Show GPU Usage"); TRANSLATE_NOOP("FullscreenUI", "Show OSD Messages"); TRANSLATE_NOOP("FullscreenUI", "Show Resolution"); @@ -6960,6 +6961,7 @@ TRANSLATE_NOOP("FullscreenUI", "Show Status Indicators"); TRANSLATE_NOOP("FullscreenUI", "Shows a visual history of frame times in the upper-left corner of the display."); TRANSLATE_NOOP("FullscreenUI", "Shows enhancement settings in the bottom-right corner of the screen."); TRANSLATE_NOOP("FullscreenUI", "Shows icons in the lower-right corner of the screen when a challenge/primed achievement is active."); +TRANSLATE_NOOP("FullscreenUI", "Shows information about the emulated GPU in the top-right corner of the display."); TRANSLATE_NOOP("FullscreenUI", "Shows on-screen-display messages when events occur."); TRANSLATE_NOOP("FullscreenUI", "Shows persistent icons when turbo is active or when paused."); TRANSLATE_NOOP("FullscreenUI", "Shows the current controller state of the system in the bottom-left corner of the display."); diff --git a/src/duckstation-qt/displaysettingswidget.cpp b/src/duckstation-qt/displaysettingswidget.cpp index fb8e237d7..bf81e59d3 100644 --- a/src/duckstation-qt/displaysettingswidget.cpp +++ b/src/duckstation-qt/displaysettingswidget.cpp @@ -57,7 +57,7 @@ DisplaySettingsWidget::DisplaySettingsWidget(SettingsWindow* dialog, QWidget* pa SettingWidgetBinder::BindWidgetToBoolSetting(sif, m_ui.showGPU, "Display", "ShowGPU", false); SettingWidgetBinder::BindWidgetToBoolSetting(sif, m_ui.showInput, "Display", "ShowInputs", false); SettingWidgetBinder::BindWidgetToBoolSetting(sif, m_ui.showGPUStatistics, "Display", "ShowGPUStatistics", false); - + connect(m_ui.renderer, QOverload::of(&QComboBox::currentIndexChanged), this, &DisplaySettingsWidget::populateGPUAdaptersAndResolutions); connect(m_ui.adapter, QOverload::of(&QComboBox::currentIndexChanged), this, @@ -129,6 +129,10 @@ DisplaySettingsWidget::DisplaySettingsWidget(SettingsWindow* dialog, QWidget* pa tr("Shows the host's CPU usage based on threads in the top-right corner of the display. This does not display the " "emulated system CPU's usage. If a value close to 100% is being displayed, this means your host's CPU is likely " "the bottleneck. In this case, you should reduce enhancement-related settings such as overclocking.")); + dialog->registerWidgetHelp(m_ui.showGPUStatistics, tr("Show GPU Statistics"), tr("Unchecked"), + tr("Shows information about the emulated GPU in the top-right corner of the display.")); + dialog->registerWidgetHelp(m_ui.showGPU, tr("Show GPU Usage"), tr("Unchecked"), + tr("Shows the host's GPU usage in the top-right corner of the display.")); dialog->registerWidgetHelp( m_ui.showInput, tr("Show Controller Input"), tr("Unchecked"), tr("Shows the current controller state of the system in the bottom-left corner of the display."));