From 2a4daa76f438e580ef0341ee7b3b4746763c8d59 Mon Sep 17 00:00:00 2001 From: Stenzek Date: Wed, 25 Feb 2026 01:41:43 +1000 Subject: [PATCH] Achievements: Default badge prefetch to enabled --- src/core/fullscreenui_settings.cpp | 2 +- src/core/settings.h | 4 +++- src/duckstation-qt/achievementsettingswidget.cpp | 5 +++-- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/core/fullscreenui_settings.cpp b/src/core/fullscreenui_settings.cpp index 9479b84e9..a4dba8222 100644 --- a/src/core/fullscreenui_settings.cpp +++ b/src/core/fullscreenui_settings.cpp @@ -4982,7 +4982,7 @@ void FullscreenUI::DrawAchievementsSettingsPage(std::unique_lock& se DrawToggleSetting(bsi, FSUI_ICONVSTR(ICON_FA_DOWNLOAD, "Prefetch Badges"), FSUI_VSTR("Downloads all locked achievement badges while starting the game. This will reduce " "delays in the images being shown when unlocking achievements."), - "Cheevos", "PrefetchBadges", false, enabled); + "Cheevos", "PrefetchBadges", Settings::DEFAULT_ACHIEVEMENT_BADGE_PREFETCH, enabled); DrawEnumSetting(bsi, FSUI_ICONVSTR(ICON_FA_ENVELOPE, "Notification Location"), FSUI_VSTR("Selects the screen location for achievement and leaderboard notifications."), "Cheevos", diff --git a/src/core/settings.h b/src/core/settings.h index 68eaa33f9..c602204a9 100644 --- a/src/core/settings.h +++ b/src/core/settings.h @@ -369,7 +369,7 @@ struct Settings : public GPUSettings bool achievements_leaderboard_trackers : 1 = true; bool achievements_sound_effects : 1 = true; bool achievements_progress_indicators : 1 = true; - bool achievements_prefetch_badges : 1 = false; + bool achievements_prefetch_badges : 1 = DEFAULT_ACHIEVEMENT_BADGE_PREFETCH; u8 achievements_notification_duration = DEFAULT_ACHIEVEMENT_NOTIFICATION_TIME; u8 achievements_leaderboard_duration = DEFAULT_LEADERBOARD_NOTIFICATION_TIME; @@ -651,9 +651,11 @@ struct Settings : public GPUSettings static constexpr bool DEFAULT_SAVE_STATE_BACKUPS = true; static constexpr bool DEFAULT_FAST_BOOT_VALUE = false; static constexpr u16 DEFAULT_GDB_SERVER_PORT = 2345; + static constexpr bool DEFAULT_ACHIEVEMENT_BADGE_PREFETCH = true; #else static constexpr bool DEFAULT_SAVE_STATE_BACKUPS = false; static constexpr bool DEFAULT_FAST_BOOT_VALUE = true; + static constexpr bool DEFAULT_ACHIEVEMENT_BADGE_PREFETCH = false; #endif }; diff --git a/src/duckstation-qt/achievementsettingswidget.cpp b/src/duckstation-qt/achievementsettingswidget.cpp index d44c30589..37076b69c 100644 --- a/src/duckstation-qt/achievementsettingswidget.cpp +++ b/src/duckstation-qt/achievementsettingswidget.cpp @@ -50,7 +50,8 @@ AchievementSettingsWidget::AchievementSettingsWidget(SettingsWindow* dialog, QWi Settings::DEFAULT_ACHIEVEMENT_NOTIFICATION_LOCATION, NotificationLocation::MaxCount); SettingWidgetBinder::BindWidgetToBoolSetting(sif, m_ui.leaderboardTrackers, "Cheevos", "LeaderboardTrackers", true); SettingWidgetBinder::BindWidgetToBoolSetting(sif, m_ui.soundEffects, "Cheevos", "SoundEffects", true); - SettingWidgetBinder::BindWidgetToBoolSetting(sif, m_ui.prefetchBadges, "Cheevos", "PrefetchBadges", false); + SettingWidgetBinder::BindWidgetToBoolSetting(sif, m_ui.prefetchBadges, "Cheevos", "PrefetchBadges", + Settings::DEFAULT_ACHIEVEMENT_BADGE_PREFETCH); SettingWidgetBinder::BindWidgetToEnumSetting( sif, m_ui.challengeIndicatorMode, "Cheevos", "ChallengeIndicatorMode", &Settings::ParseAchievementChallengeIndicatorMode, &Settings::GetAchievementChallengeIndicatorModeName, @@ -91,7 +92,7 @@ AchievementSettingsWidget::AchievementSettingsWidget(SettingsWindow* dialog, QWi dialog->registerWidgetHelp( m_ui.soundEffects, tr("Enable Sound Effects"), tr("Checked"), tr("Plays sound effects for events such as achievement unlocks and leaderboard submissions.")); - dialog->registerWidgetHelp(m_ui.prefetchBadges, tr("Prefetch Badges"), tr("Unchecked"), + dialog->registerWidgetHelp(m_ui.prefetchBadges, tr("Prefetch Badges"), tr("Checked"), tr("Downloads all locked achievement badges while starting the game. This will reduce " "delays in the images being shown when unlocking achievements.")); dialog->registerWidgetHelp(m_ui.notificationLocation, tr("Notification Location"), tr("Top Left"),