From 145474389d794d20e848024d8ca3c094c9f6a7a0 Mon Sep 17 00:00:00 2001
From: Stenzek <stenzek@gmail.com>
Date: Sat, 1 Aug 2026 14:17:33 +1000
Subject: [PATCH] Qt: Allow empty recommended value in settings help

---
 src/duckstation-qt/settingswindow.cpp | 18 ++++++++++++------
 src/duckstation-qt/settingswindow.h   |  3 ++-
 2 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/src/duckstation-qt/settingswindow.cpp b/src/duckstation-qt/settingswindow.cpp
index 39ced207c..b3f34c7cc 100644
--- a/src/duckstation-qt/settingswindow.cpp
+++ b/src/duckstation-qt/settingswindow.cpp
@@ -399,7 +399,8 @@ AchievementSettingsWidget* SettingsWindow::getAchievementSettingsWidget() const
   return findChild<AchievementSettingsWidget*>();
 }
 
-void SettingsWindow::registerWidgetHelp(QObject* object, QString title, QString recommended_value, QString text)
+void SettingsWindow::registerWidgetHelp(QObject* const object, const QString& title, const QString& recommended_value,
+                                        const QString& text)
 {
   if (!object)
     return;
@@ -408,11 +409,16 @@ void SettingsWindow::registerWidgetHelp(QObject* object, QString title, QString
   QString full_text;
   full_text += "<table width='100%' cellpadding='0' cellspacing='0'><tr><td><strong>";
   full_text += title;
-  full_text += "</strong></td><td align='right'><strong>";
-  full_text += tr("Recommended Value");
-  full_text += ": </strong>";
-  full_text += recommended_value;
-  full_text += "</td></table><hr>";
+  full_text += "</strong></td>";
+  if (!recommended_value.isEmpty())
+  {
+    full_text += "<td align='right'><strong>";
+    full_text += tr("Recommended Value");
+    full_text += ": </strong>";
+    full_text += recommended_value;
+    full_text += "</td>";
+  }
+  full_text += "</tr></table><hr>";
   full_text += text;
 
   m_widget_help_text_map[object] = std::move(full_text);
diff --git a/src/duckstation-qt/settingswindow.h b/src/duckstation-qt/settingswindow.h
index eed5182af..77fc266e6 100644
--- a/src/duckstation-qt/settingswindow.h
+++ b/src/duckstation-qt/settingswindow.h
@@ -59,7 +59,8 @@ public:
   GameListSettingsWidget* getGameListSettingsWidget() const;
   AchievementSettingsWidget* getAchievementSettingsWidget() const;
 
-  void registerWidgetHelp(QObject* object, QString title, QString recommended_value, QString text);
+  void registerWidgetHelp(QObject* const object, const QString& title, const QString& recommended_value,
+                          const QString& text);
   bool eventFilter(QObject* object, QEvent* event) override;
 
   // Helper functions for reading effective setting values (from game -> global settings).