Achievements: Defer game list data update

Avoids more potential deadlocks.

src/core/achievements.cpp

@@ -2699,7 +2699,7 @@ void Achievements::FinishRefreshHashDatabase()
   s_state.fetch_hash_library_result = nullptr;
 
   // update game list, we might have some new games that weren't in the seed database
-  GameList::UpdateAllAchievementData();
+  Host::RunOnCoreThread(&GameList::UpdateAllAchievementData);
 }
 
 bool Achievements::RefreshAllProgressDatabase(ProgressCallback* progress, Error* error)
@@ -2753,7 +2753,7 @@ void Achievements::RefreshAllProgressCallback(int result, const char* error_mess
   BuildProgressDatabase(list);
   rc_client_destroy_all_user_progress(list);
 
-  GameList::UpdateAllAchievementData();
+  Host::RunOnCoreThread(&GameList::UpdateAllAchievementData);
 
   if (result_ud)
     result_ud->first = true;
@@ -3165,8 +3165,11 @@ void Achievements::UpdateProgressDatabase()
   // update the game list, this should be fairly quick
   if (s_state.game_hash.has_value())
   {
-    GameList::UpdateAchievementData(s_state.game_hash.value(), s_state.game_id, num_achievements, achievements_unlocked,
-                                    achievements_unlocked_hardcore);
+    Host::RunOnCoreThread([game_hash = s_state.game_hash.value(), game_id = s_state.game_id, num_achievements,
+                           achievements_unlocked, achievements_unlocked_hardcore]() {
+      GameList::UpdateAchievementData(game_hash, game_id, num_achievements, achievements_unlocked,
+                                      achievements_unlocked_hardcore);
+    });
   }
 
   // done asynchronously so we don't hitch on disk I/O
@@ -3289,7 +3292,7 @@ void Achievements::ClearProgressDatabase()
       ERROR_LOG("Failed to delete progress database: {}", error.GetDescription());
   }
 
-  GameList::UpdateAllAchievementData();
+  Host::RunOnCoreThread(&GameList::UpdateAllAchievementData);
 }
 
 Achievements::ProgressDatabase::ProgressDatabase() = default;

src/core/game_list.cpp

@@ -855,7 +855,7 @@ void GameList::PopulateEntryAchievements(Entry* entry, const Achievements::Progr
   }
 }
 
-void GameList::UpdateAchievementData(const std::span<u8, 16> hash, u32 game_id, u32 num_achievements, u32 num_unlocked,
+void GameList::UpdateAchievementData(std::span<const u8, 16> hash, u32 game_id, u32 num_achievements, u32 num_unlocked,
                                      u32 num_unlocked_hardcore)
 {
   std::unique_lock lock(s_state.mutex);

src/core/game_list.h

@@ -179,7 +179,7 @@ std::string GetGameIconPath(const GameList::Entry* entry);
 void ReloadMemcardTimestampCache();
 
 /// Updates game list with new achievement unlocks.
-void UpdateAchievementData(const std::span<u8, 16> hash, u32 game_id, u32 num_achievements, u32 num_unlocked,
+void UpdateAchievementData(std::span<const u8, 16> hash, u32 game_id, u32 num_achievements, u32 num_unlocked,
                            u32 num_unlocked_hardcore);
 void UpdateAllAchievementData();