You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
There are many functions in git_cl that appear unused, although it's possible that some of them are used in other places, where git_cl may be imported as a library. This CL just removes some of the private ones, which at least were not supposed to be used from other places. Things removed here: - _get_commiter_timestamp - _git_amend_head - GitCookiesChecker._get_usernames_of_domain - constants MERGE_BRANCH, CHERRY_PICK_BRANCH; the comment says that these are supposed to be used in CMDland, but apparently they aren't. contextlib which is only used by this, is also removed - CodereviewSettingsFileMock in git_cl_test; it is not used anywhere in the test, and I assume that nobody's importing and using git_cl_test... git_cl_test still passes, git cl seems to still work Change-Id: Ib8eee0dfb181c8cda04c0894d2daea52b3ad42ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1818621 Reviewed-by: Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> |
6 years ago | |
---|---|---|
.. | ||
gstools | 13 years ago | |
OWNERS | 7 years ago | |
auth_test.py | 7 years ago | |
bot_update_coverage_test.py | 6 years ago | |
cipd_bootstrap_test.py | 7 years ago | |
download_from_google_storage_unittest.py | 6 years ago | |
fix_encoding_test.py | 6 years ago | |
gclient_eval_unittest.py | 6 years ago | |
gclient_scm_test.py | 6 years ago | |
gclient_smoketest.py | 6 years ago | |
gclient_test.py | 6 years ago | |
gclient_utils_test.py | 6 years ago | |
git_cache_test.py | 6 years ago | |
git_cl_creds_check_report.txt | 8 years ago | |
git_cl_test.py | 6 years ago | |
git_common_test.py | 6 years ago | |
git_dates_test.py | 10 years ago | |
git_drover_test.py | 8 years ago | |
git_footers_test.py | 8 years ago | |
git_hyper_blame_test.py | 7 years ago | |
git_number_test.py | 10 years ago | |
git_rebase_update_test.py | 7 years ago | |
gsutil_test.py | 8 years ago | |
metrics_test.py | 6 years ago | |
ninjalog_uploader_test.py | 7 years ago | |
owners_finder_test.py | 8 years ago | |
owners_unittest.py | 6 years ago | |
presubmit_unittest.py | 6 years ago | |
recipes_test.py | 7 years ago | |
roll_dep_test.py | 7 years ago | |
scm_unittest.py | 6 years ago | |
subprocess2_test.py | 6 years ago | |
upload_to_google_storage_unittest.py | 6 years ago | |
watchlists_unittest.py | 6 years ago |