You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
Bruce Dawson fc3fb20e51 Revert "Reland "use python3 for goma related scripts""
This reverts commit 2a6dffaf4b.

Reason for revert: with this change in depot_tools when I run "goma_ctl ensure_start" from cmd.exe I get
"The system cannot find the path specified."

Original change's description:
> Reland "use python3 for goma related scripts"
>
> This reverts commit 59140d436a.
>
> Reason for revert:
> Make this works in git bash.
>
> Original change's description:
> > Revert "use python3 for goma related scripts"
> >
> > This reverts commit 138ec7c56d.
> >
> > Reason for revert:
> > This might have caused the following issue:
> > https://bugs.chromium.org/p/chromium/issues/detail?id=1221233
> >
> > Original change's description:
> > > use python3 for goma related scripts
> > >
> > > This uses python3 like autoninja{,.bat}.
> > > https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja
> > > https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja.bat
> > >
> > > Change-Id: I4daf1892024358c5b7d88b1e32b15c82cb4411d2
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2968069
> > > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> > > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
> > > Reviewed-by: Dirk Pranke <dpranke@google.com>
> >
> > Change-Id: Ideb5004cf18c91c1404066622244a8527f5248f3
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2972023
> > Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > Reviewed-by: Dirk Pranke <dpranke@google.com>
>
> Bug: 1221233
> Change-Id: I815a774faa2e4fbca0f262667ea89709a09e146b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2979560
> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> Reviewed-by: Allen Bauer <kylixrd@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

Bug: 1221233
Change-Id: I5050b9199f3076e6d6f812b8bac01e8cd1dc53bf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2992150
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
4 years ago
bootstrap
fetch_configs
git-templates
infra Roll recipe dependencies (trivial). 4 years ago
man
python-bin
python2-bin
recipes Roll recipe dependencies (trivial). 4 years ago
testing_support
tests Reland "Reland "Update gsutil to use gsutil version 4.61, python3."" 4 years ago
third_party
win_toolchain
zsh-goodies
.cipd_impl.ps1
.gitattributes chrome_set_ver: punt old script 4 years ago
.gitignore
.style.yapf
.vpython
.vpython3
CROS_OWNERS
DIR_METADATA
GOMA_OWNERS
LICENSE
LUCI_OWNERS
OWNERS chrome_set_ver: punt old script 4 years ago
PRESUBMIT.py
README.gclient.md
README.git-cl.md
README.md
WATCHLISTS
auth.py
autoninja
autoninja.bat
autoninja.py
bb
bb.bat
bootstrap_python3
breakpad.py
cbuildbot
cipd
cipd.bat
cipd_bin_setup.bat
cipd_bin_setup.sh
cipd_client_version
cipd_client_version.digests
cipd_manifest.txt Revert "[dirmd] Roll dirmd" 4 years ago
cipd_manifest.versions Revert "[dirmd] Roll dirmd" 4 years ago
cit
cit.bat
cit.py
clang-format
clang-format.bat
clang_format.py
clang_format_merge_driver
clang_format_merge_driver.bat
clang_format_merge_driver.py
codereview.settings
compile_single_file
compile_single_file.bat
compile_single_file.py
cpplint.bat
cpplint.py
cpplint_chromium.py
cros
cros_sdk
crosjobs
detect_host_arch.py
dirmd
dirmd.bat
download_from_google_storage
download_from_google_storage.bat
download_from_google_storage.py Reland "Reland "Update gsutil to use gsutil version 4.61, python3."" 4 years ago
ensure_bootstrap
fetch
fetch.bat
fetch.py
fix_encoding.py
gclient
gclient-new-workdir.py
gclient.bat
gclient.py
gclient_completion.sh
gclient_eval.py
gclient_paths.py
gclient_scm.py
gclient_utils.py
gerrit_client.py
gerrit_util.py gerrit_util: Make GceAuthenticator also consider proxy errors in httplib2 4 years ago
git-cache
git-cl
git-crrev-parse
git-drover
git-find-releases
git-footers
git-freeze
git-gs
git-hyper-blame
git-map
git-map-branches
git-mark-merge-base
git-migrate-default-branch
git-nav-downstream
git-nav-upstream
git-new-branch
git-number
git-rebase-update
git-rename-branch
git-reparent-branch
git-retry
git-runhooks
git-squash-branch
git-thaw
git-upstream-diff
git_cache.py
git_cl.py Add use_python3 to codereview.settings to set default for PRESUBMITs. 4 years ago
git_cl_completion.sh
git_common.py
git_dates.py
git_drover.py
git_find_releases.py
git_footers.py
git_freezer.py
git_hyper_blame.py
git_map.py
git_map_branches.py
git_mark_merge_base.py
git_migrate_default_branch.py
git_nav_downstream.py
git_new_branch.py
git_number.py
git_rebase_update.py
git_rename_branch.py
git_reparent_branch.py
git_retry.py
git_squash_branch.py
git_upstream_diff.py
gn
gn.bat
gn.py
goma_auth Revert "Reland "use python3 for goma related scripts"" 4 years ago
goma_auth.bat Revert "Reland "use python3 for goma related scripts"" 4 years ago
goma_ctl Revert "Reland "use python3 for goma related scripts"" 4 years ago
goma_ctl.bat Revert "Reland "use python3 for goma related scripts"" 4 years ago
gsutil.py Reland "Reland "Update gsutil to use gsutil version 4.61, python3."" 4 years ago
gsutil.py.bat
gsutil.py.vpython3 Reland "Reland "Update gsutil to use gsutil version 4.61, python3."" 4 years ago
led
led.bat
lockfile.py
luci-auth
luci-auth.bat
lucicfg
lucicfg.bat
mac_toolchain
metrics.README.md
metrics.py
metrics_utils.py metrics: Don't collect metrics on DEPOT_TOOLS_METRICS=0 4 years ago
my_activity.py
ninja
ninja-linux32
ninja-linux64
ninja-mac
ninja.exe
ninjalog.README.md
ninjalog_uploader.py
ninjalog_uploader_wrapper.py
owners.py
owners_client.py
owners_finder.py
pinpoint
pinpoint.bat
post_build_ninja_summary.py
presubmit_canned_checks.py Add a new argument to skip shebang checks on python3 4 years ago
presubmit_canned_checks_test.py
presubmit_canned_checks_test_mocks.py
presubmit_support.py Add use_python3 to codereview.settings to set default for PRESUBMITs. 4 years ago
profile.xml
prpc
prpc.bat
pylint
pylint-1.5
pylint-1.6
pylint-1.7
pylint-1.8
pylint-1.9
pylint-2.6
pylint-2.6.bat Add pylint-2.6.bat to prepare for migration 4 years ago
pylint.bat
pylint_main.py
pylintrc
python_runner.sh
rdb
rdb.bat
rdb_wrapper.py
repo
repo_launcher
roll-dep
roll-dep.bat
roll_dep.py
scm.py
setup_color.py
split_cl.py Update format of `git cl split` 4 years ago
subcommand.py
subprocess2.py
update_depot_tools
update_depot_tools.bat
update_depot_tools_toggle.py
upload_metrics.py
upload_to_google_storage.py Reland "Reland "Update gsutil to use gsutil version 4.61, python3."" 4 years ago
vpython
vpython.bat
vpython3
vpython3.bat
watchlists.py
weekly
whitespace.txt
win32imports.py
wtf
yapf
yapf.bat

README.md

depot_tools

Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.