You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
f6ddfa4ba0
Until an issue is uploaded to Rietveld, we don't know the official email address to use for an owners check. There are three ways to fix this: we could attempt to log in to rietveld prior to doing the check and extract the address to use, or we could use ~/.last_codereview_email_address, or we can use the email address we can determine from the checkout. All three options have flaws; the first is particularly awkward since there doesn't seem to be a good way to fetch the email without posting an issue. The second is flawed if we use different addresses for different repos, and the third is flawed if the checkout's email address is different from the rietveld address, or if it is anonymous. However, since this is only being used for owners checks (in this case), anonymous checkouts probably don't matter, and hopefully the cases where the email addresses differ are rare. R=maruel@chromium.org BUG=118388, 150049 Review URL: https://chromiumcodereview.appspot.com/12377023 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@186259 0039d316-1c4b-4281-b951-d872f2087c98 |
13 years ago | |
|---|---|---|
| .. | ||
| subversion_config | ||
| abandon.sh | 14 years ago | |
| basic.sh | 14 years ago | |
| breakpad_unittest.py | ||
| checkout_test.py | 13 years ago | |
| fix_encoding_test.py | ||
| gcl_unittest.py | 13 years ago | |
| gclient_scm_test.py | 13 years ago | |
| gclient_smoketest.py | 13 years ago | |
| gclient_test.py | 13 years ago | |
| gclient_utils_test.py | 13 years ago | |
| git_cl_test.py | 13 years ago | |
| hooks.sh | 14 years ago | |
| owners.sh | 14 years ago | |
| owners_unittest.py | 13 years ago | |
| patch.sh | 14 years ago | |
| patch_test.py | 13 years ago | |
| post-dcommit-hook-test.sh | 14 years ago | |
| presubmit_unittest.py | 13 years ago | |
| push-basic.sh | 14 years ago | |
| push-from-logs.sh | 13 years ago | |
| rename.sh | 14 years ago | |
| rietveld_test.py | 13 years ago | |
| sample_pre_commit_hook | ||
| save-description-on-failure.sh | 14 years ago | |
| scm_unittest.py | 13 years ago | |
| submit-from-new-dir.sh | 14 years ago | |
| submodule-merge-test.sh | 14 years ago | |
| subprocess2_test.py | ||
| test-lib.sh | 14 years ago | |
| trychange_unittest.py | 13 years ago | |
| upload-local-tracking-branch.sh | 14 years ago | |
| upload-stale.sh | 14 years ago | |
| upstream.sh | 14 years ago | |
| watchlists_unittest.py | ||