You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
351c61da20
Git cl decides if git-numberer is enabled on a repository by writing Gerrit's project.config from refs/meta/config into a tempfile, which is then queried using `git config -f tempfile --get ...`. The file itself is only flushed, but not closed after writing because Python's tempfile.NamedTemporaryFile is deleted on closing. This worked fine on Linix/Mac, but not on Windows, where `git config` apparently doesn't see file or its contents. This CL rewrites the above using yet another contexmanager temp directory into which a file is written and closed before git config is ran. R=machenbach@chromium.org,grt@chromium.org BUG=683202 Change-Id: I7974d66b1b2b0478ab4b6f7ac04e547a4981c46c Reviewed-on: https://chromium-review.googlesource.com/430719 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> |
9 years ago | |
|---|---|---|
| .. | ||
| gstools | ||
| subversion_config | ||
| abandon.sh | 9 years ago | |
| basic.sh | 9 years ago | |
| bot_update_coverage_test.py | 9 years ago | |
| checkout_test.py | 9 years ago | |
| download_from_google_storage_unittests.py | 9 years ago | |
| fix_encoding_test.py | ||
| gclient_scm_test.py | 9 years ago | |
| gclient_smoketest.py | 9 years ago | |
| gclient_test.py | 9 years ago | |
| gclient_utils_test.py | 9 years ago | |
| git_cache_test.py | ||
| git_cl_test.py | 9 years ago | |
| git_common_test.py | 9 years ago | |
| git_dates_test.py | ||
| git_drover_test.py | 9 years ago | |
| git_footers_test.py | 9 years ago | |
| git_hyper_blame_test.py | 9 years ago | |
| git_number_test.py | ||
| git_rebase_update_test.py | ||
| gsutil_test.py | ||
| hooks.sh | 9 years ago | |
| owners.sh | 9 years ago | |
| owners_finder_test.py | 9 years ago | |
| owners_unittest.py | 9 years ago | |
| patch.sh | 9 years ago | |
| patch_test.py | ||
| post-land-hook-test.sh | 9 years ago | |
| presubmit_unittest.py | 9 years ago | |
| push-from-logs.sh | 9 years ago | |
| recipes_test.py | ||
| rietveld_test.py | 9 years ago | |
| sample_pre_commit_hook | ||
| save-description-on-failure.sh | 9 years ago | |
| scm_unittest.py | 9 years ago | |
| submit-from-new-dir.sh | 9 years ago | |
| subprocess2_test.py | 9 years ago | |
| test-lib.sh | 9 years ago | |
| upload-local-tracking-branch.sh | 9 years ago | |
| upload-stale.sh | 9 years ago | |
| upload_to_google_storage_unittests.py | 9 years ago | |
| watchlists_unittest.py | 9 years ago | |