aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'de9e3cabe6'
${ noResults }
depot_tools/tests
History
Edward Lemur de9e3cabe6 presubmit: Make ThreadPool surface exceptions on CallCommand. 
Exceptions other than OSError are not surfaced.
This caused errors like this to be printed, but not block presubmit,
allowing bugs to sneak in.

Exception in thread Thread-8:
Traceback (most recent call last):
  File "C:\b\s\w\ir\cipd_bin_packages\cpython\bin\Lib\threading.py", line 801, in __bootstrap_inner
    self.run()
  File "C:\b\s\w\ir\cipd_bin_packages\cpython\bin\Lib\threading.py", line 754, in run
    self.__target(*self.__args, **self.__kwargs)
  File "C:\b\s\w\ir\kitchen-checkout\depot_tools\presubmit_support.py", line 199, in _WorkerFn
    result = self.CallCommand(test)
  File "C:\b\s\w\ir\kitchen-checkout\depot_tools\presubmit_support.py", line 170, in CallCommand
    p = subprocess.Popen(cmd, **test.kwargs)
  File "C:\b\s\w\ir\kitchen-checkout\depot_tools\subprocess2.py", line 143, in __init__
    super(Popen, self).__init__(args, **kwargs)
  File "C:\b\s\w\ir\cipd_bin_packages\cpython\bin\Lib\subprocess.py", line 390, in __init__
    errread, errwrite)
  File "C:\b\s\w\ir\cipd_bin_packages\cpython\bin\Lib\subprocess.py", line 640, in _execute_child
    startupinfo)
TypeError: environment can only contain strings

https://logs.chromium.org/logs/infra/buildbucket/cr-buildbucket.appspot.com/8898840708364523888/+/steps/presubmit/0/stdout

Change-Id: I34e65d8c0050eed7ed26fd782e0a5dc8616f30f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1877051
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
 		6 years ago
..
gstools
…
OWNERS [ninjalog_uploader] add tests 7 years ago
auth_test.py depot_tools: Clean up auth.py 6 years ago
bot_update_coverage_test.py Use assertEqual() rather than assertEquals() in Python tests. 6 years ago
cipd_bootstrap_test.py [cipd] Add presubmit support for checking *.digests file. 7 years ago
download_from_google_storage_unittest.py Make download_from_google_storage_unittest.py work with Python 3. 6 years ago
fix_encoding_test.py Use assertEqual() rather than assertEquals() in Python tests. 6 years ago
gclient_eval_unittest.py Add support for multi argument ands and ors, and the same precedence with 6 years ago
gclient_scm_test.py Add logging to bot_update.py and gclient_scm.py 6 years ago
gclient_smoketest.py Make gclient.py warn on Python 3 6 years ago
gclient_test.py Reland "gclient_utils: buffer output as bytestrings in Annotated" 6 years ago
gclient_utils_test.py Reland "gclient_utils: buffer output as bytestrings in Annotated" 6 years ago
gerrit_util_test.py gerrit_util: Add tests for CookiesAuthenticator 6 years ago
git_cache_test.py depot_tools: Run git_cache_test and git_footers_test on windows. 6 years ago
git_cl_creds_check_report.txt
…
git_cl_test.py Revert "git-cl: Add diff lines of context setting." 6 years ago
git_common_test.py git-common: Explicitly specify utf-8 when encoding. 6 years ago
git_dates_test.py Use assertEqual() rather than assertEquals() in Python tests. 6 years ago
git_drover_test.py git-drover: Fix tests to run on Python 3. 6 years ago
git_footers_test.py depot_tools: Run git_cache_test and git_footers_test on windows. 6 years ago
git_hyper_blame_test.py git-hyper-blame: Make tests run on Python 3. 6 years ago
git_number_test.py git-number: Make tests run on Python 3. 6 years ago
git_rebase_update_test.py Use assertEqual() rather than assertEquals() in Python tests. 6 years ago
gsutil_test.py Use assertEqual() rather than assertEquals() in Python tests. 6 years ago
metrics_test.py depot_tools: Run some tests on Python 3 on the bots. 6 years ago
ninjalog_uploader_test.py [ninjalog] fully anonymize build stats before sending 7 years ago
owners_finder_test.py
…
owners_unittest.py Presubmit: Fix relative owners check 6 years ago
presubmit_unittest.py presubmit: Make ThreadPool surface exceptions on CallCommand. 6 years ago
recipes_test.py [recipes] Remove deprecated (ignored) --use-bootstrap flag 7 years ago
roll_dep_test.py roll-dep: Use gclient setdep/getdep. 7 years ago
scm_unittest.py depot_tools: Run some tests on Python 3 on the bots. 6 years ago
subprocess2_test.py depot_tools: Run some tests on Python 3 on the bots. 6 years ago
upload_to_google_storage_unittest.py Make upload_to_google_storage.py and tests work with Python 3. 6 years ago
watchlists_unittest.py depot_tools: Make watchlist tests use mock and remove pymox. 6 years ago