You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
Edward Lemur de9e3cabe6 presubmit: Make ThreadPool surface exceptions on CallCommand.
Exceptions other than OSError are not surfaced.
This caused errors like this to be printed, but not block presubmit,
allowing bugs to sneak in.

Exception in thread Thread-8:
Traceback (most recent call last):
  File "C:\b\s\w\ir\cipd_bin_packages\cpython\bin\Lib\threading.py", line 801, in __bootstrap_inner
    self.run()
  File "C:\b\s\w\ir\cipd_bin_packages\cpython\bin\Lib\threading.py", line 754, in run
    self.__target(*self.__args, **self.__kwargs)
  File "C:\b\s\w\ir\kitchen-checkout\depot_tools\presubmit_support.py", line 199, in _WorkerFn
    result = self.CallCommand(test)
  File "C:\b\s\w\ir\kitchen-checkout\depot_tools\presubmit_support.py", line 170, in CallCommand
    p = subprocess.Popen(cmd, **test.kwargs)
  File "C:\b\s\w\ir\kitchen-checkout\depot_tools\subprocess2.py", line 143, in __init__
    super(Popen, self).__init__(args, **kwargs)
  File "C:\b\s\w\ir\cipd_bin_packages\cpython\bin\Lib\subprocess.py", line 390, in __init__
    errread, errwrite)
  File "C:\b\s\w\ir\cipd_bin_packages\cpython\bin\Lib\subprocess.py", line 640, in _execute_child
    startupinfo)
TypeError: environment can only contain strings

https://logs.chromium.org/logs/infra/buildbucket/cr-buildbucket.appspot.com/8898840708364523888/+/steps/presubmit/0/stdout

Change-Id: I34e65d8c0050eed7ed26fd782e0a5dc8616f30f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1877051
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
6 years ago
bootstrap Reland "depot_tools: Bootstrap Python 3 on Linux/Mac" 6 years ago
fetch_configs Remove checkout_mobile_internal from {android,ios}_internal fetch configs. 6 years ago
git-templates
infra Roll recipe dependencies (trivial). 6 years ago
man python3 improvements 6 years ago
recipes Roll recipe dependencies (trivial). 6 years ago
testing_support Presubmit: Fix relative owners check 6 years ago
tests presubmit: Make ThreadPool surface exceptions on CallCommand. 6 years ago
third_party depot_tools: Remove oauth2client. 6 years ago
win_toolchain python3 improvements 6 years ago
zsh-goodies
.gitattributes git-cl: Run using vpython 6 years ago
.gitignore Reland "depot_tools: Bootstrap Python 3 on Linux/Mac" 6 years ago
.style.yapf
.vpython depot_tools: Include httplib2 using vpython. 6 years ago
.vpython3 Revert "presubmit_support: Fix tests on Python 3." 6 years ago
CROS_OWNERS CROS_OWNERS: update 6 years ago
LICENSE
OWNERS Add a COMPONENT entry to the OWNERS file. 6 years ago
PRESUBMIT.py depot_tools: Run git_cache_test and git_footers_test on windows. 6 years ago
README.gclient.md
README.git-cl.md README.git-cl.md: Remove reference to Rietveld 6 years ago
README.md Update depot_tools README cpplint section 7 years ago
annotated_gclient.py python3 improvements 6 years ago
auth.py depot_tools: Include httplib2 using vpython. 6 years ago
autoninja python3 improvements 6 years ago
autoninja.bat [depot_tools] Cap num_cores to RAM/2GB under local jumbo builds 6 years ago
autoninja.py Handle GOMA_DISABLED more precisely 6 years ago
bb do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
bb.bat [bb] Deploy bb 6 years ago
bootstrap_python3 Reland "depot_tools: Bootstrap Python 3 on Linux/Mac" 6 years ago
breakpad.py
cbuildbot simplify the chromite wrappers 6 years ago
chrome_set_ver simplify the chromite wrappers 6 years ago
cipd do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
cipd.bat
cipd.ps1
cipd_bin_setup.bat Revert "put goma client in depot_tools" 6 years ago
cipd_bin_setup.sh Revert "put goma client in depot_tools" 6 years ago
cipd_client_version cipd: update to 2a121dde. 6 years ago
cipd_client_version.digests cipd: update to 2a121dde. 6 years ago
cipd_manifest.txt vpython: e317c7d2c17d4c3460ee37524dfce4e1dee4306a. 6 years ago
cipd_manifest.versions vpython: e317c7d2c17d4c3460ee37524dfce4e1dee4306a. 6 years ago
cit Revert "Reland "depot_tools: Move six to depot_tools' .vpython"" 6 years ago
cit.bat Revert "Reland "depot_tools: Move six to depot_tools' .vpython"" 6 years ago
cit.py Revert "Reland "depot_tools: Move six to depot_tools' .vpython"" 6 years ago
clang-format
clang-format.bat
clang_format.py Convert print statements to Python 3 style 6 years ago
clang_format_merge_driver
clang_format_merge_driver.bat
clang_format_merge_driver.py Convert except statements to be Python 3 compatible 6 years ago
codereview.settings
compile_single_file
compile_single_file.bat
compile_single_file.py Make it clear that compile_single_file.py doesn't support Jumbo builds 6 years ago
cpplint.bat
cpplint.py python3 improvements 6 years ago
cpplint_chromium.py
cros simplify the chromite wrappers 6 years ago
cros_sdk simplify the chromite wrappers 6 years ago
crosjobs Add crosjobs shim script 6 years ago
dart_format.py Convert except statements to be Python 3 compatible 6 years ago
detect_host_arch.py Improve gclient Python 3 compatibility 6 years ago
download_from_google_storage Revert "depot_tools: Run Python scripts using vpython (Part 2)" 6 years ago
download_from_google_storage.bat Revert "depot_tools: Run Python scripts using vpython (Part 2)" 6 years ago
download_from_google_storage.py download_from_google_storage: Decode string passed to re.search() 6 years ago
ensure_bootstrap Reland "depot_tools: Bootstrap Python 3 on Linux/Mac" 6 years ago
fetch [fetch] use py3 for fetch 6 years ago
fetch.bat [fetch] use py3 for fetch 6 years ago
fetch.py Reland "depot_tools: Use vpython to execute fetch." 6 years ago
fix_encoding.py fix_encoding: Decode bytestrings on Python 3 6 years ago
gclient gclient: Skip calling update_depot_tools if DEPOT_TOOLS_UPDATE is 0. 6 years ago
gclient-new-workdir.py Revert "depot_tools: Run Python scripts using vpython (Part 2)" 6 years ago
gclient.bat gclient: Skip calling update_depot_tools if DEPOT_TOOLS_UPDATE is 0. 6 years ago
gclient.py python3 improvements 6 years ago
gclient_completion.sh
gclient_eval.py python3 improvements 6 years ago
gclient_paths.py Import gclient_utils for gclient_paths CheckCallAndFilter 6 years ago
gclient_scm.py Fix gclient crash with unicode strings in .gclient files. 6 years ago
gclient_utils.py gclient: When deleting untracked files, gracefully handle symlinks that point to dirs. 6 years ago
gerrit_client.py [git-cl] Lint and clean-up git-cl, test, and related modules 6 years ago
gerrit_util.py Revert "presubmit_support: Fix tests on Python 3." 6 years ago
git-cache
git-cl
git-crrev-parse
git-drover
git-find-releases
git-footers
git-freeze
git-gs
git-hyper-blame
git-map
git-map-branches
git-mark-merge-base
git-nav-downstream
git-nav-upstream Make git-nav-upstream use the upstream branch name 6 years ago
git-new-branch
git-number
git-rebase-update
git-rename-branch
git-reparent-branch
git-retry
git-runhooks Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git-squash-branch
git-thaw
git-upstream-diff
git_cache.py Store up to 30000 packet log lines for git fetch. 6 years ago
git_cl.py Revert "git-cl: Add diff lines of context setting." 6 years ago
git_cl_completion.sh
git_common.py git-common: Explicitly specify utf-8 when encoding. 6 years ago
git_dates.py
git_drover.py git-drover: Fix tests to run on Python 3. 6 years ago
git_find_releases.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git_footers.py depot_tools: Run git_footers_test on Python 3. 6 years ago
git_freezer.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git_hyper_blame.py depot_tools: Run git_common_test in Python 3 6 years ago
git_map.py python3 improvements 6 years ago
git_map_branches.py python3 improvements 6 years ago
git_mark_merge_base.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git_nav_downstream.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git_new_branch.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git_number.py git-number: Make tests run on Python 3. 6 years ago
git_rebase_update.py python3 improvements 6 years ago
git_rename_branch.py python3 improvements 6 years ago
git_reparent_branch.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git_retry.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git_squash_branch.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git_upstream_diff.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
gn
gn.bat
gn.py Convert print statements to Python 3 style 6 years ago
gsutil.py [git-cl] Lint and clean-up git-cl, test, and related modules 6 years ago
gsutil.py.bat
gsutil.vpython gsutil: Bump asn1crypto version to 1.0.1 6 years ago
led do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
led.bat
luci-auth do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
luci-auth.bat
lucicfg do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
lucicfg.bat [cipd] Add lucicfg tool. 7 years ago
mac_toolchain do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
metrics.README.md metrics: Collect full timestamps. 6 years ago
metrics.py depot_tools: Make some changes to make metrics collection compatible with Python 3. 6 years ago
metrics_utils.py depot_tools: Make some changes to make metrics collection compatible with Python 3. 6 years ago
my_activity.py depot_tools: Include httplib2 using vpython. 6 years ago
ninja
ninja-linux32
ninja-linux64
ninja-mac
ninja.exe
ninjalog.README.md [ninjalog] add ninjalog.README.md 7 years ago
ninjalog_uploader.py Remove unused imports in depot_tools/*.py 6 years ago
ninjalog_uploader_wrapper.py Convert print statements to Python 3 style 6 years ago
owners.py Presubmit: Fix relative owners check 6 years ago
owners_finder.py Convert print statements to Python 3 style 6 years ago
post_build_ninja_summary.py Convert print statements to Python 3 style 6 years ago
presubmit_canned_checks.py Revert "presubmit_support: Fix tests on Python 3." 6 years ago
presubmit_support.py presubmit: Make ThreadPool surface exceptions on CallCommand. 6 years ago
profile.xml
prpc do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
prpc.bat
pylint pylint: rework wrapper to use vpython for multiple versions 6 years ago
pylint-1.5 pylint: rework wrapper to use vpython for multiple versions 6 years ago
pylint-1.6 pylint: rework wrapper to use vpython for multiple versions 6 years ago
pylint-1.7 pylint: rework wrapper to use vpython for multiple versions 6 years ago
pylint-1.8 pylint: rework wrapper to use vpython for multiple versions 6 years ago
pylint-1.9 pylint: rework wrapper to use vpython for multiple versions 6 years ago
pylint.bat pylint: rework wrapper to use vpython for multiple versions 6 years ago
pylint_main.py pylint: rework wrapper to use vpython for multiple versions 6 years ago
pylintrc pylintrc: disable score reports 6 years ago
python_runner.sh git-cl: Run using vpython 6 years ago
repo Reland "repo: pull in updates from latest release" 6 years ago
roll-dep Revert "depot_tools: Run Python scripts using vpython (Part 2)" 6 years ago
roll-dep-svn Revert "depot_tools: Run Python scripts using vpython (Part 2)" 6 years ago
roll-dep-svn.bat Revert "depot_tools: Run Python scripts using vpython (Part 2)" 6 years ago
roll-dep.bat Revert "depot_tools: Run Python scripts using vpython (Part 2)" 6 years ago
roll_dep.py python3 improvements 6 years ago
roll_dep_svn.py Revert "depot_tools: Run Python scripts using vpython (Part 2)" 6 years ago
scm.py Remove unused imports in depot_tools/*.py 6 years ago
setup_color.py setup_color: Don't output an error if GetConsoleMode fails 6 years ago
split_cl.py python3 improvements 6 years ago
subcommand.py depot_toools: Make subcommand Python 3 compatible. 6 years ago
subprocess2.py depot_tools: Simplify subprocess2. 6 years ago
update_depot_tools Reland "depot_tools: Bootstrap Python 3 on Linux/Mac" 6 years ago
update_depot_tools.bat Reland "depot_tools: Bootstrap Python 3 on Linux/Mac" 6 years ago
update_depot_tools_toggle.py
upload_metrics.py Revert "Reland "depot_tools: Move six to depot_tools' .vpython"" 6 years ago
upload_to_google_storage.py Make upload_to_google_storage.py and tests work with Python 3. 6 years ago
vpython do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
vpython.bat
vpython3 [vpython] Roll to 98a268c6432f18aedd55d62b9621765316dc2a16 6 years ago
vpython3.bat [vpython] Roll to 98a268c6432f18aedd55d62b9621765316dc2a16 6 years ago
watchlists.py Trivial: Removing gendered pronouns from watchlists.py. 6 years ago
weekly Convert print statements to Python 3 style 6 years ago
wtf Convert print statements to Python 3 style 6 years ago
yapf
yapf.bat

README.md

depot_tools

Tools for working with Chromium development. It requires python 2.7.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.