You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
thakis adcd4b78d5 presubmit_support: Remove a noisy logging.debug()
On a CL with a single file, presubmit writes all this noise:

Running /b/build/slave/linux/build/src/PRESUBMIT.py
DEBUG:root:Running CheckChangeOnCommit in /b/build/slave/linux/build/src/PRESUBMIT.py
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.(cc|cpp|cxx|mm)$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:git diff -p --no-color --no-prefix --no-ext-diff 691e0c7d46341465de7a605b5f2aee941ccfedc0...HEAD --no-renames;  cwd=/b/build/slave/linux/build/src
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:/usr/bin/python /b/build/slave/linux/build/src/tools/checkperms/checkperms.py --root /b/build/slave/linux/build/src --file content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:^(android_webview|base|content|net)[\\\/].* matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.(cc|cpp|cxx|mm)$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:LocalPaths: ['content/browser/gpu/gpu_data_manager_impl_private.cc']
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.(cc|cpp|cxx|mm)$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:Running CheckChangeOnCommit done.

The "a matched b" lines are boring and numerous, so remove this log line.
If we ever need it to debug something, we can add it back then (temporarily).

(From https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/260304/steps/presubmit/logs/stdio)

BUG=none

Review-Url: https://codereview.chromium.org/2341103002
9 years ago
bootstrap win_tools.bat: call git_bootstrap.py, remove deprecated svn bootstrap 9 years ago
fetch_configs Revert "Remove all safesync_url functionality from gclient" 9 years ago
git-templates
infra Roll recipe dependencies (nontrivial). 9 years ago
man Docs: Fix git retry usage flag name. 9 years ago
recipe_modules Roll recipe dependencies (nontrivial). 9 years ago
support
testing_support Support additional user presubmit scripts named PRESUBMIT*.py. 9 years ago
tests Remove unused PATCH_TOOL and resulting dead code from bot_update. 9 years ago
third_party Remove --base_url from git cl and upload.py 9 years ago
win_toolchain Don't try svn.chromium.org for src-internal check 9 years ago
zsh-goodies
.gitignore
.style.yapf
LICENSE
OWNERS
PRESUBMIT.py
README.gclient.md Overhaul the README files a bit. 9 years ago
README.git-cl.md Proofread README.git-cl.md. 9 years ago
README.md Revert of Whitespace change to trigger cipd package for git installer. (patchset #1 id:1 of https://chromiumcodereview.appspot.com/2251883002/ ) 9 years ago
README.testing
WATCHLISTS
annotated_gclient.py
apply_issue
apply_issue.bat
apply_issue.py
auth.py
breakpad.py
buildbucket.py
cbuildbot
checkout.py
chrome_set_ver
cit
cit.bat
cit.py If cit is run with an unknown tool, print usage rather than throwing an exception 9 years ago
clang-format
clang-format.bat
clang_format.py
codereview.settings Delete gcl, drover, and trychange 9 years ago
commit_queue
commit_queue.bat
commit_queue.py
cpplint.bat
cpplint.py Run auto-spell-checker (codespell) on files in depot_tools. 9 years ago
cpplint_chromium.py
create-ntfs-junction.c
create-ntfs-junction.exe
cros
cros_sdk
dart_format.py
depot-tools-auth
depot-tools-auth.bat
depot-tools-auth.py
download_from_google_storage
download_from_google_storage.bat
download_from_google_storage.py
fetch
fetch.bat
fetch.py
fix_encoding.py Run auto-spell-checker (codespell) on files in depot_tools. 9 years ago
gclient
gclient-new-workdir.py
gclient.bat
gclient.py Propagate use_relative_paths into recursedeps 9 years ago
gclient_completion.sh
gclient_scm.py gclient: Prune dangling remote tracking refs when fetching with --force 9 years ago
gclient_utils.py bot_update/gclient: kill git fetch after timeout regardless of output. 9 years ago
gerrit_util.py Prompt to delete pending edits before changing the Gerrit CL description. 9 years ago
git-auto-svn
git-cache
git-cherry-pick-upload
git-cl
git-crrev-parse
git-crsync
git-drover
git-find-releases
git-footers
git-freeze
git-gs
git-hyper-blame
git-map
git-map-branches
git-mark-merge-base
git-nav-downstream
git-nav-upstream
git-new-branch
git-number
git-rebase-update
git-rename-branch
git-reparent-branch
git-retry
git-runhooks
git-squash-branch
git-thaw
git-upstream-diff
git_auto_svn.py
git_cache.py
git_cherry_pick_upload.py
git_cl.py git cl land to refs/pending: remove unused arg. 9 years ago
git_cl_completion.sh Add git cl bash completition. 9 years ago
git_common.py Run auto-spell-checker (codespell) on files in depot_tools. 9 years ago
git_dates.py
git_drover.py
git_find_releases.py
git_footers.py
git_freezer.py
git_hyper_blame.py
git_map.py
git_map_branches.py map-branches: Fix crash with --show-subject when branch name matches files 9 years ago
git_mark_merge_base.py
git_nav_downstream.py
git_new_branch.py
git_number.py
git_rebase_update.py
git_rename_branch.py
git_reparent_branch.py
git_retry.py
git_squash_branch.py
git_upstream_diff.py
gn
gn.bat
gn.py
gsutil.py
my_activity.py
my_reviews.py
ninja
ninja-linux32
ninja-linux64
ninja-mac
ninja.exe
owners.py Fix per-file owners check for deleted files. 9 years ago
owners_finder.py Fix per-file owners check for deleted files. 9 years ago
patch.py
presubmit_canned_checks.py Add more debugging in presubmit owners check for Gerrit. 9 years ago
presubmit_support.py presubmit_support: Remove a noisy logging.debug() 9 years ago
profile.xml
pylint
pylint.py
pylintrc
python_runner.sh
recipes.py upload recipe bootstrap script (6a4b2e4) 9 years ago
repo repo: update to v1.12.17-cr1 9 years ago
rietveld.py Implement git cl set-commit --dry-run for Rietveld. 9 years ago
roll-dep
roll-dep-svn Revert of Delete roll-dep-svn (patchset #1 id:1 of https://codereview.chromium.org/2282223002/ ) 9 years ago
roll-dep-svn.bat Revert of Delete roll-dep-svn (patchset #1 id:1 of https://codereview.chromium.org/2282223002/ ) 9 years ago
roll-dep.bat
roll_dep.py roll-dep: Show the git log for catapult 9 years ago
roll_dep_svn.py Revert of Delete roll-dep-svn (patchset #1 id:1 of https://codereview.chromium.org/2282223002/ ) 9 years ago
scm.py
setup_color.py
subcommand.py
subprocess2.py
update_depot_tools
update_depot_tools.bat
upload_to_google_storage.py Run auto-spell-checker (codespell) on files in depot_tools. 9 years ago
watchlists.py
weekly
wtf

README.md

depot_tools

This package contains tools for working with Chromium development. It requires python 2.7.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install svn (not for long), git, python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be commited.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

cpplint.py

To update cpplint.py, please submit the change upstream first at https://github.com/google/styleguide/tree/gh-pages/cpplint then copy it down.