You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
The finder.owners_queue contains a set of owners but they appear in an arbitrary order on each invocation of the test. The current method of assertEqual() with a list fails randomly because of the ordering being different. Example: https://ci.chromium.org/p/infra/builders/try/Depot%20Tools%20Presubmit%20(win)/b8897976148721436512 This changes comparisons of owners_queue to use an assertEqualSets() which does a comparison that is order-independent. Change-Id: Ia827795af283dadeb56f76ae0cf14fa4ad7e9eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1895699 Reviewed-by: Aaron Gable <agable@chromium.org> Reviewed-by: Garrett Beaty <gbeaty@chromium.org> Commit-Queue: danakj <danakj@chromium.org> |
6 years ago | |
---|---|---|
.. | ||
gstools | ||
OWNERS | ||
auth_test.py | 6 years ago | |
bot_update_coverage_test.py | 6 years ago | |
cipd_bootstrap_test.py | ||
download_from_google_storage_unittest.py | 6 years ago | |
fix_encoding_test.py | 6 years ago | |
gclient_eval_unittest.py | 6 years ago | |
gclient_scm_test.py | 6 years ago | |
gclient_smoketest.py | 6 years ago | |
gclient_test.py | 6 years ago | |
gclient_utils_test.py | 6 years ago | |
gerrit_util_test.py | 6 years ago | |
git_cache_test.py | 6 years ago | |
git_cl_creds_check_report.txt | ||
git_cl_test.py | 6 years ago | |
git_common_test.py | 6 years ago | |
git_dates_test.py | 6 years ago | |
git_drover_test.py | 6 years ago | |
git_footers_test.py | 6 years ago | |
git_hyper_blame_test.py | 6 years ago | |
git_number_test.py | 6 years ago | |
git_rebase_update_test.py | 6 years ago | |
gsutil_test.py | 6 years ago | |
metrics_test.py | 6 years ago | |
ninjalog_uploader_test.py | ||
owners_finder_test.py | 6 years ago | |
owners_unittest.py | 6 years ago | |
presubmit_unittest.py | 6 years ago | |
recipes_test.py | ||
roll_dep_test.py | ||
scm_unittest.py | 6 years ago | |
subprocess2_test.py | 6 years ago | |
upload_to_google_storage_unittest.py | 6 years ago | |
watchlists_unittest.py | 6 years ago |