You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
Jordan Brown a60883e901 metadata: Fix metadata validator error reporting
Validate errors should be returned as errors (as warnings are ignored), not warnings

Once the following CL's have been submitted there will be 0 presubmit errors or warnings.
* https://crrev.com/c/6284506
* https://crrev.com/c/6296486
* https://crrev.com/c/6290266
* https://crrev.com/c/6296606
* https://crrev.com/c/6297263
* https://crrev.com/c/6296425
* https://crrev.com/c/6290667
* https://crrev.com/c/6287813
* https://crrev.com/c/6289887
* https://crrev.com/c/6290124



Bug: 285453019
Change-Id: I3448435dcb0505722a2c68476ef9d752a6614533
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6296579
Reviewed-by: Rachael Newitt <renewitt@google.com>
Commit-Queue: Jordan Brown <rop@google.com>
Commit-Queue: Rachael Newitt <renewitt@google.com>
Auto-Submit: Jordan Brown <rop@google.com>
3 days ago
bootstrap [win-bootstrap] Update the comments in update_depot_tools.bat 3 weeks ago
fetch_configs Add webpagereplay fetch_config 4 months ago
hooks
infra Roll recipe dependencies (trivial). 1 week ago
infra_lib/telemetry Add telemetry initialization and opt out utility 5 months ago
man Update depot_tools documentation for squash-closed 1 week ago
metadata metadata: Fix metadata validator error reporting 3 days ago
python-bin
python2-bin
recipes Roll recipe dependencies (trivial). 1 week ago
testing_support Update CMDgitmodules to set `gclient-recursedeps` in .gitmodules file. 5 months ago
tests [git cl split]: Allow users to override reviewer assignment 3 days ago
third_party updating license id for colorama 1 week ago
win_toolchain Add timeout to git call in windows toolchain update script 4 months ago
zsh-goodies
.cipd_impl.ps1 [cipd] support proxy for .cipd_impl.ps1 3 months ago
.flake8
.git-blame-ignore-revs Reuse GIT_BLAME_IGNORE_REV_FILE variable 5 months ago
.gitattributes Establish a directory for chrome infra telemetry 6 months ago
.gitignore autoninja: check RBE project, not account 6 months ago
.isort.cfg
.style.yapf
.vpython3 autoninja: check RBE project, not account 6 months ago
BUILD_OWNERS
CROS_OWNERS
DIR_METADATA
LICENSE
LUCI_OWNERS
OWNERS Add myself as a depot_tools owner. 2 months ago
PRESUBMIT.py Revert "Add AffectedFile.Extension() in presubmit_support" 1 week ago
README.gclient.md
README.git-cl.md
README.md [win-bootstrap] Update docs for removal of git 1 month ago
RECLIENT_OWNERS
WATCHLISTS
android_build_server_helper.py android_build_server_helper.py: Do not start server when stdout is a pipe 1 week ago
auth.py [auth] Clarify what account to use 1 month ago
autoninja autoninja: check RBE project, not account 6 months ago
autoninja.bat autoninja: check RBE project, not account 6 months ago
autoninja.py autoninja: fix UnboundLocalError 2 weeks ago
bazel
bazel.py
bb
bb.bat
black
bootstrap_python3
breakpad.py
build_telemetry
build_telemetry.bat
build_telemetry.py build_telemetry: Do not print warning message for cipd auth-info error 6 months ago
cbuildbot
cipd cipd: allow overriding the location of where cipd binary is installed 6 months ago
cipd.bat
cipd_bin_setup.bat
cipd_bin_setup.sh
cipd_client_version [depot_tools] Roll CIPD. 6 months ago
cipd_client_version.digests [depot_tools] Roll CIPD. 6 months ago
cipd_manifest.txt [depot_tools] Roll led 1 week ago
cipd_manifest.versions [depot_tools] Roll led 1 week ago
cipd_manifest_cros_python2.txt
cipd_manifest_cros_python2.versions
clang-format
clang-format.bat
clang_format.py
codereview.settings
compile_single_file
compile_single_file.bat
compile_single_file.py
cpplint.bat
cpplint.py [cpplint] add stdin support in stdin 5 months ago
cpplint_chromium.py
cros cros: start pushing people to 3.11 2 months ago
cros_python2.vpython
cros_sdk
detect_host_arch.py
dirmd
dirmd.bat
download_from_google_storage
download_from_google_storage.bat
download_from_google_storage.py AIX: sys.platform always returns 'aix' instead of 'aix6' or 'aix7'. 1 month ago
ensure_bootstrap ensure_bootstrap: basic argument processing 2 months ago
fetch
fetch.bat
fetch.py
gclient
gclient-new-workdir.py
gclient.bat
gclient.py Skip writing gclient_args.gni if contents are unchanged to avoid causing rebuild 2 months ago
gclient_completion.sh
gclient_eval.py gclient_eval.py: Add "new_usages_require_review" to DEPS file schema 5 months ago
gclient_paths.py
gclient_scm.py [gclient] Handle auth setup for cached repos 1 month ago
gclient_utils.py Explicitly propagate terminal size to gclient hooks. 2 months ago
gerrit
gerrit_client.py gerrit: addmessage: support attention set control 1 month ago
gerrit_util.py [auth] Fix luci-auth reference in comment 1 month ago
git-cache
git-cl
git-credential-luci
git-credential-luci.bat
git-crrev-parse
git-drover
git-find-releases
git-footers
git-freeze
git-gs
git-hyper-blame
git-map
git-map-branches
git-mark-merge-base
git-nav-downstream
git-nav-upstream
git-new-branch
git-number
git-rebase-update
git-rename-branch
git-reparent-branch
git-retry
git-runhooks
git-squash-branch
git-squash-branch-tree
git-thaw
git-upstream-diff
git_auth.py [auth] Hide global SSO rewrite in local repo 1 month ago
git_cache.py
git_cl.py [git cl split]: Allow users to override reviewer assignment 3 days ago
git_cl_completion.sh
git_common.py Modify git squash-branch to perform reparenting 3 weeks ago
git_completion.sh
git_dates.py
git_find_releases.py
git_footers.py [git_footers] add support for multiline footers 3 months ago
git_freezer.py
git_hyper_blame.py Reuse GIT_BLAME_IGNORE_REV_FILE variable 5 months ago
git_map.py
git_map_branches.py
git_mark_merge_base.py
git_nav_downstream.py
git_new_branch.py Track origin/lkgr when using --lkgr flag in new-branch 5 months ago
git_number.py
git_rebase_update.py Colorize branch names for rebase-update 1 week ago
git_rename_branch.py
git_reparent_branch.py
git_retry.py
git_squash_branch.py Modify git squash-branch to perform reparenting 3 weeks ago
git_squash_branch_tree.py Modify git squash-branch to perform reparenting 3 weeks ago
git_upstream_diff.py
gn
gn.bat
gn.py
gn_helper.py gn_helper: handle absolute path import 4 weeks ago
google-java-format
google-java-format.bat
google_java_format.py
gsutil.py
gsutil.py.bat
gsutil.vpython3
isort
led
led.bat
lockfile.py
luci-auth
luci-auth.bat
lucicfg
lucicfg.bat
mac_toolchain
metrics-xml-format add metrics_xml_formatter 3 months ago
metrics.README.md [metrics] Add new auth metric 6 months ago
metrics.py [metrics] Add new auth metric 6 months ago
metrics_utils.py [metrics] Add new auth metric 6 months ago
metrics_xml_format.py metrics_xml_format: check the XML path against realpath 1 week ago
my_activity.py my_activity.py: Handle JSON parse errors 3 months ago
newauth.py
ninja
ninja.bat
ninja.py ninja: Improve depot_tools directory detection 2 weeks ago
ninjalog_uploader.py ninjalog_uploader: Send is_cloudtop=false explicitly 5 months ago
owners_client.py
owners_finder.py
pinpoint
pinpoint.bat
post_build_ninja_summary.py post_build_ninja_summary: run siso.py instead of siso command 3 weeks ago
presubmit_canned_checks.py [presubmit] Check if .gitmodules diverges from DEPS 4 weeks ago
presubmit_diff.py presubmit_diff: add support for -U 1 month ago
presubmit_support.py Revert "Add AffectedFile.Extension() in presubmit_support" 1 week ago
prpc
prpc.bat
pylint-2.6
pylint-2.6.bat
pylint-2.7
pylint-2.7.bat
pylint-2.17
pylint-2.17.bat
pylint-3.2 pylint: add v3.2 support 2 months ago
pylint-3.2.bat pylint: add v3.2 support 2 months ago
pylint_main.py pylint: support versioned pylintrc files 2 months ago
pylintrc-2.6 pylintrc: version all of them 2 months ago
pylintrc-2.7 pylintrc: version all of them 2 months ago
pylintrc-2.17 pylintrc: version all of them 2 months ago
pylintrc-3.2 pylint: add v3.2 support 2 months ago
python_runner.sh
rdb
rdb.bat
rdb_wrapper.py
reclient_helper.py Revert "reclient_helper: tuning local execution parameter" 3 months ago
reclientreport
reclientreport.bat
reclientreport.py
repo
repo_launcher [repo] Update repo launcher to v2.50 2 months ago
roll-dep
roll-dep.bat
roll_dep.py
roll_downstream_gcs_deps.py Update roll_downstream_gcs_deps to take a list of source and destination packages. 5 months ago
rustfmt.py
scm.py [scm] Handle empty .gitmodules file 5 months ago
setup_color.py
siso
siso.bat
siso.py Integrate autoninja.py with fast_local_dev_server.py 3 months ago
split_cl.py [git cl split]: Allow users to override reviewer assignment 3 days ago
subcommand.py
subprocess2.py
swift-format
swift_format.py
update_depot_tools Remove check for canonical depot_tools URL 1 month ago
update_depot_tools.bat [win-bootstrap] Update the comments in update_depot_tools.bat 3 weeks ago
update_depot_tools_toggle.py
upload_metrics.py
upload_to_google_storage.py upload_to_google_storage.py: set x-goog-meta-executable during upload instead of using setmeta 4 months ago
upload_to_google_storage_first_class.py
utils.py
vpython3 Don't write pyc files if running from Cog 6 months ago
vpython3.bat
watchlists.py
whitespace.txt
win32imports.py
yapf
yapf.bat

README.md

depot_tools

Tools for working with Chromium development. It requires python 3.8.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or run ./update_depot_tools_toggle.py --disable.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.