You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
Jordan Brown 9fbf88b06f Presubmit error for bad delimiters
This change introduces a new error for license fields that use any of
the following `["/", ";", " and ", " or "]`.

I chose to include the offending character/s in the error message
because I find it easier to parse error messages that tell me exactly
which character is the bad one. Similarly I've included conditions in
the reason to handle the plural cases correctly, generating either:

`License contains a bad delimiter character ...`, or
`License contains bad delimiter characters ...`

I realise this means that any downstream rules looking to detect this
error will need to check for a common subset, e.g 'bad delimiter
character', however I think it's worth it for the improved user
experience of receiving the error.

I've also anticipated that most of these errors will be due to
situations where multiple licenses are offered, and included additional
text explaining that only the most permissive of the choices should be
included.

This will affect 9 dependencies and they need to choose between multiple licenses anyway so it's okay to generate an error and have partybug file bugs.

Bug: http://b/374850412
Change-Id: I6eb53a8a3bd541a1801dff133884b719dcdfe04d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6181848
Reviewed-by: Jiewei Qian <qjw@chromium.org>
Reviewed-by: Rachael Newitt <renewitt@google.com>
Commit-Queue: Jordan Brown <rop@google.com>
6 months ago
bootstrap [win-bootstrap] Never add docs to Git 6 months ago
fetch_configs
hooks
infra Roll recipe dependencies (trivial). 6 months ago
infra_lib/telemetry
man
metadata Presubmit error for bad delimiters 6 months ago
python-bin
python2-bin
recipes Roll recipe dependencies (trivial). 6 months ago
testing_support
tests presubmit_diff: add support for -U 6 months ago
third_party [depot_tools] annotate third_party/colorama as non security critical 10 months ago
win_toolchain
zsh-goodies
.cipd_impl.ps1
.flake8
.git-blame-ignore-revs
.gitattributes
.gitignore
.isort.cfg
.style.yapf
.vpython3
BUILD_OWNERS
CROS_OWNERS
DIR_METADATA
LICENSE
LUCI_OWNERS
OWNERS Add myself as a depot_tools owner. 6 months ago
PRESUBMIT.py
README.gclient.md
README.git-cl.md
README.md
RECLIENT_OWNERS
WATCHLISTS
android_build_server_helper.py
auth.py
autoninja
autoninja.bat
autoninja.py autoninja: run ninjalog_uploader in new session 6 months ago
bazel
bazel.py
bb
bb.bat
black
bootstrap_python3
breakpad.py
build_telemetry
build_telemetry.bat
build_telemetry.py
cbuildbot
cipd
cipd.bat
cipd_bin_setup.bat
cipd_bin_setup.sh
cipd_client_version
cipd_client_version.digests
cipd_manifest.txt Roll vpython3 to include python 3.11.9.chromium.36. 6 months ago
cipd_manifest.versions Roll vpython3 to include python 3.11.9.chromium.36. 6 months ago
cipd_manifest_cros_python2.txt
cipd_manifest_cros_python2.versions
clang-format
clang-format.bat
clang_format.py
codereview.settings
compile_single_file
compile_single_file.bat
compile_single_file.py
cpplint.bat
cpplint.py
cpplint_chromium.py
cros
cros_python2.vpython
cros_sdk
detect_host_arch.py
dirmd
dirmd.bat
download_from_google_storage
download_from_google_storage.bat
download_from_google_storage.py
ensure_bootstrap
fetch
fetch.bat
fetch.py
gclient
gclient-new-workdir.py
gclient.bat
gclient.py
gclient_completion.sh
gclient_eval.py
gclient_paths.py
gclient_scm.py [gclient] Handle auth setup for cached repos 6 months ago
gclient_utils.py
gerrit
gerrit_client.py gerrit: addmessage: support attention set control 6 months ago
gerrit_util.py gerrit: addmessage: support attention set control 6 months ago
git-cache
git-cl
git-credential-luci
git-credential-luci.bat
git-crrev-parse
git-drover
git-find-releases
git-footers
git-freeze Add quotes around paths in bash scripts 5 years ago
git-gs
git-hyper-blame
git-map
git-map-branches
git-mark-merge-base
git-nav-downstream
git-nav-upstream
git-new-branch
git-number
git-rebase-update
git-rename-branch
git-reparent-branch
git-retry
git-runhooks
git-squash-branch
git-squash-branch-tree
git-thaw
git-upstream-diff
git_auth.py
git_cache.py
git_cl.py Remove unnecessary RunHook call for squash mode. 6 months ago
git_cl_completion.sh
git_common.py Prefer direct git installation for Windows 8 months ago
git_completion.sh
git_dates.py
git_find_releases.py
git_footers.py [git_footers] add support for multiline footers 8 months ago
git_freezer.py
git_hyper_blame.py
git_map.py
git_map_branches.py
git_mark_merge_base.py
git_nav_downstream.py
git_new_branch.py
git_number.py
git_rebase_update.py
git_rename_branch.py
git_reparent_branch.py
git_retry.py
git_squash_branch.py
git_squash_branch_tree.py
git_upstream_diff.py fail gracefully if git upstream-diff is called in cog 1 year ago
gn
gn.bat
gn.py
gn_helper.py
google-java-format
google-java-format.bat
google_java_format.py
gsutil.py
gsutil.py.bat
gsutil.vpython3
isort
led
led.bat
lockfile.py
luci-auth
luci-auth.bat
lucicfg
lucicfg.bat
mac_toolchain
metrics-xml-format
metrics.README.md
metrics.py
metrics_utils.py
metrics_xml_format.py
my_activity.py
newauth.py
ninja
ninja.bat
ninja.py
ninjalog_uploader.py
owners_client.py
owners_finder.py
pinpoint
pinpoint.bat
post_build_ninja_summary.py
presubmit_canned_checks.py Add `is_open_source_project` to metadata validation 6 months ago
presubmit_diff.py presubmit_diff: add support for -U 6 months ago
presubmit_support.py
prpc provide a way to override cipd root for *nix systems. 12 months ago
prpc.bat
pylint-2.6
pylint-2.6.bat
pylint-2.7
pylint-2.7.bat
pylint-2.17
pylint-2.17.bat
pylint-3.2
pylint-3.2.bat
pylint_main.py
pylintrc-2.6
pylintrc-2.7
pylintrc-2.17
pylintrc-3.2
python_runner.sh [py2] Drop envvar to run scripts with py2 2 years ago
rdb
rdb.bat
rdb_wrapper.py
reclient_helper.py
reclientreport
reclientreport.bat
reclientreport.py
repo
repo_launcher
roll-dep
roll-dep.bat
roll_dep.py
roll_downstream_gcs_deps.py
rustfmt.py
scm.py
setup_color.py
siso
siso.bat
siso.py
split_cl.py Fix argument mismatch in split_cl.py 6 months ago
subcommand.py Fix multiline comment formatting 2 years ago
subprocess2.py
swift-format
swift_format.py
update_depot_tools
update_depot_tools.bat
update_depot_tools_toggle.py
upload_metrics.py
upload_to_google_storage.py
upload_to_google_storage_first_class.py
utils.py
vpython3
vpython3.bat
watchlists.py
whitespace.txt
win32imports.py
yapf
yapf.bat

README.md

depot_tools

Tools for working with Chromium development. It requires python 3.8.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or run ./update_depot_tools_toggle.py --disable.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.