You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
d81e5f52fc
crrev.com/c/6049353 updated bot_update.ensure_checkout to comput the output commit even when not setting the output commit so that callers could do custom logic for setting output commits while still having access to the one computed by bot_update. Unfortunately, this changed behavior for some builds that have set_output_commit set false. When computing the output commit, if none of the conditions that set the ref on the output commit were true then an AssertionError would be raised indicating that the caller should call buildbucket.set_output_gitiles_commit. With crrev.com/c/6049353, the assertion can be raised even if set_output_commit is false. This changes it so that the constraint on the ref field is only enforced when set_output_commit is true. Bug: 366409421 Change-Id: Ifb3a39784d75a3c47a7d4a6e2ac9957c29a09938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6064719 Auto-Submit: Garrett Beaty <gbeaty@google.com> Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Yiwei Zhang <yiwzhang@google.com> |
9 months ago | |
|---|---|---|
| .. | ||
| examples | ||
| resources | ||
| tests | 9 months ago | |
| __init__.py | ||
| api.py | 9 months ago | |
| test_api.py | ||