You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
Aleksey Khoroshilov 544594e0b2 Reland "Make depot_tools scripts return exit codes properly on all platforms."
This reverts commit 6754c49e02.

Reason for revert: will be relanded with fixed batch comments that triggered parser error.

Original change's description:
> Revert "Make depot_tools scripts return exit codes properly on all platforms."
>
> This reverts commit 7c4f7ec408.
>
> Reason for revert: bugs reported by users (see comments in Gerrit).
> error: block. was unexpected at this time.
>
> Original change's description:
> > Make depot_tools scripts return exit codes properly on all platforms.
> >
> > Changes:
> > 1. Windows: exit /b %errorlevel% should be used instead of goto :EOF to get valid exit codes during cmd /c <script>.bat invocation.
> > 2. Windows: delayed var expansion is required in update_depot_tools.bat exit code generation.
> > 3. Posix: update_depot_tools returns exit code from update_git_repo function in case of a failure.
> >
> > A rule of thumb on Windows: goto :EOF should not be used if %errorlevel% must be returned for all possible invocations.
> >
> > Test case for update_depot_tools changes:
> > 1. Make a change to depot_tools sources that will conflict with next depot_tools update
> > 2. Run update_depot_tools either directly or via gclient
> > 3. Expect a git error is triggered
> > 4. Inspect %errorlevel% or $? depending on platform
> > 5. Expected 1, but the actual result is 0.
> >
> > Test case for changes in other .bat files:
> > 1. Make a change to depot_tools sources that will conflict with next depot_tools update
> > 2. Run cmd /c gclient
> > 3. Expect a git error is triggered
> > 4. Inspect %errorlevel%
> > 5. Expected 1, but the actual result is 0.
> >
> > Change-Id: I64459982bcd9cc3db1319a9b39224b7a7af8c5aa
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3688632
> > Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> > Commit-Queue: Josip Sokcevic <sokcevic@google.com>
> > Auto-Submit: Aleksey Khoroshilov <akhoroshilov@brave.com>
> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
>
> Change-Id: I85d598af01d75588cdee77165d6af22270ee031d
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3694139
> Auto-Submit: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

Change-Id: I377f966ea1b1a567de815caca703b5e124a76b64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3696396
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Aleksey Khoroshilov <akhoroshilov@brave.com>
3 years ago
bootstrap
fetch_configs [depot_tools] Remove references to adobe flash from fetch flow 3 years ago
git-templates
infra Roll recipe dependencies (trivial). 3 years ago
man
python-bin
python2-bin
recipes Roll recipe dependencies (trivial). 3 years ago
testing_support
tests Remove duplicate sparse-checkout call. 3 years ago
third_party
win_toolchain Use python3 for cpplint and get_toolchain on Win 3 years ago
zsh-goodies
.cipd_impl.ps1
.gitattributes Add .cipd_impl.ps1 to recipe bundle 3 years ago
.gitignore Report when vpython (Python 2) is run during presubmits 3 years ago
.isort.cfg
.style.yapf
.vpython
.vpython3
CROS_OWNERS
DIR_METADATA
GOMA_OWNERS
LICENSE
LUCI_OWNERS
OWNERS Revert "Add iannucci to depot_tools owners" 3 years ago
PRESUBMIT.py
README.gclient.md
README.git-cl.md
README.md
WATCHLISTS
auth.py
autoninja
autoninja.bat
autoninja.py
bb
bb.bat
black
bootstrap_python3
breakpad.py
cbuildbot
cipd Add riscv64 architecture detection 3 years ago
cipd.bat
cipd_bin_setup.bat Revert "Switch to use CIPD ninja v1.8.2" 3 years ago
cipd_bin_setup.sh
cipd_client_version Bump cipd to 2.6.5 3 years ago
cipd_client_version.digests Bump cipd to 2.6.5 3 years ago
cipd_manifest.txt Roll PGO CLI changes into depot_tools 3 years ago
cipd_manifest.versions Roll PGO CLI changes into depot_tools 3 years ago
cit
cit.bat
cit.py
clang-format
clang-format.bat
clang_format.py
clang_format_merge_driver
clang_format_merge_driver.bat
clang_format_merge_driver.py
codereview.settings
compile_single_file
compile_single_file.bat
compile_single_file.py
cpplint.bat Use python3 for cpplint and get_toolchain on Win 3 years ago
cpplint.py Tag cpplint errors 3 years ago
cpplint_chromium.py
cros
cros_sdk
crosjobs
detect_host_arch.py Add riscv64 architecture detection 3 years ago
dirmd
dirmd.bat
download_from_google_storage
download_from_google_storage.bat use python3 for download_from_google_storage.bat 3 years ago
download_from_google_storage.py Skip 'ls' when downloading from gs. 3 years ago
ensure_bootstrap
fetch
fetch.bat Reland "Make depot_tools scripts return exit codes properly on all platforms." 3 years ago
fetch.py Default fetch to sso:// within cog 3 years ago
fix_encoding.py
gclient
gclient-new-workdir.py
gclient.bat Reland "Make depot_tools scripts return exit codes properly on all platforms." 3 years ago
gclient.py Reland "Update fetch protocol using --protocol-override flag" 3 years ago
gclient_completion.sh
gclient_eval.py
gclient_paths.py
gclient_scm.py Remove duplicate sparse-checkout call. 3 years ago
gclient_utils.py Update gclient cloning to work with cog. 3 years ago
gerrit_client.py
gerrit_util.py [gerrit] Add more gerrit API wrappers 3 years ago
git-cache
git-cl
git-crrev-parse
git-drover
git-find-releases
git-footers
git-freeze
git-gs
git-hyper-blame
git-map
git-map-branches
git-mark-merge-base
git-migrate-default-branch
git-nav-downstream
git-nav-upstream
git-new-branch
git-number
git-rebase-update
git-rename-branch
git-reparent-branch
git-retry
git-runhooks
git-squash-branch
git-thaw
git-upstream-diff
git_cache.py Use remote information about default branch 3 years ago
git_cl.py Run presubmit checks without GerritAccessor if GERRIT_HOST is not set. 3 years ago
git_cl_completion.sh
git_common.py
git_dates.py
git_drover.py
git_find_releases.py
git_footers.py
git_freezer.py
git_hyper_blame.py
git_map.py
git_map_branches.py
git_mark_merge_base.py
git_migrate_default_branch.py
git_nav_downstream.py
git_new_branch.py
git_number.py
git_rebase_update.py
git_rename_branch.py
git_reparent_branch.py
git_retry.py
git_squash_branch.py
git_upstream_diff.py
gn
gn.bat
gn.py
goma_auth
goma_auth.bat
goma_ctl
goma_ctl.bat
gsutil.py
gsutil.py.bat Reland "Make depot_tools scripts return exit codes properly on all platforms." 3 years ago
gsutil.vpython3
isort
led
led.bat
lockfile.py
luci-auth
luci-auth.bat
lucicfg
lucicfg.bat
mac_toolchain
metrics.README.md
metrics.py
metrics_utils.py
my_activity.py
ninja Revert "Switch to use CIPD ninja v1.8.2" 3 years ago
ninja-linux64 Revert "Switch to use CIPD ninja v1.8.2" 3 years ago
ninja-mac Revert "Switch to use CIPD ninja v1.8.2" 3 years ago
ninja.exe Revert "Switch to use CIPD ninja v1.8.2" 3 years ago
ninjalog.README.md
ninjalog_uploader.py
ninjalog_uploader_wrapper.py Typo when countdown is more than 1. 3 years ago
owners.py
owners_client.py
owners_finder.py
pinpoint
pinpoint.bat
post_build_ninja_summary.py
presubmit_canned_checks.py Make tree-closed a warning for presubmit --all 3 years ago
presubmit_canned_checks_test.py
presubmit_canned_checks_test_mocks.py
presubmit_support.py Report when vpython (Python 2) is run during presubmits 3 years ago
profile.xml
prpc
prpc.bat
pylint
pylint-1.5
pylint-1.5.bat
pylint-2.6
pylint-2.6.bat
pylint-2.7
pylint-2.7.bat
pylint.bat
pylint_main.py
pylintrc
python_runner.sh
rdb
rdb.bat
rdb_wrapper.py
repo
repo_launcher
roll-dep
roll-dep.bat
roll_dep.py
rustfmt.py
scm.py
setup_color.py
split_cl.py
subcommand.py
subprocess2.py
swift-format
swift_format.py
update_depot_tools Reland "Make depot_tools scripts return exit codes properly on all platforms." 3 years ago
update_depot_tools.bat Reland "Make depot_tools scripts return exit codes properly on all platforms." 3 years ago
update_depot_tools_toggle.py
upload_metrics.py Catch RemoteDisconnected on upload metrics 3 years ago
upload_to_google_storage.py
utils.py
vpython Report when vpython (Python 2) is run during presubmits 3 years ago
vpython.bat Report when vpython (Python 2) is run during presubmits 3 years ago
vpython3
vpython3.bat
watchlists.py
weekly
whitespace.txt
win32imports.py
wtf
yapf
yapf.bat

README.md

depot_tools

Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or run ./update_depot_tools_toggle.py --disable.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.