You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
Gavin Mak 32769fe939 Revert "Deprecate --bypass-watchlists flag"
This reverts commit e98e458a9f.

Reason for revert: keep depot_tools CCing watchers while b/324466185 is open

Original change's description:
> Deprecate --bypass-watchlists flag
>
> CCing watchers is now handled by the Watchlists AyeAye analyzer on
> all Gerrit projects that use it, and not CCing watchers locally has
> no effect. Rely on that instead of logic in git cl.
>
> Bug: 41494851, 40242793
> Change-Id: I58fdf8c0a741a9189cccec3b3b56d0a8a1c44058
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5276660
> Reviewed-by: Scott Lee <ddoman@chromium.org>
> Commit-Queue: Gavin Mak <gavinmak@google.com>

Bug: 41494851, 40242793
Change-Id: Ied75beb163b2628343d4dcac5819b5bd77854de8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5281700
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Gavin Mak <gavinmak@google.com>
1 year ago
bootstrap Reland^3 "Upgrade python to 3.11" 1 year ago
fetch_configs Add fetch config node 1 year ago
hooks pre-commit: do not ignore submodule when running diff-index 1 year ago
infra Roll recipe dependencies (trivial). 1 year ago
man Switch to using issues.chromium.org bug links 1 year ago
metadata [ssci] Add condition on license field separator warning 1 year ago
python-bin cipd/python: optimize cat usage 2 years ago
python2-bin cipd/python: optimize cat usage 2 years ago
recipes Trigger recipe roller 1 year ago
testing_support Fix multiline comment formatting 1 year ago
tests Revert "Deprecate --bypass-watchlists flag" 1 year ago
third_party schema: pull LICENSE whitespace trim from upstream 1 year ago
win_toolchain Delete py2 checks 1 year ago
zsh-goodies
.cipd_impl.ps1 Import Get-FileHash from PowerShell's version specific path 2 years ago
.flake8 Add a config file for the flake8 linter. 1 year ago
.gitattributes Define main metadata validation functions 2 years ago
.gitignore autoninja: cache negative result of gcloud account check 1 year ago
.isort.cfg isort: make available to users 3 years ago
.style.yapf switch to 4 space indent 2 years ago
.vpython Revert "Delete vpython, leaving only vpython3." 1 year ago
.vpython3 Update the CheckInfraFreeze canned check to use datetime & zoneinfo. 1 year ago
BUILD_OWNERS add siso wrapper 2 years ago
CROS_OWNERS CROS_OWNERS: switch to our common shared lists 3 years ago
DIR_METADATA
LICENSE
LUCI_OWNERS add peep-software-deploy team to luci owners 2 years ago
OWNERS Refactor the depot_tools OWNERS file. 1 year ago
PRESUBMIT.py [PRESUBMIT] Increase unit test timeout 1 year ago
README.gclient.md
README.git-cl.md
README.md Switch to using issues.chromium.org bug links 1 year ago
RECLIENT_OWNERS Add convenience wrapper for reclientreport for autoninja users 2 years ago
WATCHLISTS Update WATCHLISTS for ninja, siso and reclient changes 2 years ago
auth.py Fix multiline comment formatting 1 year ago
autoninja Revert^2 "autoninja.py: disallow external account from corp machine" 1 year ago
autoninja.bat Revert^2 "autoninja.py: disallow external account from corp machine" 1 year ago
autoninja.py Update goma deprecation message and add delay to build start for goma. 1 year ago
autosiso Deprecate autosiso.bat and autosiso. 1 year ago
autosiso.bat Deprecate autosiso.bat and autosiso. 1 year ago
autosiso.py [siso] Propagte SIGINT to siso process 1 year ago
bazel [ChromiumOS] Add a launcher for Bazel 2 years ago
bazel.py switch to 4 space indent 2 years ago
bb Add revert instructions 4 years ago
bb.bat Add revert instructions 4 years ago
black black: add helper for formatting Python 3 years ago
bootstrap_python3 Use relative path for cipd 2 years ago
breakpad.py switch to 4 space indent 2 years ago
cbuildbot
cipd Revert "[cipd] Detect Mac ARM running under Rosetta" 2 years ago
cipd.bat [cipd] Run cipd_impl.ps1 in constrained language mode 2 years ago
cipd_bin_setup.bat Revert "Retry switching to use CIPD ninja v1.8.2" 3 years ago
cipd_bin_setup.sh cipd_bin_setup: load cipd script instead of running it 2 years ago
cipd_client_version Update to 2.6.16 1 year ago
cipd_client_version.digests Update to 2.6.16 1 year ago
cipd_manifest.txt Bump vpython to pick up python 3.11.8 update. 1 year ago
cipd_manifest.versions Bump vpython to pick up python 3.11.8 update. 1 year ago
cipd_manifest_cros_python2.txt Redirect cros calls to py2.7 scripts to the vpython2.7 package. 2 years ago
cipd_manifest_cros_python2.versions Redirect cros calls to py2.7 scripts to the vpython2.7 package. 2 years ago
clang-format Use py3 for remaining tools in depot_tools path 4 years ago
clang-format.bat Use py3 for remaining tools in depot_tools path 4 years ago
clang_format.py Remove __future__ imports 1 year ago
codereview.settings
compile_single_file Make 'compile_single_file' use vpython3 1 year ago
compile_single_file.bat Make 'compile_single_file' use vpython3 1 year ago
compile_single_file.py Make 'compile_single_file' use vpython3 1 year ago
cpplint.bat Use python3 for cpplint and get_toolchain on Win 3 years ago
cpplint.py Remove deprecated sre_compile from cpplint 1 year ago
cpplint_chromium.py switch to 4 space indent 2 years ago
cros cros: expand to cover more roots 1 year ago
cros_python2.vpython Redirect cros calls to py2.7 scripts to the vpython2.7 package. 2 years ago
cros_sdk
crosjobs Add revert instructions 4 years ago
detect_host_arch.py Fix multiline comment formatting 1 year ago
dirmd Add revert instructions 4 years ago
dirmd.bat Add revert instructions 4 years ago
download_from_google_storage Switch download_from_google_storage to py3 4 years ago
download_from_google_storage.bat use python3 for download_from_google_storage.bat 3 years ago
download_from_google_storage.py Fix multiline comment formatting 1 year ago
ensure_bootstrap setup & share path to depot_tools checkout 2 years ago
fetch [py2] Drop envvar to run scripts with py2 2 years ago
fetch.bat [py2] Drop envvar to run scripts with py2 2 years ago
fetch.py Use shlex instead of pipes 1 year ago
gclient [py2] Drop envvar to run scripts with py2 2 years ago
gclient-new-workdir.py switch to 4 space indent 2 years ago
gclient.bat [py2] Drop envvar to run scripts with py2 2 years ago
gclient.py [fix_encoding] Remove fix_encoding 1 year ago
gclient_completion.sh
gclient_eval.py Fix multiline comment formatting 1 year ago
gclient_paths.py Cache values in gclient_paths.py 1 year ago
gclient_scm.py Revert "Update gclient to use git config caching" 1 year ago
gclient_utils.py Use shlex instead of pipes 1 year ago
gerrit Symlink gerrit CLI into depot_tools 2 years ago
gerrit_client.py [fix_encoding] Remove fix_encoding 1 year ago
gerrit_util.py Revert "Update gclient to use git config caching" 1 year ago
git-cache
git-cl
git-crrev-parse Fix git-crrev-parse to work with both master & main branches 3 years ago
git-drover
git-find-releases
git-footers
git-freeze
git-gs Enable searching starlark files with git gs. 1 year ago
git-hyper-blame
git-map
git-map-branches
git-mark-merge-base
git-migrate-default-branch
git-nav-downstream
git-nav-upstream
git-new-branch
git-number
git-rebase-update
git-rename-branch
git-reparent-branch
git-retry
git-runhooks Revert "Remove unused functionality in bot_update.py" 3 years ago
git-squash-branch
git-thaw
git-upstream-diff
git_cache.py [git_cache] Allow expansion of `~` in git cache.cachepath parameter. 1 year ago
git_cl.py Revert "Deprecate --bypass-watchlists flag" 1 year ago
git_cl_completion.sh
git_common.py Revert "Update gclient to use git config caching" 1 year ago
git_completion.sh Bash autocompletion for 'git new-branch' and 'git reparent-branch' 1 year ago
git_dates.py Fix multiline comment formatting 1 year ago
git_find_releases.py switch to 4 space indent 2 years ago
git_footers.py Fix multiline comment formatting 1 year ago
git_freezer.py switch to 4 space indent 2 years ago
git_hyper_blame.py Fix multiline comment formatting 1 year ago
git_map.py switch to 4 space indent 2 years ago
git_map_branches.py Fix multiline comment formatting 1 year ago
git_mark_merge_base.py switch to 4 space indent 2 years ago
git_migrate_default_branch.py [fix_encoding] Remove fix_encoding 1 year ago
git_nav_downstream.py switch to 4 space indent 2 years ago
git_new_branch.py switch to 4 space indent 2 years ago
git_number.py Fix multiline comment formatting 1 year ago
git_rebase_update.py Revert "Update gclient to use git config caching" 1 year ago
git_rename_branch.py switch to 4 space indent 2 years ago
git_reparent_branch.py switch to 4 space indent 2 years ago
git_retry.py Fix multiline comment formatting 1 year ago
git_squash_branch.py switch to 4 space indent 2 years ago
git_upstream_diff.py switch to 4 space indent 2 years ago
gn gn: Call gn.bat in msysgit on Windows. 4 years ago
gn.bat Revert "Call python3.bat explicitly from gn.bat on Windows." 3 years ago
gn.py Revert "Delete vpython, leaving only vpython3." 1 year ago
goma_auth Reland "Reland "use python3 for goma related scripts"" 4 years ago
goma_auth.bat Set errorlevel in .bat wrappers on exit /b where appropriate. 3 years ago
goma_ctl Skip goma on unsupported platforms 2 years ago
goma_ctl.bat Handle goma_ctl/autoninja /? 2 years ago
gsutil.py [gsutil.py] Skip luci-auth wrapper on unsupported platforms 1 year ago
gsutil.py.bat Reland "Make depot_tools scripts return exit codes properly on all platforms." 3 years ago
gsutil.vpython3 Reland "Update gsutil to use gsutil version 4.68" 3 years ago
infra_to_superproject Use shutil.copytree instead for migration script instead. 2 years ago
infra_to_superproject.bat Use shutil.copytree instead for migration script instead. 2 years ago
infra_to_superproject.py switch to 4 space indent 2 years ago
isort switch to 4 space indent 2 years ago
led Add revert instructions 4 years ago
led.bat Add revert instructions 4 years ago
lockfile.py Fix multiline comment formatting 1 year ago
luci-auth Add revert instructions 4 years ago
luci-auth.bat Add revert instructions 4 years ago
lucicfg Add revert instructions 4 years ago
lucicfg.bat Add revert instructions 4 years ago
mac_toolchain
metrics.README.md
metrics.py Clean up stacked-changes dogfood 1 year ago
metrics_utils.py Fix multiline comment formatting 1 year ago
my_activity.py [fix_encoding] Remove fix_encoding 1 year ago
ninja Revert "Use depot_tools python3 to call ninja.py" 2 years ago
ninja.bat Add single file compile support for Windows in ninja wrappers 2 years ago
ninja.py apply black and `git cl format` for ninja related python files 1 year ago
ninja_reclient.py apply black and `git cl format` for ninja related python files 1 year ago
ninjalog.README.md ninjalog_uploader: use goma_auth to detect googler 3 years ago
ninjalog_uploader.py ninjalog_uploader.py: use cipd to check authenticated account 1 year ago
ninjalog_uploader_wrapper.py apply black and `git cl format` for ninja related python files 1 year ago
owners_client.py [owners] Limit number of concurrent Gerrit connections 1 year ago
owners_finder.py Remove __future__ imports 1 year ago
pinpoint Add revert instructions 4 years ago
pinpoint.bat Add revert instructions 4 years ago
post_build_ninja_summary.py check `siso summary` 1 year ago
presubmit_canned_checks.py Make CheckForCommitObjects check gitlinks and .gitmodules 1 year ago
presubmit_support.py Revert "Reland "Refactor git functionality out of Change and _DiffCache"" 1 year ago
profile.xml
prpc Add revert instructions 4 years ago
prpc.bat Add revert instructions 4 years ago
pylint-2.6 switch to 4 space indent 2 years ago
pylint-2.6.bat Get pylint-2.6 to work under vpython3 on Windows. 4 years ago
pylint-2.7 switch to 4 space indent 2 years ago
pylint-2.7.bat Add pylint-2.7 3 years ago
pylint-2.17 pylint: Add pylint 2.17 1 year ago
pylint-2.17.bat pylint: Add pylint 2.17 1 year ago
pylint_main.py Remove __future__ imports 1 year ago
pylintrc
pylintrc-2.17 pylint: Add pylint 2.17 1 year ago
python_runner.sh [py2] Drop envvar to run scripts with py2 2 years ago
rdb Add revert instructions 4 years ago
rdb.bat Add revert instructions 4 years ago
rdb_wrapper.py Fix multiline comment formatting 1 year ago
reclient_helper.py Changing location of temp racing directory. 1 year ago
reclient_metrics Add reclient_metrics command 2 years ago
reclient_metrics.README.md [reclient] Update reclient_metrics.README.md to reflect that we collect googler hostnames 2 years ago
reclient_metrics.bat Add reclient_metrics command 2 years ago
reclient_metrics.py Fix multiline comment formatting 1 year ago
reclientreport Add convenience wrapper for reclientreport for autoninja users 2 years ago
reclientreport.bat Remove unnesisary quotes from propagated args in reclientreport.bat 2 years ago
reclientreport.py [reclient] Keep previous 5 builds worth of logs 1 year ago
repo switch to 4 space indent 2 years ago
repo_launcher Update repo_launcher to 2.40 1 year ago
roll-dep [py2] Drop envvar to run scripts with py2 2 years ago
roll-dep.bat [py2] Drop envvar to run scripts with py2 2 years ago
roll_dep.py Fix multiline comment formatting 1 year ago
rustfmt.py switch to 4 space indent 2 years ago
scm.py [scm] Fix _load_config to support multi-line 1 year ago
setup_color.py Fix multiline comment formatting 1 year ago
siso add siso wrapper 2 years ago
siso.bat add siso wrapper 2 years ago
siso.py siso: use stderr to print message from siso.py 1 year ago
split_cl.py Improve git cl split warning if more than 10 CLs will be created. 1 year ago
subcommand.py Fix multiline comment formatting 1 year ago
subprocess2.py Fix multiline comment formatting 1 year ago
swift-format Support git cl formatting for swift files 3 years ago
swift_format.py switch to 4 space indent 2 years ago
update_depot_tools Don't print "Updating depot_tools" 1 year ago
update_depot_tools.bat Call goma_ctl update_hook only after python3 is bootstrapped. 2 years ago
update_depot_tools_toggle.py switch to 4 space indent 2 years ago
upload_metrics.py switch to 4 space indent 2 years ago
upload_to_google_storage.py Remove __future__ imports 1 year ago
utils.py switch to 4 space indent 2 years ago
vpython Revert "Delete vpython, leaving only vpython3." 1 year ago
vpython.bat Revert "Delete vpython, leaving only vpython3." 1 year ago
vpython3 vpython: clear DEPOT_TOOLS_DIR before running scripts 2 years ago
vpython3.bat Use the bundled interpreter instead of passing -vpython-interpreter. 3 years ago
watchlists.py Fix multiline comment formatting 1 year ago
weekly Remove __future__ imports 1 year ago
whitespace.txt Change whitespace.txt 4 years ago
win32imports.py switch to 4 space indent 2 years ago
wtf Remove __future__ imports 1 year ago
yapf Always run yapf with vpython3. 1 year ago
yapf.bat

README.md

depot_tools

Tools for working with Chromium development. It requires python 3.8.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or run ./update_depot_tools_toggle.py --disable.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.