ninja.bat can't pass '^' for single file compile.
This change fixes ninja.bat to apply double quotas to args to preserve "^".
Note that ninja.bat still needs "^^" since single "^" is already removed as an escape character.
This is the same implementation with autoninja.{bat, py}.
Test: http://go/paste/6182226814304256
Bug: 1340825
Change-Id: I183c7890634a77471a617c4cc2b9c8c33bc8487d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4060603
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
|
3 years ago | |
|---|---|---|
| bootstrap | 3 years ago | |
| fetch_configs | 3 years ago | |
| git-templates | ||
| infra | 3 years ago | |
| man | 3 years ago | |
| python-bin | 5 years ago | |
| python2-bin | 5 years ago | |
| recipes | 3 years ago | |
| testing_support | 3 years ago | |
| tests | 3 years ago | |
| third_party | 3 years ago | |
| win_toolchain | 3 years ago | |
| zsh-goodies | ||
| .cipd_impl.ps1 | 5 years ago | |
| .gitattributes | 3 years ago | |
| .gitignore | 3 years ago | |
| .isort.cfg | 4 years ago | |
| .style.yapf | 6 years ago | |
| .vpython | 4 years ago | |
| .vpython3 | 4 years ago | |
| CROS_OWNERS | 3 years ago | |
| DIR_METADATA | 5 years ago | |
| GOMA_OWNERS | 4 years ago | |
| LICENSE | ||
| LUCI_OWNERS | 4 years ago | |
| OWNERS | 3 years ago | |
| PRESUBMIT.py | 3 years ago | |
| README.gclient.md | ||
| README.git-cl.md | 5 years ago | |
| README.md | 4 years ago | |
| WATCHLISTS | 4 years ago | |
| auth.py | 5 years ago | |
| autoninja | 4 years ago | |
| autoninja.bat | 3 years ago | |
| autoninja.py | 3 years ago | |
| bb | 5 years ago | |
| bb.bat | 5 years ago | |
| black | 4 years ago | |
| bootstrap_python3 | 5 years ago | |
| breakpad.py | ||
| cbuildbot | 6 years ago | |
| cipd | 3 years ago | |
| cipd.bat | 3 years ago | |
| cipd_bin_setup.bat | 3 years ago | |
| cipd_bin_setup.sh | 6 years ago | |
| cipd_client_version | 3 years ago | |
| cipd_client_version.digests | 3 years ago | |
| cipd_manifest.txt | 3 years ago | |
| cipd_manifest.versions | 3 years ago | |
| cipd_manifest_cros_python2.txt | 3 years ago | |
| cipd_manifest_cros_python2.versions | 3 years ago | |
| cit | 4 years ago | |
| cit.bat | 4 years ago | |
| cit.py | 4 years ago | |
| clang-format | 4 years ago | |
| clang-format.bat | 4 years ago | |
| clang_format.py | 3 years ago | |
| clang_format_merge_driver | 4 years ago | |
| clang_format_merge_driver.bat | 4 years ago | |
| clang_format_merge_driver.py | 4 years ago | |
| codereview.settings | 5 years ago | |
| compile_single_file | 4 years ago | |
| compile_single_file.bat | 4 years ago | |
| compile_single_file.py | 3 years ago | |
| cpplint.bat | 3 years ago | |
| cpplint.py | 3 years ago | |
| cpplint_chromium.py | ||
| cros | 3 years ago | |
| cros_python2.vpython | 3 years ago | |
| cros_sdk | 6 years ago | |
| crosjobs | 5 years ago | |
| detect_host_arch.py | 3 years ago | |
| dirmd | 5 years ago | |
| dirmd.bat | 5 years ago | |
| download_from_google_storage | 5 years ago | |
| download_from_google_storage.bat | 3 years ago | |
| download_from_google_storage.py | 3 years ago | |
| ensure_bootstrap | 4 years ago | |
| fetch | 6 years ago | |
| fetch.bat | 3 years ago | |
| fetch.py | 3 years ago | |
| fix_encoding.py | 4 years ago | |
| gclient | 4 years ago | |
| gclient-new-workdir.py | 4 years ago | |
| gclient.bat | 3 years ago | |
| gclient.py | 3 years ago | |
| gclient_completion.sh | ||
| gclient_eval.py | 3 years ago | |
| gclient_paths.py | 5 years ago | |
| gclient_scm.py | 3 years ago | |
| gclient_utils.py | 3 years ago | |
| gerrit_client.py | 4 years ago | |
| gerrit_util.py | 3 years ago | |
| git-cache | 6 years ago | |
| git-cl | 6 years ago | |
| git-crrev-parse | 4 years ago | |
| git-drover | 6 years ago | |
| git-find-releases | 6 years ago | |
| git-footers | 6 years ago | |
| git-freeze | 6 years ago | |
| git-gs | 4 years ago | |
| git-hyper-blame | 6 years ago | |
| git-map | 6 years ago | |
| git-map-branches | 6 years ago | |
| git-mark-merge-base | 6 years ago | |
| git-migrate-default-branch | 5 years ago | |
| git-nav-downstream | 6 years ago | |
| git-nav-upstream | ||
| git-new-branch | 6 years ago | |
| git-number | 6 years ago | |
| git-rebase-update | 6 years ago | |
| git-rename-branch | 6 years ago | |
| git-reparent-branch | 6 years ago | |
| git-retry | 6 years ago | |
| git-runhooks | 4 years ago | |
| git-squash-branch | 6 years ago | |
| git-thaw | 6 years ago | |
| git-upstream-diff | 6 years ago | |
| git_cache.py | 3 years ago | |
| git_cl.py | 3 years ago | |
| git_cl_completion.sh | 5 years ago | |
| git_common.py | 3 years ago | |
| git_dates.py | ||
| git_drover.py | 4 years ago | |
| git_find_releases.py | 4 years ago | |
| git_footers.py | 4 years ago | |
| git_freezer.py | 4 years ago | |
| git_hyper_blame.py | 4 years ago | |
| git_map.py | 4 years ago | |
| git_map_branches.py | 3 years ago | |
| git_mark_merge_base.py | 4 years ago | |
| git_migrate_default_branch.py | 4 years ago | |
| git_nav_downstream.py | 4 years ago | |
| git_new_branch.py | 4 years ago | |
| git_number.py | 4 years ago | |
| git_rebase_update.py | 3 years ago | |
| git_rename_branch.py | 4 years ago | |
| git_reparent_branch.py | 4 years ago | |
| git_retry.py | 3 years ago | |
| git_squash_branch.py | 4 years ago | |
| git_upstream_diff.py | 4 years ago | |
| gn | 4 years ago | |
| gn.bat | 4 years ago | |
| gn.py | 4 years ago | |
| goma_auth | 4 years ago | |
| goma_auth.bat | 4 years ago | |
| goma_ctl | 4 years ago | |
| goma_ctl.bat | 3 years ago | |
| gsutil.py | 3 years ago | |
| gsutil.py.bat | 3 years ago | |
| gsutil.vpython3 | 4 years ago | |
| isort | 4 years ago | |
| led | 5 years ago | |
| led.bat | 5 years ago | |
| lockfile.py | 6 years ago | |
| luci-auth | 5 years ago | |
| luci-auth.bat | 5 years ago | |
| lucicfg | 5 years ago | |
| lucicfg.bat | 5 years ago | |
| mac_toolchain | 7 years ago | |
| metrics.README.md | 5 years ago | |
| metrics.py | 4 years ago | |
| metrics_utils.py | 4 years ago | |
| my_activity.py | 4 years ago | |
| ninja | 3 years ago | |
| ninja-linux64 | 3 years ago | |
| ninja-mac | 3 years ago | |
| ninja.bat | 3 years ago | |
| ninja.exe | 3 years ago | |
| ninja.py | 3 years ago | |
| ninjalog.README.md | 4 years ago | |
| ninjalog_uploader.py | 4 years ago | |
| ninjalog_uploader_wrapper.py | 3 years ago | |
| owners_client.py | 3 years ago | |
| owners_finder.py | 4 years ago | |
| pinpoint | 5 years ago | |
| pinpoint.bat | 5 years ago | |
| post_build_ninja_summary.py | 3 years ago | |
| presubmit_canned_checks.py | 3 years ago | |
| presubmit_support.py | 3 years ago | |
| profile.xml | ||
| prpc | 5 years ago | |
| prpc.bat | 5 years ago | |
| pylint-1.5 | 4 years ago | |
| pylint-1.5.bat | 4 years ago | |
| pylint-2.6 | 3 years ago | |
| pylint-2.6.bat | 4 years ago | |
| pylint-2.7 | 3 years ago | |
| pylint-2.7.bat | 4 years ago | |
| pylint_main.py | 4 years ago | |
| pylintrc | 5 years ago | |
| python_runner.sh | 6 years ago | |
| rdb | 5 years ago | |
| rdb.bat | 5 years ago | |
| rdb_wrapper.py | 3 years ago | |
| repo | 5 years ago | |
| repo_launcher | 3 years ago | |
| roll-dep | 6 years ago | |
| roll-dep.bat | 6 years ago | |
| roll_dep.py | 3 years ago | |
| rustfmt.py | 3 years ago | |
| scm.py | 4 years ago | |
| setup_color.py | 4 years ago | |
| split_cl.py | 3 years ago | |
| subcommand.py | 3 years ago | |
| subprocess2.py | 5 years ago | |
| swift-format | 4 years ago | |
| swift_format.py | 4 years ago | |
| update_depot_tools | 3 years ago | |
| update_depot_tools.bat | 3 years ago | |
| update_depot_tools_toggle.py | 4 years ago | |
| upload_metrics.py | 3 years ago | |
| upload_to_google_storage.py | 3 years ago | |
| utils.py | 4 years ago | |
| vpython | 3 years ago | |
| vpython.bat | 3 years ago | |
| vpython3 | 3 years ago | |
| vpython3.bat | 3 years ago | |
| watchlists.py | 4 years ago | |
| weekly | 4 years ago | |
| whitespace.txt | 5 years ago | |
| win32imports.py | 6 years ago | |
| wtf | 4 years ago | |
| yapf | 3 years ago | |
| yapf.bat | 5 years ago | |
README.md
depot_tools
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
Tools
The most important tools are:
fetch: Agclientwrapper to checkout a project. Usefetch --helpfor more details.gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Usegclient helpfor more details and README.gclient.md.git cl: A code review tool to interact with Rietveld or Gerrit. Usegit cl helpfor more details and README.git-cl.md.roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.
There are a lot of git utilities included.
Updating
depot_tools updates itself automatically when running gclient tool. To
disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or
run ./update_depot_tools_toggle.py --disable.
To update package manually, run update_depot_tools.bat on Windows,
or ./update_depot_tools on Linux or Mac.
On Windows only, running gclient will install git and python.
Contributing
To contribute change for review:
git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>
# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail
# Edit change description if needed.
git cl desc
# If change is approved, flag it to be committed.
git cl set-commit
# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
cpplint.py
Until 2018, our cpplint.py was a copy of the upstream version at
https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that
repository is not maintained any more.
If you want to update cpplint.py in depot_tools, just upload a patch to do
so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py here is also used by the Tricium
analyzer,
so if the cpplint.py here changes, we should also update the copy used there.