You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
Alexander Thomas 24996afd00 Revert "Reland "resolve CIPD package names in gclient""
This reverts commit d69302761b.

Reason for revert: Broke Dart CI
```
gclient.py revinfo --output-json output.json
   --filter='https://chrome-infra-packages.appspot.com/dart/dart-sdk/${platform}'
```

No longer returns:
```
 {
   "sdk/tools/sdks/dart-sdk:dart/dart-sdk/${platform}": {
     "rev": "git_revision:7a6514d1377175decd3a886fe4190fbbebddac3a", 
     "url": "https://chrome-infra-packages.appspot.com/dart/dart-sdk/${platform}"
   }
 }
```

Bad build:
https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/vm-aot-msan-linux-release-x64/90/overview
Good build:
https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/vm-aot-msan-linux-release-x64/89/overview

Original change's description:
> Reland "resolve CIPD package names in gclient"
>
> This CL relands the below CL with the addition of handling situations where the CIPD package name has a variable=value and does not equate to true. In this case just return the original value in DEPS.
>
> This is a reland of commit 8faa5514ec
>
> Original change's description:
> > resolve CIPD package names in gclient
> >
> > Currently the package names are not resolved in gclient output, see example below.
> >
> > This is part of broader work to improve CIPD output, the next CL will replace 'None'.
> >
> > ```
> > $~ gclient revinfo -a | grep '${platform}\|${arch}'
> >
> > src/buildtools/linux64:gn/gn/linux-${arch}: None
> > src/buildtools/reclient:infra/rbe/client/${platform}: None
> > src/third_party/dawn/third_party/ninja:infra/3pp/tools/ninja/${platform}: None
> > src/third_party/dawn/tools/golang:infra/3pp/tools/go/${platform}: None
> > src/third_party/devtools-frontend-internal/devtools-frontend/third_party/esbuild:infra/3pp/tools/esbuild/${platform}: None
> > src/third_party/devtools-frontend/src/third_party/esbuild:infra/3pp/tools/esbuild/${platform}: None
> > src/third_party/ninja:infra/3pp/tools/ninja/${platform}: None
> > src/tools/luci-go:infra/tools/luci/isolate/${platform}: None
> > src/tools/luci-go:infra/tools/luci/swarming/${platform}: None
> > src/tools/resultdb:infra/tools/result_adapter/${platform}: None
> > ```
> >
> > Bug:b/279097790
> > Change-Id: I21abf2579910e9d79d9ee0dcd018ee761e3d3c1c
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4463983
> > Reviewed-by: Rachael Newitt <renewitt@google.com>
> > Reviewed-by: Gavin Mak <gavinmak@google.com>
> > Commit-Queue: Dan Le Febvre <dlf@google.com>
>
> Bug: b/279097790
> Change-Id: Ib08dac506ce221243c595dde5cb00e8e0d7dc7ed
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4501582
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Commit-Queue: Dan Le Febvre <dlf@google.com>

Bug: b/279097790
Change-Id: Ibf82354ac5005d9d6279d88aa99c8fb344aa6833
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4518113
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Dan Le Febvre <dlf@google.com>
3 years ago
bootstrap Minor update to git. 3 years ago
fetch_configs Add gclient conversion script. 3 years ago
git-templates
infra Roll recipe dependencies (trivial). 3 years ago
man Revert "Add --no-squash argument to git rebase-update" 3 years ago
python-bin cipd/python: optimize cat usage 3 years ago
python2-bin cipd/python: optimize cat usage 3 years ago
recipes Roll recipe dependencies (trivial). 3 years ago
testing_support Revert "Reland "resolve CIPD package names in gclient"" 3 years ago
tests Revert "Reland "resolve CIPD package names in gclient"" 3 years ago
third_party [depot tools] Update six version. 3 years ago
win_toolchain Improve .boto message visibility 3 years ago
zsh-goodies
.cipd_impl.ps1 [cipd] Simplify .cipd_impl.ps1. 3 years ago
.gitattributes Add lib to recipe cipd package 3 years ago
.gitignore Redirect cros calls to py2.7 scripts to the vpython2.7 package. 3 years ago
.isort.cfg isort: make available to users 4 years ago
.style.yapf
.vpython
.vpython3
BUILD_OWNERS add siso wrapper 3 years ago
CROS_OWNERS CROS_OWNERS: switch to our common shared lists 3 years ago
DIR_METADATA
LICENSE
LUCI_OWNERS Updating LUCI_OWNERS 3 years ago
OWNERS [siso] add autosiso wrappers 3 years ago
PRESUBMIT.py Stop running presubmit unittests with python2. 3 years ago
README.gclient.md
README.git-cl.md
README.md Indicate py3 compatibility for update_depot_tools_toggle.py 4 years ago
RECLIENT_OWNERS Add convenience wrapper for reclientreport for autoninja users 3 years ago
WATCHLISTS
auth.py
autoninja [autoninja] Respect user-provided AUTONINJA_BUILD_ID 4 years ago
autoninja.bat Handle goma_ctl/autoninja /? 3 years ago
autoninja.py Create reclient specific ninja wrapper to properly handle reproxy lifecyle 3 years ago
autosiso [siso] add autosiso wrappers 3 years ago
autosiso.bat [siso] add autosiso wrappers 3 years ago
autosiso.py [autosiso] suggest using siso command direclty for non build commands 3 years ago
bb
bb.bat
black black: add helper for formatting Python 4 years ago
bootstrap_python3 Use relative path for cipd 3 years ago
breakpad.py
cbuildbot
cipd Revert "Resolve symlinks to cipd, vpython3" 3 years ago
cipd.bat [cipd] Run cipd_impl.ps1 in constrained language mode 3 years ago
cipd_bin_setup.bat Revert "Retry switching to use CIPD ninja v1.8.2" 3 years ago
cipd_bin_setup.sh
cipd_client_version [cipd] Update cipd to v2.6.13. 3 years ago
cipd_client_version.digests [cipd] Update cipd to v2.6.13. 3 years ago
cipd_manifest.txt Roll out goma client VERSION=259 3 years ago
cipd_manifest.versions Roll out goma client VERSION=259 3 years ago
cipd_manifest_cros_python2.txt Redirect cros calls to py2.7 scripts to the vpython2.7 package. 3 years ago
cipd_manifest_cros_python2.versions Redirect cros calls to py2.7 scripts to the vpython2.7 package. 3 years ago
cit
cit.bat
cit.py
clang-format
clang-format.bat
clang_format.py clang-format: lookup for binary under third_party/clang-format 3 years ago
clang_format_merge_driver
clang_format_merge_driver.bat
clang_format_merge_driver.py
codereview.settings
compile_single_file
compile_single_file.bat
compile_single_file.py Call ninja.py from compile_single_file.py 3 years ago
cpplint.bat Use python3 for cpplint and get_toolchain on Win 4 years ago
cpplint.py Fix various lint false positives. 3 years ago
cpplint_chromium.py Fix various lint false positives. 3 years ago
cros cros: Enforce minimum Python version of 3.8 3 years ago
cros_python2.vpython Redirect cros calls to py2.7 scripts to the vpython2.7 package. 3 years ago
cros_sdk
crosjobs
detect_host_arch.py Use x64 emulation for Windows on Arm targets 3 years ago
dirmd
dirmd.bat
download_from_google_storage
download_from_google_storage.bat use python3 for download_from_google_storage.bat 4 years ago
download_from_google_storage.py Handle 401 from gsutil 3 years ago
ensure_bootstrap Use python3 for gsutil bootstrapping 4 years ago
fetch [py2] Drop envvar to run scripts with py2 3 years ago
fetch.bat [py2] Drop envvar to run scripts with py2 3 years ago
fetch.py fetch: make --no-history and --no-hooks switches consistent 3 years ago
fix_encoding.py Fix \r\r\n line endings in presubmit output 4 years ago
gclient [py2] Drop envvar to run scripts with py2 3 years ago
gclient-new-workdir.py Explicitly run everything with python3 4 years ago
gclient.bat [py2] Drop envvar to run scripts with py2 3 years ago
gclient.py Revert "Reland "resolve CIPD package names in gclient"" 3 years ago
gclient_completion.sh
gclient_eval.py Fix roll-dep commit message on Windows and add suggestions 3 years ago
gclient_paths.py Suppress stderr of the git rev-parse command 3 years ago
gclient_scm.py Revert "Reland "resolve CIPD package names in gclient"" 3 years ago
gclient_utils.py Revert "Move scm.py to lib/" 3 years ago
gerrit Symlink gerrit CLI into depot_tools 3 years ago
gerrit_client.py Allow 409 error from Gerrit when creating the branch 3 years ago
gerrit_util.py Allow 409 error from Gerrit when creating the branch 3 years ago
git-cache
git-cl
git-crrev-parse
git-drover
git-find-releases
git-footers
git-freeze
git-gs Add *.ts (typescript files) to git-gs 4 years ago
git-hyper-blame
git-map
git-map-branches
git-mark-merge-base
git-migrate-default-branch
git-nav-downstream
git-nav-upstream
git-new-branch
git-number
git-rebase-update
git-rename-branch
git-reparent-branch
git-retry
git-runhooks
git-squash-branch
git-thaw
git-upstream-diff
git_cache.py Reset git_cache mirror when HEAD points to master 3 years ago
git_cl.py [git-cl][presubmit] Remove references to LUCI_OMIT_PYTHON2. 3 years ago
git_cl_completion.sh
git_common.py Don't enforce branch limit on rebase-update if only rebasing current 3 years ago
git_dates.py
git_drover.py Explicitly run everything with python3 4 years ago
git_find_releases.py Explicitly run everything with python3 4 years ago
git_footers.py Explicitly run everything with python3 4 years ago
git_freezer.py Explicitly run everything with python3 4 years ago
git_hyper_blame.py Explicitly run everything with python3 4 years ago
git_map.py Explicitly run everything with python3 4 years ago
git_map_branches.py git-map-branches: Fix --show-subject for branches that are gone 3 years ago
git_mark_merge_base.py Explicitly run everything with python3 4 years ago
git_migrate_default_branch.py Revert "Move scm.py to lib/" 3 years ago
git_nav_downstream.py Explicitly run everything with python3 4 years ago
git_new_branch.py Explicitly run everything with python3 4 years ago
git_number.py
git_rebase_update.py Revert "Add --no-squash argument to git rebase-update" 3 years ago
git_rename_branch.py Explicitly run everything with python3 4 years ago
git_reparent_branch.py Explicitly run everything with python3 4 years ago
git_retry.py Fix git-retry on errors 3 years ago
git_squash_branch.py Explicitly run everything with python3 4 years ago
git_upstream_diff.py Explicitly run everything with python3 4 years ago
gn
gn.bat
gn.py
goma_auth
goma_auth.bat Set errorlevel in .bat wrappers on exit /b where appropriate. 4 years ago
goma_ctl
goma_ctl.bat Handle goma_ctl/autoninja /? 3 years ago
gsutil.py Improve .boto message visibility 3 years ago
gsutil.py.bat Reland "Make depot_tools scripts return exit codes properly on all platforms." 3 years ago
gsutil.vpython3 Reland "Update gsutil to use gsutil version 4.68" 4 years ago
infra_to_superproject Use shutil.copytree instead for migration script instead. 3 years ago
infra_to_superproject.bat Use shutil.copytree instead for migration script instead. 3 years ago
infra_to_superproject.py Fix infra_to_superproject for Linux 3 years ago
isort isort: make available to users 4 years ago
led
led.bat
lockfile.py
luci-auth
luci-auth.bat
lucicfg
lucicfg.bat
mac_toolchain
metrics.README.md
metrics.py Update env_vars metrics name. 3 years ago
metrics_utils.py Replace metrics link to point to main 3 years ago
my_activity.py
ninja Revert "Use depot_tools python3 to call ninja.py" 3 years ago
ninja.bat Add single file compile support for Windows in ninja wrappers 3 years ago
ninja.py Fix a spelling error in a comment 3 years ago
ninja_reclient.py [siso] add autosiso wrappers 3 years ago
ninjalog.README.md
ninjalog_uploader.py [ninjalog_uploader] Exclude absolute paths and options from targets 3 years ago
ninjalog_uploader_wrapper.py Typo when countdown is more than 1. 4 years ago
owners_client.py Reland "Remove old DepotToolsOwners implementation" 3 years ago
owners_finder.py
pinpoint
pinpoint.bat
post_build_ninja_summary.py Add elapsed-time sorting option to build summary 3 years ago
presubmit_canned_checks.py Drop pylint-1.5 3 years ago
presubmit_support.py [git-cl][presubmit] Remove references to LUCI_OMIT_PYTHON2. 3 years ago
profile.xml
prpc
prpc.bat
pylint-2.6 Update pylint vpython specs to use a specific minor version. 3 years ago
pylint-2.6.bat
pylint-2.7 Update pylint vpython specs to use a specific minor version. 3 years ago
pylint-2.7.bat
pylint_main.py Explicitly run everything with python3 4 years ago
pylintrc
python_runner.sh [py2] Drop envvar to run scripts with py2 3 years ago
rdb
rdb.bat
rdb_wrapper.py Add snippets to presubmit failures in resultdb 3 years ago
reclient_helper.py Move reclient cache dir to gclient root to avoid wipeout on gn clean 3 years ago
reclientreport Add convenience wrapper for reclientreport for autoninja users 3 years ago
reclientreport.bat Add convenience wrapper for reclientreport for autoninja users 3 years ago
reclientreport.py Fix reclientreport after functions moved to reclient_helper 3 years ago
repo
repo_launcher Update repo_launcher to 2.32 3 years ago
roll-dep [py2] Drop envvar to run scripts with py2 3 years ago
roll-dep.bat [py2] Drop envvar to run scripts with py2 3 years ago
roll_dep.py Fix roll dep to use update-index 3 years ago
rustfmt.py Use rustfmt from third_party/rust-toolchain/bin directory. 3 years ago
scm.py Revert "Move scm.py to lib/" 3 years ago
setup_color.py Explicitly run everything with python3 4 years ago
siso add siso wrapper 3 years ago
siso.bat add siso wrapper 3 years ago
siso.py add siso wrapper 3 years ago
split_cl.py Revert "Move scm.py to lib/" 3 years ago
subcommand.py Use empty argument list in cmdhelp 3 years ago
subprocess2.py
swift-format Support git cl formatting for swift files 4 years ago
swift_format.py Make swift-format default True on Mac hosts 4 years ago
update_depot_tools run `goma_ctl update_hook` in update_depot_tools 3 years ago
update_depot_tools.bat run `goma_ctl update_hook` in update_depot_tools 3 years ago
update_depot_tools_toggle.py Indicate py3 compatibility for update_depot_tools_toggle.py 4 years ago
upload_metrics.py Catch RemoteDisconnected on upload metrics 4 years ago
upload_to_google_storage.py Fix code check in upload to google storage. 3 years ago
utils.py Revert "Extract searching relevat files in utils function" 3 years ago
vpython Move python2_usage.txt from depot_tools to temp 3 years ago
vpython.bat Move python2_usage.txt from depot_tools to temp 3 years ago
vpython3 Revert "Resolve symlinks to cipd, vpython3" 3 years ago
vpython3.bat Use the bundled interpreter instead of passing -vpython-interpreter. 3 years ago
watchlists.py Explicitly run everything with python3 4 years ago
weekly Explicitly run everything with python3 4 years ago
whitespace.txt
win32imports.py
wtf Explicitly run everything with python3 4 years ago
yapf Update vpython spec for yapf to 0.31.0 3 years ago
yapf.bat

README.md

depot_tools

Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or run ./update_depot_tools_toggle.py --disable.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.