You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
rmistry@google.com 1c28dab9ee Revert of [depot_tools] Find, upload and apply patchset dependencies (patchset #17 id:360001 of https://codereview.chromium.org/1149653002/)
Reason for revert:
Ran into a crash during the bot_update step here:
https://uberchromegw.corp.google.com/i/internal.infra.try/builders/infra-internal-presubmit/builds/62

Original issue's description:
> Find, upload and apply patchset dependencies.
> 
> Here is an explanation of the changes in each module:
> 
> * git_cl.py -
> IF a local branch is being tracked AND a CL has been uploaded there THEN use the CL's issue number and latest patchset as a dependency.
> 
> * upload.py -
> Uploads the patchset dependency, if it exists, to Rietveld (Rietveld will be able to parse this when https://codereview.chromium.org/1155513002/ lands).
> 
> * rietveld.py -
> Adds utility methods to get patchset dependencies from the new Rietveld endpoint (the endpoint will exist when https://codereview.chromium.org/1155513002/ lands).
> 
> * apply_issue.py -
> If CL3 depends on CL2 which in turn depends on CL1 then apply_issue will gather a list of all issues and patchsets to apply (Eg: [CL1:PS1, CL2:PS1, CL3:PS2]).
> apply_issue will then loop over the list applying each dependency.
> Note: The apply_issue.py diff looks much worse than it is. Please see my comment in
> https://codereview.chromium.org/1149653002/diff/260001/apply_issue.py#oldcode169
> 
> 
> Tested end-to-end using a test Git repository (https://skia.googlesource.com/skiabot-test/) and the following CLs created in my test Rietveld instance:
> * https://skia-codereview-staging.appspot.com/931002  ('Branch1 CL')
> * https://skia-codereview-staging.appspot.com/5001001 ('Branch2 CL')
> * https://skia-codereview-staging.appspot.com/9881001 ('Branch3 CL')
> * https://skia-codereview-staging.appspot.com/3951001 ('Branch3.1 CL')
> Opt into the new UI and observe the new 'Depends on Patchset' and 'Dependent Patchsets' sections in the above CLs.
> 
> 
> Design doc is here: https://docs.google.com/document/d/1KZGFKZpOPvco81sYVRCzwlnjGctup71RAzY0MSb0ntc/edit#heading=h.6r6lt4tsvssw
> 
> BUG=502255
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295778

TBR=agable@chromium.org,jrobbins@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=502255

Review URL: https://codereview.chromium.org/1200773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295782 0039d316-1c4b-4281-b951-d872f2087c98
10 years ago
bootstrap Set default Windows git to 1.9.5-chromium.6 build. 10 years ago
git-templates Explicitly exec hooks inside a shell. 12 years ago
git_utils
infra Added CQ team as OWNERS for CQ-related stuff in depot_tools 10 years ago
man Fixed ``smart'' quotes in code block. 10 years ago
recipes Revert "Run install-build-deps in the middle of 'fetch chromium'" 10 years ago
support chromite_wrapper: Fix up comment. 12 years ago
testing_support Fix format string. 10 years ago
tests [depot_tools] New "git cl upload" flag to traverse dependent branches and re-upload them. 10 years ago
third_party Revert of [depot_tools] Find, upload and apply patchset dependencies (patchset #17 id:360001 of https://codereview.chromium.org/1149653002/) 10 years ago
win_toolchain Fix System32 vs Sysnative for x86 python 10 years ago
zsh-goodies
.gitignore Enable OAuth2 by default. 10 years ago
.style.yapf Add experimental support for python in 'git cl format' 10 years ago
LICENSE
OWNERS Added CQ team as OWNERS for CQ-related stuff in depot_tools 10 years ago
PRESUBMIT.py PRESUBMIT: Ignore external_bin/. 10 years ago
README
README.codereview
README.gclient
README.git-cl
README.testing
WATCHLISTS Normalizes OWNERS and WATCHLISTS. 10 years ago
annotated_gclient.py Send build revision as json object. 11 years ago
apply_issue
apply_issue.bat Add some missing setlocals from various .bat files 11 years ago
apply_issue.py Revert of [depot_tools] Find, upload and apply patchset dependencies (patchset #17 id:360001 of https://codereview.chromium.org/1149653002/) 10 years ago
auth.py my_activity.py: update to use oauth for projecthosting 10 years ago
breakpad.py
buildbucket.py Add script for triggering Buildbucket builds 10 years ago
cbuildbot
checkout.py Use three-way merge when applying Git patches. 11 years ago
chrome-update-create-task.bat
chrome-update.bat
chrome-update.py Handle KeyboardInterrupt consistently in python scripts 10 years ago
chrome_set_ver
clang-format Depot tools: use the clang-format binaries that are now included 11 years ago
clang-format.bat Add some missing setlocals from various .bat files 11 years ago
clang_format.py Fix the argument passed to main() in clang_format.py 10 years ago
codereview.settings Update codereview settings to match new CQ project name. 10 years ago
commit_queue Added commit_queue binaries for Windows and Linux 10 years ago
commit_queue.bat Added commit_queue binaries for Windows and Linux 10 years ago
commit_queue.py Convert dict of builders to list since we do not support properties anymore 10 years ago
cpplint.bat
cpplint.py Update cpplint.py to r141. 10 years ago
cpplint_chromium.py
create-chromium-git-src
create-ntfs-junction.c
create-ntfs-junction.exe
cros
cros_sdk
dart_format.py Run dartfmt when invoking git cl format. 10 years ago
depot-tools-auth Add OAuth2 support for end users (i.e. 3-legged flow with the browser). 10 years ago
depot-tools-auth.bat Add OAuth2 support for end users (i.e. 3-legged flow with the browser). 10 years ago
depot-tools-auth.py Add OAuth2 support for end users (i.e. 3-legged flow with the browser). 10 years ago
download_from_google_storage Added posix and windows runner scripts for download_from_google_storage.py 12 years ago
download_from_google_storage.bat Added posix and windows runner scripts for download_from_google_storage.py 12 years ago
download_from_google_storage.py Simply download_from_google_storage --config 10 years ago
drover
drover.bat
drover.py Handle KeyboardInterrupt consistently in python scripts 10 years ago
fetch Update fetch to support more flexible refspecs 11 years ago
fetch.bat Add some missing setlocals from various .bat files 11 years ago
fetch.py Fix dry_run run() return type to match check_output(). 10 years ago
fix_encoding.py Update cpplint.py to r141. 10 years ago
gcl
gcl.bat
gcl.py Extract authentication options handling into a separate function. 10 years ago
gclient Run "svn revert" in update_depot_tools --force 10 years ago
gclient-new-workdir.py Clearer help in gclient-new-workdir.py 11 years ago
gclient.bat Run "svn revert" in update_depot_tools --force 10 years ago
gclient.py Treat 'revert' like 'update' in gclient. 10 years ago
gclient_completion.sh Added basic completion (the commands) for gclient. 11 years ago
gclient_scm.py Update .git/objects/info/alternates when upstream url changes. 10 years ago
gclient_utils.py Add experimental support for python in 'git cl format' 10 years ago
gerrit_util.py Provide diagnostic messages about netrc failures. 11 years ago
git-auto-svn Remove useless comments from git bash wrappers. 11 years ago
git-cache Remove useless comments from git bash wrappers. 11 years ago
git-cherry-pick-upload Remove useless comments from git bash wrappers. 11 years ago
git-cl Remove useless comments from git bash wrappers. 11 years ago
git-cl-upload-hook
git-crrev-parse Convenience git extension for converting a chromium git commit number to a git hash. 10 years ago
git-crsync Invoke the bash shell via /usr/bin/env so that these scripts run on operating systems without /bin/bash too. 11 years ago
git-crup Update the Blink recipe to use 'webkit_revision' instead of 'webkit_rev' 11 years ago
git-footers Remove useless comments from git bash wrappers. 11 years ago
git-freeze Remove useless comments from git bash wrappers. 11 years ago
git-gs Have git-gs search .gni files 11 years ago
git-lkgr Invoke the bash shell via /usr/bin/env so that these scripts run on operating systems without /bin/bash too. 11 years ago
git-map Remove useless comments from git bash wrappers. 11 years ago
git-map-branches Remove useless comments from git bash wrappers. 11 years ago
git-mark-merge-base Remove useless comments from git bash wrappers. 11 years ago
git-nav-downstream Remove useless comments from git bash wrappers. 11 years ago
git-nav-upstream Remove useless comments from git bash wrappers. 11 years ago
git-new-branch Remove useless comments from git bash wrappers. 11 years ago
git-number Remove useless comments from git bash wrappers. 11 years ago
git-rebase-update Remove useless comments from git bash wrappers. 11 years ago
git-rename-branch Remove useless comments from git bash wrappers. 11 years ago
git-reparent-branch Remove useless comments from git bash wrappers. 11 years ago
git-retry Remove useless comments from git bash wrappers. 11 years ago
git-runhooks Invoke the bash shell via /usr/bin/env so that these scripts run on operating systems without /bin/bash too. 11 years ago
git-squash-branch Remove useless comments from git bash wrappers. 11 years ago
git-thaw Invoke the bash shell via /usr/bin/env so that these scripts run on operating systems without /bin/bash too. 11 years ago
git-try Invoke the bash shell via /usr/bin/env so that these scripts run on operating systems without /bin/bash too. 11 years ago
git-upstream-diff Invoke the bash shell via /usr/bin/env so that these scripts run on operating systems without /bin/bash too. 11 years ago
git_auto_svn.py Make git auto-svn fail if git svn fetch fails. 10 years ago
git_cache.py Revert of Specify GIT_DIR when running git-config in a mirror. (patchset #4 id:60001 of https://codereview.chromium.org/1167193002/) 10 years ago
git_cherry_pick_upload.py Extract authentication options handling into a separate function. 10 years ago
git_cl.py Revert of [depot_tools] Find, upload and apply patchset dependencies (patchset #17 id:360001 of https://codereview.chromium.org/1149653002/) 10 years ago
git_common.py When using git-rebase-update, pass --no-verify to git commit. 10 years ago
git_footers.py Improve "dcommit in git repo" error message. 10 years ago
git_freezer.py Handle KeyboardInterrupt consistently in python scripts 10 years ago
git_map.py Handle KeyboardInterrupt consistently in python scripts 10 years ago
git_map_branches.py Fix "git cl map-branches -vvv" 10 years ago
git_mark_merge_base.py Handle KeyboardInterrupt consistently in python scripts 10 years ago
git_nav_downstream.py Handle KeyboardInterrupt consistently in python scripts 10 years ago
git_new_branch.py Handle KeyboardInterrupt consistently in python scripts 10 years ago
git_number.py Handle KeyboardInterrupt consistently in python scripts 10 years ago
git_rebase_update.py Only chdir in rebase-update if there's a directory to go back to. 10 years ago
git_rename_branch.py Handle KeyboardInterrupt consistently in python scripts 10 years ago
git_reparent_branch.py Handle KeyboardInterrupt consistently in python scripts 10 years ago
git_retry.py Handle KeyboardInterrupt consistently in python scripts 10 years ago
git_squash_branch.py git-squash-branch: handle empty squashes 10 years ago
git_try.py Handle KeyboardInterrupt consistently in python scripts 10 years ago
git_upstream_diff.py Handle KeyboardInterrupt consistently in python scripts 10 years ago
gn Add executable and line ending properties for GN. 11 years ago
gn.bat Add some missing setlocals from various .bat files 11 years ago
gn.py Handle KeyboardInterrupt consistently in python scripts 10 years ago
gsutil.py Hook sys.stdio directly to the gsutil subprocess for the gsutil call 10 years ago
hammer
hammer.bat
my_activity.py my_activity.py: update to use oauth for projecthosting 10 years ago
my_reviews.py Extract authentication options handling into a separate function. 10 years ago
ninja Update ninja to v1.5.3 on Mac, Linux32, Linux64, Windows. 10 years ago
ninja-linux32 Update ninja to v1.5.3 on Mac, Linux32, Linux64, Windows. 10 years ago
ninja-linux64 Update ninja to v1.5.3 on Mac, Linux32, Linux64, Windows. 10 years ago
ninja-mac Update ninja to v1.5.3 on Mac, Linux32, Linux64, Windows. 10 years ago
ninja.exe Update ninja to v1.5.3 on Mac, Linux32, Linux64, Windows. 10 years ago
owners.py Implement support for file: includes in OWNERS files. 10 years ago
owners_finder.py An interactive tool to help find owners covering current change list. 12 years ago
patch.py Fix filename checks 10 years ago
presubmit_canned_checks.py Parallelize pylint PRESUBMIT checks. 10 years ago
presubmit_support.py Parallelize pylint PRESUBMIT checks. 10 years ago
profile.xml
pylint Fix git-cl quoting, yet again. 11 years ago
pylint.py Handle KeyboardInterrupt consistently in python scripts 10 years ago
pylintrc Revert "Revert "pylint: upgrade to 1.3.1"" 10 years ago
python_git_runner.sh Refactor the way that git executables are launched in depot tools. 11 years ago
repo Add pgp key for davidjames to repo. 11 years ago
rietveld.py Revert of [depot_tools] Find, upload and apply patchset dependencies (patchset #17 id:360001 of https://codereview.chromium.org/1149653002/) 10 years ago
roll-dep Convenience tool for rolling git-style deps with an svn revision. 11 years ago
roll-dep-svn Rename roll-dep to roll-dep-svn and add roll-dep for git. 10 years ago
roll-dep-svn.bat Rename roll-dep to roll-dep-svn and add roll-dep for git. 10 years ago
roll-dep.bat Convenience tool for rolling git-style deps with an svn revision. 11 years ago
roll_dep.py roll_dep.py: switch to argparse 10 years ago
roll_dep_svn.py Rename roll-dep to roll-dep-svn and add roll-dep for git. 10 years ago
scm.py Reland "Make gclient ready for the Blink (DEPS to main project)" 10 years ago
subcommand.py Automatically upgrade '_' to '-' when finding the right command. 10 years ago
subprocess2.py Add quotes around command line in subproccess error message 10 years ago
trychange.py git try -t support for Gerrit 10 years ago
update_depot_tools Added an env variable to hide "Depot tools has been updated..." message 10 years ago
update_depot_tools.bat Run "svn revert" in update_depot_tools --force 10 years ago
upload_to_google_storage.py In upload_to_google_storage, pass -z argument through to gsutil. 10 years ago
watchlists.py
weekly
wtf

README

This package contains tools for working with Chromium development.

The "gclient" wrapper knows how to keep this repository updated to
the latest versions of these tools as found at:

    http://src.chromium.org/svn/trunk/tools/depot_tools

This package contains:

  chrome-update-create-task.bat
    Creates a scheduled task to do an automatic local chromium build every day.

  cpplint.py
    A copy of our linting tool which enforces Google style. Fetched from
    http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py

  gcl
    A tool for uploading and managing code reviews on the Chromium
    project, using the Rietveld code review tool.  More info at:
    http://code.google.com/p/rietveld/

  gclient
    A script for managing a workspace with modular dependencies that
    are each checked out independently from different repositories.
    More info at:
    http://code.google.com/p/gclient/

  hammer
    A wrapper script for building Chromium with the SCons software
    construction tool.  More info at:
    http://www.scons.org/

Note: svn and python will be installed automatically if not accessible (on
Windows only).

To update this distribution manually, run .\update_depot_tools.bat on Windows,
or ./update_depot_tools on Linux or Mac.

To disable automatic updating, set the environment variable DEPOT_TOOLS_UPDATE=0