You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
812ac228e3
Clients using some Clang-Format options can run into bugs when using 0 lines of context. AlignConsecutiveAssignments in particular is picky and behaves differently with 0 lines of context. This behaviour lead to 'git cl format' behaving differently from 'git cl format --full'. That could also break presubmit format checks. Using >0 lines of context for 'git diff' fixes the inconsistency. Add a setting 'DIFF_LINES_OF_CONTEXT' that can be controlled via codereview.settings. Defaults to zero to preserve the old behaviour. The setting allows the client to control the number of lines of context to use when running 'git cl format'. Bug: angleproject:4003 Change-Id: Ied2ebf23df4c41ba19bfbd5b8ddf526b56a20b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1864309 Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> |
6 years ago | |
|---|---|---|
| .. | ||
| gstools | ||
| OWNERS | ||
| auth_test.py | 6 years ago | |
| bot_update_coverage_test.py | 6 years ago | |
| cipd_bootstrap_test.py | ||
| download_from_google_storage_unittest.py | 6 years ago | |
| fix_encoding_test.py | 6 years ago | |
| gclient_eval_unittest.py | ||
| gclient_scm_test.py | 6 years ago | |
| gclient_smoketest.py | ||
| gclient_test.py | ||
| gclient_utils_test.py | ||
| git_cache_test.py | ||
| git_cl_creds_check_report.txt | ||
| git_cl_test.py | 6 years ago | |
| git_common_test.py | ||
| git_dates_test.py | 6 years ago | |
| git_drover_test.py | ||
| git_footers_test.py | ||
| git_hyper_blame_test.py | ||
| git_number_test.py | ||
| git_rebase_update_test.py | 6 years ago | |
| gsutil_test.py | 6 years ago | |
| metrics_test.py | ||
| ninjalog_uploader_test.py | ||
| owners_finder_test.py | ||
| owners_unittest.py | 6 years ago | |
| presubmit_unittest.py | ||
| recipes_test.py | ||
| roll_dep_test.py | ||
| scm_unittest.py | ||
| subprocess2_test.py | ||
| upload_to_google_storage_unittest.py | 6 years ago | |
| watchlists_unittest.py | ||