You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
84 lines
2.7 KiB
Python
84 lines
2.7 KiB
Python
# Copyright (c) 2012 The Chromium Authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
"""Top-level presubmit script for depot tools.
|
|
|
|
See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
|
|
details on the presubmit API built into depot_tools.
|
|
"""
|
|
|
|
import fnmatch
|
|
import os
|
|
|
|
|
|
def DepotToolsPylint(input_api, output_api):
|
|
"""Gather all the pylint logic into one place to make it self-contained."""
|
|
white_list = [
|
|
r'^[^/]*\.py$',
|
|
r'^testing_support/[^/]*\.py$',
|
|
r'^tests/[^/]*\.py$',
|
|
r'^recipe_modules/.*\.py$', # Allow recursive search in recipe modules.
|
|
]
|
|
black_list = list(input_api.DEFAULT_BLACK_LIST)
|
|
if os.path.exists('.gitignore'):
|
|
with open('.gitignore') as fh:
|
|
lines = [l.strip() for l in fh.readlines()]
|
|
black_list.extend([fnmatch.translate(l) for l in lines if
|
|
l and not l.startswith('#')])
|
|
if os.path.exists('.git/info/exclude'):
|
|
with open('.git/info/exclude') as fh:
|
|
lines = [l.strip() for l in fh.readlines()]
|
|
black_list.extend([fnmatch.translate(l) for l in lines if
|
|
l and not l.startswith('#')])
|
|
disabled_warnings = [
|
|
'R0401', # Cyclic import
|
|
'W0613', # Unused argument
|
|
]
|
|
return input_api.canned_checks.GetPylint(
|
|
input_api,
|
|
output_api,
|
|
white_list=white_list,
|
|
black_list=black_list,
|
|
disabled_warnings=disabled_warnings)
|
|
|
|
|
|
def CommonChecks(input_api, output_api, tests_to_black_list):
|
|
results = []
|
|
results.extend(input_api.canned_checks.CheckOwners(input_api, output_api))
|
|
# TODO(maruel): Make sure at least one file is modified first.
|
|
# TODO(maruel): If only tests are modified, only run them.
|
|
tests = DepotToolsPylint(input_api, output_api)
|
|
unit_tests = input_api.canned_checks.GetUnitTestsInDirectory(
|
|
input_api,
|
|
output_api,
|
|
'tests',
|
|
whitelist=[r'.*test\.py$'],
|
|
blacklist=tests_to_black_list)
|
|
if not input_api.platform.startswith(('cygwin', 'win32')):
|
|
tests.extend(unit_tests)
|
|
else:
|
|
print('Warning: not running unit tests on Windows')
|
|
results.extend(input_api.RunTests(tests))
|
|
return results
|
|
|
|
|
|
def CheckChangeOnUpload(input_api, output_api):
|
|
# Do not run integration tests on upload since they are way too slow.
|
|
tests_to_black_list = [
|
|
r'^checkout_test\.py$',
|
|
r'^gclient_smoketest\.py$',
|
|
r'^scm_unittest\.py$',
|
|
r'^subprocess2_test\.py$',
|
|
]
|
|
return CommonChecks(input_api, output_api, tests_to_black_list)
|
|
|
|
|
|
def CheckChangeOnCommit(input_api, output_api):
|
|
output = []
|
|
output.extend(CommonChecks(input_api, output_api, []))
|
|
output.extend(input_api.canned_checks.CheckDoNotSubmit(
|
|
input_api,
|
|
output_api))
|
|
return output
|