You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
Bruce Dawson 00790d319f Fix \r\r\n line endings in presubmit output
When running "git cl presubmit --all" some of the presubmit messages
were ending up double-spaced if the output is sent to a file and then
loaded into notepad or Visual Studio. Visual Studio would complain
about inconsistent line endings, and it turns out that this was all
caused by some lines having \r\r\n line endings - notepad and Visual
Studio interpret that as two line endings.

The problem is that the stream that WinUnicodeOutput writes to does \n
to \r\n translation. If the text being printed already has \r\n line
endings then we get doubled-up \r characters. The fix is to replace all
\r\n sequences with \n before calling write.

This reduces the line count of the output by almost 2300 lines (more
than 25% of the total) and makes it much more readable.

Bug: 1309977
Change-Id: Ie5475087badc3d3146e4f2ba41d30c9817dd375a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3589498
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
3 years ago
bootstrap git 2.35.1.chromium.8 to depot_tools stable. 3 years ago
fetch_configs Add fetch hook for ANGLE. 3 years ago
git-templates
infra Roll recipe dependencies (trivial). 3 years ago
man [docs] Fix alias settings 3 years ago
python-bin
python2-bin
recipes Roll recipe dependencies (trivial). 3 years ago
testing_support Explicitly run everything with python3 3 years ago
tests Ensure _PresubmitResult._message is text 3 years ago
third_party Remove unused third_party coverage library 3 years ago
win_toolchain Remove scottmg from OWNERS 3 years ago
zsh-goodies
.cipd_impl.ps1
.gitattributes Reland "Update gsutil to use gsutil version 4.68" 3 years ago
.gitignore
.style.yapf
.vpython Add explicit vpython verification tags which include mac-arm64. 4 years ago
.vpython3 Reland "Use py3 in gitiles recipe module" 3 years ago
CROS_OWNERS CROS_OWNERS: add more build peeps 4 years ago
DIR_METADATA
GOMA_OWNERS Update GOMA_OWNERS 4 years ago
LICENSE
LUCI_OWNERS Remove tandrii@ from OWNERS under depot_tools 3 years ago
OWNERS Add brucedawson@ as presubmit*.py OWNER 3 years ago
PRESUBMIT.py Use pylint 2.7 for depot_tools 3 years ago
README.gclient.md
README.git-cl.md
README.md Indicate py3 compatibility for update_depot_tools_toggle.py 3 years ago
WATCHLISTS Update Source team WATCHLIST entry. 3 years ago
auth.py [auth] log errors from luci-auth token invocation. 4 years ago
autoninja [autoninja] Respect user-provided AUTONINJA_BUILD_ID 3 years ago
autoninja.bat [autoninja] Respect user-provided AUTONINJA_BUILD_ID on Windows 3 years ago
autoninja.py Use pylint 2.7 for depot_tools 3 years ago
bb Add revert instructions 4 years ago
bb.bat Add revert instructions 4 years ago
bootstrap_python3 [mac/arm] pull python3 binary in cipd bootstrap now that it exists 4 years ago
breakpad.py
cbuildbot
cipd [cipd] Detect Mac ARM running under Rosetta 3 years ago
cipd.bat
cipd_bin_setup.bat
cipd_bin_setup.sh
cipd_client_version [cipd] Update cipd client to v2.6.2. 4 years ago
cipd_client_version.digests [cipd] Update cipd client to v2.6.2. 4 years ago
cipd_manifest.txt Update Pinpoint CLI - support attempts arg 3 years ago
cipd_manifest.versions Update Pinpoint CLI - support attempts arg 3 years ago
cit Use py3 for remaining tools in depot_tools path 4 years ago
cit.bat Use py3 for remaining tools in depot_tools path 4 years ago
cit.py Use pylint 2.7 for depot_tools 3 years ago
clang-format Use py3 for remaining tools in depot_tools path 4 years ago
clang-format.bat Use py3 for remaining tools in depot_tools path 4 years ago
clang_format.py Use py3 for remaining tools in depot_tools path 4 years ago
clang_format_merge_driver Use py3 for remaining tools in depot_tools path 4 years ago
clang_format_merge_driver.bat Use py3 for remaining tools in depot_tools path 4 years ago
clang_format_merge_driver.py Use pylint 2.7 for depot_tools 3 years ago
codereview.settings
compile_single_file Use py3 for remaining tools in depot_tools path 4 years ago
compile_single_file.bat Use py3 for remaining tools in depot_tools path 4 years ago
compile_single_file.py Use pylint 2.7 for depot_tools 3 years ago
cpplint.bat
cpplint.py Improve git cl presubmit --all output 3 years ago
cpplint_chromium.py
cros
cros_sdk
crosjobs Add revert instructions 4 years ago
detect_host_arch.py Explicitly run everything with python3 3 years ago
dirmd Add revert instructions 4 years ago
dirmd.bat Add revert instructions 4 years ago
download_from_google_storage Switch download_from_google_storage to py3 4 years ago
download_from_google_storage.bat Revert "Switch download_from_google_storage scripts to invoke python3." 4 years ago
download_from_google_storage.py Use pylint 2.7 for depot_tools 3 years ago
ensure_bootstrap Use python3 for gsutil bootstrapping 3 years ago
fetch
fetch.bat
fetch.py Explicitly run everything with python3 3 years ago
fix_encoding.py Fix \r\r\n line endings in presubmit output 3 years ago
gclient Skip depot_tools update for gclient recurse 3 years ago
gclient-new-workdir.py Explicitly run everything with python3 3 years ago
gclient.bat
gclient.py Fix vpython3 version mismatch error 3 years ago
gclient_completion.sh
gclient_eval.py Use pylint 2.7 for depot_tools 3 years ago
gclient_paths.py Change FindGclientRoot to Use os.path.abspath instead of os.path.realpath 4 years ago
gclient_scm.py Fix host and repo parsing for download-topics 3 years ago
gclient_utils.py Use pylint 2.7 for depot_tools 3 years ago
gerrit_client.py Allow to pass CC list when create a gerrit change 3 years ago
gerrit_util.py Use pylint 2.7 for depot_tools 3 years ago
git-cache
git-cl
git-crrev-parse Fix git-crrev-parse to work with both master & main branches 3 years ago
git-drover
git-find-releases
git-footers
git-freeze
git-gs Add *.ts (typescript files) to git-gs 3 years ago
git-hyper-blame
git-map
git-map-branches
git-mark-merge-base
git-migrate-default-branch
git-nav-downstream
git-nav-upstream
git-new-branch
git-number
git-rebase-update
git-rename-branch
git-reparent-branch
git-retry
git-runhooks Revert "Remove unused functionality in bot_update.py" 3 years ago
git-squash-branch
git-thaw
git-upstream-diff
git_cache.py Explicitly run everything with python3 3 years ago
git_cl.py Support git cl formatting for swift files 3 years ago
git_cl_completion.sh
git_common.py Use pylint 2.7 for depot_tools 3 years ago
git_dates.py
git_drover.py Explicitly run everything with python3 3 years ago
git_find_releases.py Explicitly run everything with python3 3 years ago
git_footers.py Explicitly run everything with python3 3 years ago
git_freezer.py Explicitly run everything with python3 3 years ago
git_hyper_blame.py Explicitly run everything with python3 3 years ago
git_map.py Explicitly run everything with python3 3 years ago
git_map_branches.py Explicitly run everything with python3 3 years ago
git_mark_merge_base.py Explicitly run everything with python3 3 years ago
git_migrate_default_branch.py Update git fetch refspecs on git migrate 3 years ago
git_nav_downstream.py Explicitly run everything with python3 3 years ago
git_new_branch.py Explicitly run everything with python3 3 years ago
git_number.py Use pylint 2.7 for depot_tools 3 years ago
git_rebase_update.py Make the "mark branch dormant" instructions simpler to copy+paste. 3 years ago
git_rename_branch.py Explicitly run everything with python3 3 years ago
git_reparent_branch.py Explicitly run everything with python3 3 years ago
git_retry.py Explicitly run everything with python3 3 years ago
git_squash_branch.py Explicitly run everything with python3 3 years ago
git_upstream_diff.py Explicitly run everything with python3 3 years ago
gn gn: Call gn.bat in msysgit on Windows. 4 years ago
gn.bat Revert "Call python3.bat explicitly from gn.bat on Windows." 3 years ago
gn.py Use pylint 2.7 for depot_tools 3 years ago
goma_auth Reland "Reland "use python3 for goma related scripts"" 4 years ago
goma_auth.bat Set errorlevel in .bat wrappers on exit /b where appropriate. 3 years ago
goma_ctl Reland "Reland "use python3 for goma related scripts"" 4 years ago
goma_ctl.bat Set errorlevel in .bat wrappers on exit /b where appropriate. 3 years ago
gsutil.py Reland "Update gsutil to use gsutil version 4.68" 3 years ago
gsutil.py.bat Use python3 for gsutil bootstrapping 3 years ago
gsutil.vpython3 Reland "Update gsutil to use gsutil version 4.68" 3 years ago
led Add revert instructions 4 years ago
led.bat Add revert instructions 4 years ago
lockfile.py
luci-auth Add revert instructions 4 years ago
luci-auth.bat Add revert instructions 4 years ago
lucicfg Add revert instructions 4 years ago
lucicfg.bat Add revert instructions 4 years ago
mac_toolchain
metrics.README.md
metrics.py Explicitly run everything with python3 3 years ago
metrics_utils.py Explicitly run everything with python3 3 years ago
my_activity.py Use pylint 2.7 for depot_tools 3 years ago
ninja
ninja-linux32
ninja-linux64
ninja-mac
ninja.exe
ninjalog.README.md ninjalog_uploader: use goma_auth to detect googler 3 years ago
ninjalog_uploader.py [ninjalog uploader] Collect more android GN args 3 years ago
ninjalog_uploader_wrapper.py ninjalog_uploader: fix command for Windows 3 years ago
owners.py
owners_client.py
owners_finder.py Use pylint 2.7 for depot_tools 3 years ago
pinpoint Add revert instructions 4 years ago
pinpoint.bat Add revert instructions 4 years ago
post_build_ninja_summary.py
presubmit_canned_checks.py Improve canned checks output 3 years ago
presubmit_canned_checks_test.py Explicitly run everything with python3 3 years ago
presubmit_canned_checks_test_mocks.py Use pylint 2.7 for depot_tools 3 years ago
presubmit_support.py Increase presubmit --all speed (no diffs) by 100x 3 years ago
profile.xml
prpc Add revert instructions 4 years ago
prpc.bat Add revert instructions 4 years ago
pylint
pylint-1.5 Fix hangs when running pylint with py3 3 years ago
pylint-1.5.bat Add an option to specify pylint version 4 years ago
pylint-2.6 Fix hangs when running pylint with py3 3 years ago
pylint-2.6.bat Get pylint-2.6 to work under vpython3 on Windows. 4 years ago
pylint-2.7 Fix hangs when running pylint with py3 3 years ago
pylint-2.7.bat Add pylint-2.7 3 years ago
pylint.bat
pylint_main.py Explicitly run everything with python3 3 years ago
pylintrc
python_runner.sh
rdb Add revert instructions 4 years ago
rdb.bat Add revert instructions 4 years ago
rdb_wrapper.py Explicitly run everything with python3 3 years ago
repo repo: restore fstrings for Python 3.6 4 years ago
repo_launcher Explicitly run everything with python3 3 years ago
roll-dep
roll-dep.bat
roll_dep.py Explicitly run everything with python3 3 years ago
rustfmt.py [rust] [depot_tools] Minimal `rustfmt` support for `git cl format`. 3 years ago
scm.py Use pylint 2.7 for depot_tools 3 years ago
setup_color.py Explicitly run everything with python3 3 years ago
split_cl.py Explicitly run everything with python3 3 years ago
subcommand.py Use pylint 2.7 for depot_tools 3 years ago
subprocess2.py
swift-format Support git cl formatting for swift files 3 years ago
swift_format.py Support git cl formatting for swift files 3 years ago
update_depot_tools Print updating depot_tools in stderr 3 years ago
update_depot_tools.bat Set errorlevel in .bat wrappers on exit /b where appropriate. 3 years ago
update_depot_tools_toggle.py Indicate py3 compatibility for update_depot_tools_toggle.py 3 years ago
upload_metrics.py metrics: Report bot metrics if DEPOT_TOOLS_REPORT_BUILD is set 4 years ago
upload_to_google_storage.py Explicitly run everything with python3 3 years ago
utils.py Add a basic depot_tools version information 3 years ago
vpython Add revert instructions 4 years ago
vpython.bat Revert "Add VPYTHON_BYPASS support for vpython on Windows" 3 years ago
vpython3
vpython3.bat The python3 bin directory no longer needs to be added to PATH. 3 years ago
watchlists.py Explicitly run everything with python3 3 years ago
weekly Explicitly run everything with python3 3 years ago
whitespace.txt Change whitespace.txt 4 years ago
win32imports.py
wtf Explicitly run everything with python3 3 years ago
yapf Revert "Update vpython spec for yapf" 3 years ago
yapf.bat Run yapf with vpython3 4 years ago

README.md

depot_tools

Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or run ./update_depot_tools_toggle.py --disable.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.