Reason for revert:
This CL over-aggressively removed the Windows bootstrap code used by /gclient.bat, which in turn downloads/installs the Windows toolchain, including Python. Labs can no longer provision Windows bots because of this.
update_depot_tools.bat did more than initialize the virtualenv. It also downloaded and installed Python, Git, and Subversion on Windows systems.
I'm reverting to restore the toolchain so we can create new Windows bots.
Original issue's description:
> Removed virtualenv from depot_tools
>
> This effectively reverts http://crrev.com/1195423002 and
> http://crrev.com/1205873002.
>
> R=pgervais@chromium.org, tandrii@chromium.org
> TBR=pgervais@chromium.org # i wanna get my Fixit credit today :-)
> BUG=542922,503067
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=297491
TBR=pgervais@chromium.org,tandrii@chromium.org,sergiyb@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=542922,503067
Review URL: https://codereview.chromium.org/1431173002 .
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297493 0039d316-1c4b-4281-b951-d872f2087c98
Patch contributed by Leung Wing Chung <lwchkg@gmail.com>.
Committed on his behalf due to Commit Queue's mishandling of
CRLF files.
Here is my procedure for testing for a new install
1. Download and unzip
https://src.chromium.org/svn/trunk/tools/depot_tools.zip
Note that the path should include a space character,
e.g. "with a space"
2. Copy the three modified files to the unzipped folder
3. Convert the unzipped files into Windows CRLF.
4. REMOVE the following lines from update_depot_tools.bat
(Should I file a separate bug for this?)
:: Initialize/update virtualenv.
cd /d "%DEPOT_TOOLS_DIR%."
python -u bootstrap\bootstrap.py --deps_file bootstrap\deps.pyl --quiet ENV
if errorlevel 1 goto :EOF
5. Run gclient. Installation should be okay until
"git rebase" is run.
R=maruel@chromium.org
BUG=507301
Review URL: https://codereview.chromium.org/1232023004 .
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296275 0039d316-1c4b-4281-b951-d872f2087c98
The activate_end method is used in infra/bootstrap/build_deps.py, which doesn't
pass the value for this parameter.
R=pgervais@chromium.org
BUG=503067
Review URL: https://codereview.chromium.org/1213113002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295893 0039d316-1c4b-4281-b951-d872f2087c98
Thus solving the sh.exe problem once and for all...
R=hinoka@google.com, hinoka@chromium.org
BUG=383455, 241556, 389361, 380958
Review URL: https://codereview.chromium.org/372413002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@281844 0039d316-1c4b-4281-b951-d872f2087c98
This includes the new (fast) custom sh.exe/bash.exe/msys-1.0.dll.
R=hinoka@google.com, hinoka@chromium.org
BUG=383455,241556,389361,380958
Review URL: https://codereview.chromium.org/364133003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@281645 0039d316-1c4b-4281-b951-d872f2087c98
The previous rollout pushed the xp version of chromium git v4 to windows7. This rollout pushes the correct windows 7 version.
R=mmoss@chromium.org, szager@chromium.org
BUG=
Review URL: https://codereview.chromium.org/311713002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@274363 0039d316-1c4b-4281-b951-d872f2087c98
This will allow e.g. `git help rebase-update` to work.
R=agable@chromium.org
BUG=238428
Review URL: https://codereview.chromium.org/253243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@267038 0039d316-1c4b-4281-b951-d872f2087c98
There is now a separate XP-compatible release which doesn't have
the performance fix for index-pack.
BUG=
NOTRY=true
R=mmoss@google.com
Review URL: https://codereview.chromium.org/215133002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@260010 0039d316-1c4b-4281-b951-d872f2087c98
Also, allow multiple git installations to exist side-by-side.
This makes it easier to revert back to an old version quickly.
BUG=
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/203463004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@258058 0039d316-1c4b-4281-b951-d872f2087c98
If loaded first, Python can then be used to replace JS bootstrapping
logic if appropriate libs are already present in depot_tools.
BUG=328453
AUTHOR=techtonik@gmail.com
R=iannucci@chromium.org, maruel@chromium.org
Review URL: https://codereview.chromium.org/140183007
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257248 0039d316-1c4b-4281-b951-d872f2087c98
To force revert to the old git, and uninstall the new one, set:
DEPOT_TOOLS_GIT_1852=0
BUG=341967
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/156713005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250622 0039d316-1c4b-4281-b951-d872f2087c98
This is in preparation for once again making 1.8.5.2 the default Windows git.
Also remove the CHROME_HEADLESS condition, which confuses bot setup because the
same bot will sometimes run without that set (e.g. at slave startup) and with
it set (e.g. during a build), leading to the wrong, or even no, git installed.
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/160033002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250486 0039d316-1c4b-4281-b951-d872f2087c98
There are several bot failures, some understood, some not. This will revert
bots to the old git until all the failures can be investigated.
Users who want the new git can still install it with an explicit:
set DEPOT_TOOLS_GIT_1852=1
R=hinoka@google.com
Review URL: https://codereview.chromium.org/150203005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250239 0039d316-1c4b-4281-b951-d872f2087c98
The new git broke then XP bots because it relies on WinAPIs that are newer than
XP.
R=szager@chromium.org
Review URL: https://codereview.chromium.org/137213011
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250211 0039d316-1c4b-4281-b951-d872f2087c98
This can be overridden, and the old git installed, with:
set DEPOT_TOOLS_GIT_1852=0
rd /s /q git-1.8.5.2.chromium.1_bin git-1.8.0_bin
gclient
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/136693024
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250132 0039d316-1c4b-4281-b951-d872f2087c98
The new git will only be installed when DEPOT_TOOLS_GIT_1852=1, otherwise the
previous version will be installed.
BUG=322954
R=iannucci@chromium.org
Review URL: https://codereview.chromium.org/152043005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@249609 0039d316-1c4b-4281-b951-d872f2087c98
2.7.5 has bug http://bugs.python.org/issue17998 in re package that is affecting
the chromium team so it can't be used. The bug is fixed in 2.7.6.
This update still respects DEPOT_TOOLS_PYTHON_275=0. Since the name doesn't
represent what is being installed, it also respects
DEPOT_TOOLS_PYTHON_27=0.
R=iannucci@chromium.org
BUG=241769
Review URL: https://codereview.chromium.org/73013003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@235384 0039d316-1c4b-4281-b951-d872f2087c98
It may help when the directory is created at high integrity level.
This hypothesis is unconfirmed.
TBR=iannucci@chromium.org
BUG=241769,314257
Review URL: https://codereview.chromium.org/72803002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@235149 0039d316-1c4b-4281-b951-d872f2087c98
This will automatically upgrade python to 2.7.5 unless
set DEPOT_TOOLS_PYTHON_275=0
is used.
R=iannucci@chromium.org
BUG=241769
Review URL: https://codereview.chromium.org/53313002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@235140 0039d316-1c4b-4281-b951-d872f2087c98
This way, DEPOT_TOOLS_PYTHON_275=1 will properly upgrade an installation
still running 2.6. Otherwise the user had to "del python.bat" to force
the upgrade.
Stop calling python to verify it works, this is slow.
Upgrade url to https.
R=iannucci@chromium.org
BUG=241769
Review URL: https://codereview.chromium.org/26901003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@228179 0039d316-1c4b-4281-b951-d872f2087c98
- Python2.7.5 will be installed only if DEPOT_TOOLS_PYTHON_275=1,
otherwise 2.6 is installed.
- Eventually the default will be changed to install python 2.7.5
for new users.
- Afterward, python 2.7.5 will be always installed when not detected
and 2.6 will be ignored.
README.chromium contains the exact instructions how to recreate
python275_bin.zip that was committed independently.
I tested it on a vanilla Windows XP image and documented how to
install the VC90 CRT redistributable in that specific case in
README.chromium.
R=iannucci@chromium.org
BUG=241769,257696
Review URL: https://codereview.chromium.org/26326002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@227961 0039d316-1c4b-4281-b951-d872f2087c98
Until r200514 is merged into every active branches on Windows, python can't be
upgraded to 2.7.x.
TBR=iannucci@chromium.org,joi@chromium.org
BUG=241769
Review URL: https://codereview.chromium.org/15294005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@200800 0039d316-1c4b-4281-b951-d872f2087c98
page output. Rather than recreate the entire msysgit zip file and
for everyone to download it again, just modify git.bat in place.
TBR=maruel@chromium.org,cmp@chromium.org
Review URL: https://codereview.chromium.org/11358128
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166295 0039d316-1c4b-4281-b951-d872f2087c98
This CL adds pylint (and its dependencies) to third_party. It plumbs them into presubmit_canned_checks, and exposes a command-line tool to access pylint.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10447014
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@143016 0039d316-1c4b-4281-b951-d872f2087c98
In Windows (already worked correctly in posix): gclient wouldn't correctly update depot_tools when called.
Refactored away the bootstrap depot_tools update flow which only still existed in Windows.
Patch contributed by gab@chromium.orgR=maruel@chromium.org
BUG=
TEST=Running `gclient sync` from src/ and see depot_tools being correctly updated under a git depot_tools checkout.
Review URL: https://chromiumcodereview.appspot.com/9751009
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@132191 0039d316-1c4b-4281-b951-d872f2087c98
Set svn:eol-style=CRLF for all .bat files and everything in bootstrap/win/
Set svn:eol-style=LF for everything else.
Also delete depot_tools/git_cl/ since it's not used anymore.
Review URL: http://codereview.chromium.org/8055016
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@103051 0039d316-1c4b-4281-b951-d872f2087c98
sergiyb@chromium.org
dnj@google.com
maruel@chromium.org
akuegel@chromium.org
mmoss@chromium.org
scottmg@chromium.org
iannucci@chromium.org
iannucci@chromium.org
szager@chromium.org
mmoss@chromium.org
maruel@chromium.org
szager@google.com
chrisha@google.com
cmp@chromium.org