Commit Graph

2181 Commits (ff11329dfa87386ff1ec2eb6efd5026a770d8e11)
 

Author SHA1 Message Date
maruel@chromium.org 22879a7809 Fix git-cl quoting, yet again.
Using "%@" will correctly requote quoted arguments. Tested with repro case.
The fix in r232184 missed the necessary argument quoting.

R=iannucci@chromium.org
BUG=314192
BUG=241769

Review URL: https://codereview.chromium.org/47873010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@232501 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
maruel@chromium.org 4f4e76fce5 Reapply 231888 "Fixes for python 2.7.5 support." with fixes.
Tested to work now with the repro case of bug 313552.

"/c" was interpreted by cygwin's bash as a path and was replaced with c:/. :(
Using //c seems to be passed through properly.
There is probably other escaping problem but this should be good enough at
this stage.

Ref: http://www.mingw.org/wiki/Posix_path_conversion

R=iannucci@chromium.org
BUG=241769
BUG=313552

Review URL: https://codereview.chromium.org/50143013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@232184 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
maruel@chromium.org 566c38251a Update colorama from upstream to 5a3100113a3a.
This fixes license headers.

Interestingly, the pylint workaround at r133705 doesn't seem to be necessary
anymore.

R=stip@chromium.org
BUG=

Review URL: https://codereview.chromium.org/54603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@232152 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
maruel@chromium.org 7b6847f486 Revert r231888 "Fixes for python 2.7.5 support."
This broke git cl patch due to escaping. I tried removing the double quotes but
it didn't work out. Reverting in the meantime to unblock people until I figure
out a permanent way.

BUG=313552,241769
TBR=iannucci

Review URL: https://codereview.chromium.org/50293009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@232112 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
maruel@chromium.org b58876718d Fixes for python 2.7.5 support.
Fix the git-* wrapper scripts, PRESUBMIT.py and .gitignore.

The previous python wrapping scripts assumed python_bin\python.exe. This CL
modifies the wrapping scripts to use python.bat. This requires some quoting
magic and explicitly defer to cmd.exe.

This may break some cases where double quotes are used as arguments. We can't do
miracles on Windows.

R=iannucci@chromium.org
BUG=

Review URL: https://codereview.chromium.org/50563008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@231888 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
brettw@chromium.org ba63bcbe0f Add a platform filtering and executable setting abilities to download_from_google_storage.
Adds a command line flag --platform to control which platforms the given download occurs on.

Automatically marks downloads executable on non-Windows if the header x-goog-meta-executable is set. Automatically set this flag on upload when the executable bit is set.

BUG=233100

Review URL: https://codereview.chromium.org/42273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@231387 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
agable@chromium.org fd5b638293 Remove git_filter=True from git cache_dir commands.
This helps prevent timeout when checking out large repositories (like blink)
using the git cache_dir.

R=iannucci@chromium.org, maruel@chromium.org
BUG=295119

Review URL: https://codereview.chromium.org/43273005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@231111 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
digit@chromium.org d6ddc1cb9a Fix "git cl format" when newer clang-format version is installed.
Newer versions of clang-format-diff.py now require a -i flag to
explicitely apply edits, otherwise they just print a diff, which
make "git cl format" a no-op.

This patch fixes the issue by probing the script's help text to
see if the flag is needed. If it is, it is added automatically.

BUG=NONE
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/44263004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@231020 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
teravest@chromium.org d79d4b8e1b Make "git cl issue 0" idempotent.
Currently, running "git cl issue 0" in a client prints a confusing error
message if there's no issue assigned. This changes the code so that the issue
number isn't "unset" if it's not currently set.

BUG=

Review URL: https://codereview.chromium.org/32193016

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@230499 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
raphael.kubo.da.costa@intel.com 91507f76f8 gclient_utils: Fix call to sleep() after r229219.
sleep() is in time, not sys.

BUG=
R=maruel@chromium.org,szager@chromium.org,cmp@chromium.org

Review URL: https://codereview.chromium.org/34483004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@230108 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
szager@chromium.org 545260d272 Configure HOME for the gerrit process.
This prevents jgit from parsing the user's existing ~/.gitconfig,
which can skew test results.

BUG=

Review URL: https://codereview.chromium.org/27752003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@229245 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
szager@chromium.org f2d7d6b518 Consolidate subprocess retry logic into gclient_utils.
Add retry for all git operations that speak to a remote.  This
should smooth out issues with the git/gerrit-on-borg service.

Review URL: https://codereview.chromium.org/26234004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@229219 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
szager@chromium.org 8dce2c76ec Fix lint errors.
BUG=

Review URL: https://codereview.chromium.org/27756002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@229216 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
maruel@chromium.org e0fabd7414 Update upload.py from Rietveld @ 73805c4878a9.
TBR=stip@chromium.org
BUG=

Review URL: https://codereview.chromium.org/26937003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@229012 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
maruel@chromium.org 314877c2ac Add stip@ as depot_tools OWNER.
R=szager@chromium.org
BUG=

Review URL: https://codereview.chromium.org/27537004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@228989 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
szager@chromium.org b469623afd Add git/gerrit-on-borg utilities.
gob_util.py is a general-purpose library for communicating with the
gerrit-on-borg service.

testing_support/gerrit_test_case.py is a unittest framework for
testing code that interacts with gerrit.

R=vadimsh@chromium.org, cmp@chromium.org
BUG=

Review URL: https://codereview.chromium.org/26399002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@228965 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
kangil.han@samsung.com 71b1357747 Allow '.' in user name on gclient ssh connection
For example, my id is 'kangil.han', but it fails during parsing.
So this patch fixes it.

Review URL: https://codereview.chromium.org/27484002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@228937 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
qsr@chromium.org 1ef44afbb4 Adding --directory option to git cl patch
Review URL: https://codereview.chromium.org/27316002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@228926 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
phajdan.jr@chromium.org cef7236c80 GTTF: When faking urllib2.HTTPError use int type for HTTP error code
This makes exception catching code which compares the code with
numeric values work as expected. pythonis not PHP and 500 != '500'.

BUG=none

Review URL: https://codereview.chromium.org/27260007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@228788 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
borenet@google.com 2d1ee9ec79 Add support in gclient for pre-DEPS hooks
These are run for a given dependency after it has been synced but before its
DEPS have been synced. This will help to switch Chromium to depend on Skia's
git repository (skia:1638).

Review URL: https://codereview.chromium.org/25322002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@228651 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
scheib@chromium.org 93276ab22e Suggest interactive owners tool when suggesting owners.
Review URL: https://codereview.chromium.org/27269002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@228565 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
maruel@chromium.org 4d3ed59ab7 Redo the python check to look for the directories too.
This way, DEPOT_TOOLS_PYTHON_275=1 will properly upgrade an installation
still running 2.6. Otherwise the user had to "del python.bat" to force
the upgrade.

Stop calling python to verify it works, this is slow.

Upgrade url to https.

R=iannucci@chromium.org
BUG=241769

Review URL: https://codereview.chromium.org/26901003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@228179 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
phajdan.jr@chromium.org c2f94e78a5 GTTF: Retry on flaky SSL "EOF occurred in violation of protocol" errors.
BUG=none

Review URL: https://codereview.chromium.org/26913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@227982 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
maruel@chromium.org ca4fdfd874 Add python 2.7.5 support on Windows. Not enabled by default.
- Python2.7.5 will be installed only if DEPOT_TOOLS_PYTHON_275=1,
  otherwise 2.6 is installed.
- Eventually the default will be changed to install python 2.7.5
  for new users.
- Afterward, python 2.7.5 will be always installed when not detected
  and 2.6 will be ignored.

README.chromium contains the exact instructions how to recreate
python275_bin.zip that was committed independently.

I tested it on a vanilla Windows XP image and documented how to
install the VC90 CRT redistributable in that specific case in
README.chromium.

R=iannucci@chromium.org
BUG=241769,257696

Review URL: https://codereview.chromium.org/26326002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@227961 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
thakis@chromium.org c1c963566a Remove references to sconsbuild.
scons hasn't been used in a long time.

Also remove support for using make on Mac, it's no longer supported. All bots
that were using make on mac are using ninja these days.

BUG=305702

Review URL: https://codereview.chromium.org/26672003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@227778 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
sbc@chromium.org a9f824da03 Fix ninja wrapper script on non-x86 linux.
The script would previously attempt to run
the x86_32 version of ninja on 32-bit arches
such as mips and arm rather than display the
error message.

This error showed up an ARM builder:
/mnt/data/b/depot_tools/ninja: line 25: /mnt/data/b/depot_tools/ninja-linux32: cannot execute binary file

Review URL: https://codereview.chromium.org/26490004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@227549 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
stuart@fivemicro.com 4fa02461be Don't update git url if 'read' times out
Previous code checked the exit status of 'echo' instead of 'read' to
determine if the 'read' command had timed out.

TEST=Create a mirror of depot_tools.git, git clone it, then run
./update_depot_tools, see prompt for changing the URL, wait at
least 60 seconds and verify that you get the timeout message.

R=maruel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/25110004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@227427 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
dbeam@chromium.org 49fb93c149 Remove --milestone to force engineers to double-check with TPMs for branch number.
BUG=304943

Review URL: https://chromiumcodereview.appspot.com/26280004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@227348 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
rmistry@google.com bb050f61d4 Make checkout.GitCheckout usable from apply_issue
BUG=chromium:303433

Review URL: https://chromiumcodereview.appspot.com/25853003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@226774 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
rmistry@google.com 11145db693 Return unicode commit hashes in checkout.GitCheckout.
The motivation for this CL is:
When a project is turned on to use GitCheckout with try job verifiers, then the CQ crashes because of line 64 in http://src.chromium.org/viewvc/chrome/trunk/tools/commit-queue/pending_manager.py

This is because revision can only be one of (None, int, unicode). This crash only happens when try jobs are used (which is why I did not see it before).
This CL changes the return type to be unicode instead of string.

Review URL: https://chromiumcodereview.appspot.com/25686005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@226743 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
marq@chromium.org e5e5900f49 Fix spelling error in help text.
BUG=

Review URL: https://chromiumcodereview.appspot.com/25808003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@226611 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
szager@chromium.org 86c497d8db Indicate when depot_tools can't be updated on Windows.
When depot_tools fail to update right now all you get is
    Cannot rebase: You have unstaged changes.
    Please commit or stash them.
As that is typically in a call to gclient it's far from obvious what
could not be updated so add a line saying
    Failed to update depot_tools.
to that. Linux and Mac already have a similar error message in their
script file.

BUG=
R=szager@chromium.org

Review URL: https://codereview.chromium.org/23619058

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@226002 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
tyoshino@chromium.org 99918abbe7 Ignore CC_LIST when private flag is specified.
This prevents private CLs to be automatically CC-ed to public mailing lists
unintentionally.

Review URL: https://chromiumcodereview.appspot.com/24257014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@225925 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
thestig@chromium.org 8d65ab6f97 Update Linux ninja binaries to not require GLIBC_2.14.
BUG=298725
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/24919002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@225756 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
phajdan.jr@chromium.org de9c675a9b Always convert flag value to string in set_flag
The callee needs it to be a string so that it can be made
part of HTTP request. However, in code using Rietveld
it's useful to use non-string types for flags where
Rietveld actually doesn't return strings (say booleans).

One example is the commit flag, which is a boolean.

BUG=291335

Review URL: https://chromiumcodereview.appspot.com/24846002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@225748 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
scottmg@chromium.org f547c80c36 Delete nag_max and nag_timer
It's impossible to sync by default on Windows and has been since this was
added: https://www.google.com/search?q=chromium-dev+nag_max

Most recently: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/CEpATyu9udc

So, remove it. If someone needs it they can figure out a more targeted
implementation.

Keep --no-nag-max for backwards compat so that bot scripts won't fail out.
I'll remove it from bot scripts after this has baked a while, and then
come back and remove the option.

R=iannucci@chromium.org

Review URL: https://chromiumcodereview.appspot.com/24950002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@225730 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
adam.treat@samsung.com 16d2ad682e Add a flag for clang-format that instructs the tool to strip 0 leading slashes from the file names.
I have clang-format-3.3 installed and it appears to default to stripping one leading slash.

BUG=294188

Review URL: https://chromiumcodereview.appspot.com/24217002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@225705 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
sbc@chromium.org 87b9bf026a Add 'git cl diff' command.
This command shows the differences between local branch
and the last patch uploaded to rietveld. The idea being
that you can see what would be uploaded before you actually
upload.

This can useful when using 'git cl patch' to move changes
between checkouts and working from more than one machine at
once.

Review URL: https://chromiumcodereview.appspot.com/24276008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@225552 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
mmoss@chromium.org 77bd7360ab Don't allow 'detached head' branch creation to fail.
This fixes an error if the branch already exists.

Review URL: https://chromiumcodereview.appspot.com/24360009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@225278 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
chrisphan@chromium.org a7893f5989 Fix uploading binary files to rietveld.
httplib chokes on concatenating the unicode string "url" and some bytecode in "data".

BUG=169600

Review URL: https://chromiumcodereview.appspot.com/24172008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@225058 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
iannucci@chromium.org 2702bcdec7 Add json output for gclient.
This is in order to support 'features' like got_revision for build systems
unwilling to scrape the human-readable output of gclient in order to extract
basic information :)

R=agable@chromium.org, maruel@chromium.org
BUG=265618

Review URL: https://chromiumcodereview.appspot.com/23753008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@225046 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
phajdan.jr@chromium.org c7a9efad97 GTTF: Add ReadOnlyRietveld similar to one currently in CQ codebase.
This will replace the CQ one and allow it to stay in sync with Rietveld.

For now I've only covered methods that CQ seems to touch.

BUG=291335

Review URL: https://chromiumcodereview.appspot.com/24095007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@224455 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
cyrille@nnamrak.org ef509e48b1 Added SafeRename to better handle problems with git processes locking directories.
This solves a problem with "os.rename" sometimes failing with an
exception after cloning a dependency to a temporary directory. It's
possible the dying git processes still hold a handle to the directory.
Since gclient delete the temporary directory regardless of the success
of the process, it results in a lot of GB downloaded for nothing.

SafeRename solves this by retrying a few times if the renaming fails,
sleeping one second every time to get other processes the time to
release their lock on the directory. It gives up retrying after 15 times.

BUG=
R=maruel@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23875041

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@224372 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
ikarienator@chromium.org faf3fdf736 An interactive tool to help find owners covering current change list.
BUG=77248

Review URL: https://chromiumcodereview.appspot.com/12712002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@224264 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
hinoka@google.com 8b3cad72ec Print gsutil error message when we enconter as 403 or 404
We appear to be getting 403's when encountering errors other than mismatched
credentials.  The error message was originally hidden to avoid clutter, but it
has become obvious that there are other transient errors hidden behind a 403.

This change prints the original gsutil error message regardless of whether or not
we enconter a 403 or 404.


BUG=

Review URL: https://chromiumcodereview.appspot.com/23484061

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@224195 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
dpranke@chromium.org 31b42c0192 Change the "Missing OWNERS" presubmit check to only suggest owners for missing files.
Previously we would suggest owners for the whole CL, rather than just
the files currently missing owner approval.

R=maruel@chromium.org
BUG=130978

Review URL: https://chromiumcodereview.appspot.com/23591064

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@224183 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
maruel@chromium.org 2a08269234 Update upload.py at b7cdf3e63c5e.
R=iannucci@chromium.org
BUG=23608

Review URL: https://chromiumcodereview.appspot.com/24135003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@224175 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
thakis@chromium.org 7af54a17f7 Update ninja to v1.4.0 on Mac, Linux32, Linux64, Windows.
See the bug for how these were built.

The linux binaries were built by thestig@chromium.org. 
The windows binary was built by scottmg@chromium.org. 
The mac binary was built by thakis@chromium.org 

This will hopefully fix http://crbug.com/247311

BUG=289947, 247311
Review URL: https://codereview.chromium.org/23523059/



git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@222974 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
szager@chromium.org 7d51b4faa8 Turn off gerrit emails.
BUG=
R=vadimsh@chromium.org

Review URL: https://codereview.chromium.org/23851027

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@222830 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
agable@chromium.org 42c2079a1e Fix R= line rewriter to handle TBRs well.
R=maruel@chromium.org, thakis@chromium.org
BUG=253589

Review URL: https://chromiumcodereview.appspot.com/23072039

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@222801 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago