This change includes commits:
00e23cbde55df05e0e42f7a574c79ff8bcf589c4 vpython: match tag before verify
Bug:1501997
Change-Id: Ibabde88c588a830707bf14be7e2998fa4b4152fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5065788
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Chenlin Fan <fancl@chromium.org>
This is a reland of https://crrev.com/c/4719827
- Fixed the issue for cipd wrapper. Now all environment variables should
be perserved when invoking cipd: https://crrev.com/c/4669637
- Isolate python when creating virtualenv: https://crrev.com/c/4780372
1. virtualenv field in the spec is ignored.
2. --vpython-tool removed support for delete and help subcommands.
3. --vpython-tool installed removed support for naming venv.
4. removed support for -vpython-interpreter.
5. removed support for searching interpreters in host PATH.
6. python 2.7 is available only if the binary is invoked as `vpython`.
7. fixed a bug that passes invalid vpython arguments to the script,
which may be silently ignored.
8. python_version in the vpython_spec must specify a minor version
(python_version: "3" is not valid anymore).
9. vpython now requires the cipd binary to be present in PATH, which is
true already when using Swarming or depot_tools.
Bug: 1415212
Change-Id: I05fddbb10c7c9bcfa6f5390710fab28fe8d89131
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4844251
Commit-Queue: Chenlin Fan <fancl@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
To keep in sync with buildbucket
Change-Id: If48871870748d91a859e395f290b7b0d5d3b0c4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4823715
Reviewed-by: Yuanjun Huang <yuanjunh@google.com>
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Randy Maldonado <randymaldonado@google.com>
This reverts commit 43083529de.
Reason for revert: crbug.com/1470122
Original change's description:
> New vpython to depot_tools
>
> This is a reland of https://crrev.com/c/4653897
> Fixed the issue for cipd wrapper. Now all environment variables should
> be perserved when invoking cipd: https://crrev.com/c/4669637
>
> 1. virtualenv field in the spec is ignored.
> 2. --vpython-tool removed support for delete and help subcommands.
> 3. --vpython-tool installed removed support for naming venv.
> 4. removed support for -vpython-interpreter.
> 5. removed support for searching interpreters in host PATH.
> 6. python 2.7 is available only if the binary is invoked as `vpython`.
> 7. fixed a bug that passes invalid vpython arguments to the script,
> which may be silently ignored.
> 8. python_version in the vpython_spec must specify a minor version
> (python_version: "3" is not valid anymore).
> 9. vpython now requires the cipd binary to be present in PATH, which is
> true already when using Swarming or depot_tools.
>
> Also updates the LUCI_OWNERS to add peep-software-deploy team.
>
> Bug:1415212
> Change-Id: Ie541a2a60bef829a976a13db9a6732b406c4d878
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4719827
> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
> Auto-Submit: Chenlin Fan <fancl@chromium.org>
> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Bug: 1415212
Change-Id: I6ca32066acd977a293f8b8f42697c383cc2a93fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4751179
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Chenlin Fan <fancl@chromium.org>
This is a reland of https://crrev.com/c/4653897
Fixed the issue for cipd wrapper. Now all environment variables should
be perserved when invoking cipd: https://crrev.com/c/4669637
1. virtualenv field in the spec is ignored.
2. --vpython-tool removed support for delete and help subcommands.
3. --vpython-tool installed removed support for naming venv.
4. removed support for -vpython-interpreter.
5. removed support for searching interpreters in host PATH.
6. python 2.7 is available only if the binary is invoked as `vpython`.
7. fixed a bug that passes invalid vpython arguments to the script,
which may be silently ignored.
8. python_version in the vpython_spec must specify a minor version
(python_version: "3" is not valid anymore).
9. vpython now requires the cipd binary to be present in PATH, which is
true already when using Swarming or depot_tools.
Also updates the LUCI_OWNERS to add peep-software-deploy team.
Bug:1415212
Change-Id: Ie541a2a60bef829a976a13db9a6732b406c4d878
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4719827
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Chenlin Fan <fancl@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
This reverts commit ae21f6a5ec.
Reason for revert: crbug.com/1462502#c11
Original change's description:
> New vpython to depot_tools
>
> 1. virtualenv field in the spec is ignored.
> 2. --vpython-tool removed support for delete and help subcommands.
> 3. --vpython-tool installed removed support for naming venv.
> 4. removed support for -vpython-interpreter.
> 5. removed support for searching interpreters in host PATH.
> 6. python 2.7 is available only if the binary is invoked as `vpython`.
> 7. fixed a bug that passes invalid vpython arguments to the script,
> which may be silently ignored.
> 8. python_version in the vpython_spec must specify a minor version
> (python_version: "3" is not valid anymore).
> 9. vpython now requires the cipd binary to be present in PATH, which is
> true already when using Swarming or depot_tools.
>
> Also updates the LUCI_OWNERS to add peep-software-deploy team.
>
> Bug:1415212
> Change-Id: I295c1aad1516a0c36eefa2ae04e85cabb518bda8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4653897
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Chenlin Fan <fancl@chromium.org>
Bug: 1415212
Change-Id: I3d00edf7d2a0d61d30b263362d35704d9f63a44d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4668482
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
1. virtualenv field in the spec is ignored.
2. --vpython-tool removed support for delete and help subcommands.
3. --vpython-tool installed removed support for naming venv.
4. removed support for -vpython-interpreter.
5. removed support for searching interpreters in host PATH.
6. python 2.7 is available only if the binary is invoked as `vpython`.
7. fixed a bug that passes invalid vpython arguments to the script,
which may be silently ignored.
8. python_version in the vpython_spec must specify a minor version
(python_version: "3" is not valid anymore).
9. vpython now requires the cipd binary to be present in PATH, which is
true already when using Swarming or depot_tools.
Also updates the LUCI_OWNERS to add peep-software-deploy team.
Bug:1415212
Change-Id: I295c1aad1516a0c36eefa2ae04e85cabb518bda8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4653897
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Chenlin Fan <fancl@chromium.org>
This would add support for uploading/installing Xcode with MacOS13 adoption
Bug: 1441931
Change-Id: I81e8edc0761548b6650535f3ac6b6c504673e6a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4532378
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Yue She <yueshe@google.com>
Fixes issue where reclient erroneously shutdown during startup via
bootstrap.
BUG=b:269549741
TEST=Run bootstrap locally using the new version specified in this
change.
Change-Id: Ic443ba48d4d976a5341847bd7855e7d7fb63cc61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4445369
Commit-Queue: Eric Lok <lokeric@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Eric Lok <lokeric@google.com>
Adding back reclient to depot tools. This will allow it to be used for
chromeos-chrome builds, and other packages in the future as well
Bug: b/270080866, b/242680623
Change-Id: Ibb800a7c36f61312d540ee5595c585493e5e3578
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4273546
Commit-Queue: Eric Lok <lokeric@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Fixed issue where token to paste was refreshing fast and made it difficult to copy in terminal emulators such as Alacritty and Konsole.
Bug:1411481, 1406354
Change-Id: I260c18c4aca873530d7ead55ab8826b01edffd9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4231602
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Camilo Jacomet <cjacomet@google.com>
This is a minor patch that will fix the error that arises from having no config file when running lucicfg valdate.
Bug:1412186
Change-Id: Ie7432354d382fa88b45d1668e6d6476d2530898c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4226560
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Riley Wong <rgw@google.com>
Auto-Submit: Riley Wong <rgw@google.com>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Version updates lucicfg fmt/validate/lint to add conditional formatting rules based off path.
Change-Id: I0870c142210f95e75356ef2cc9d94f4e265f8c80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4215131
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Riley Wong <rgw@google.com>
Per go/oauth-oob-deprecation we are switching to go/luci-cli-oauth-login updating the packages that use luci-auth.
Bug:1406354
Change-Id: I3fc0fd2cc88d395f28e080d90aaaaae672c33da0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4195020
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Leina Sun <sunxiaodi@google.com>
Commit-Queue: Camilo Jacomet <cjacomet@google.com>
Reviewed-by: Sean McCullough <seanmccullough@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
triggered_by in CQ configs has now not been used by any projects
for a month. This is a deprecated property that we don't
support anymore in CV.
location_regexp and location_regexp_exclude has been replaced by location_filters and is not used in any projects any more.
Related buildbucket config change at
https://chrome-internal-review.googlesource.com/c/infradata/config/+/5229868
Bug: 1395209
Change-Id: I4e53606c8bcd7a784970beb337984a808321c5a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4113683
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
This reverts commit fa0a108281.
Reason for revert: Creating a null pointer issue
Original change's description:
> Updating Lucicfg V 1.35.0 to 1.35.1
>
> Version updates a bug where lucicfg fmt was erroring out on sentinel when it should safely continue
>
> Change-Id: Ic62d82176b4c9b8ded139338c7742a2b0cbe56a4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4072884
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Riley Wong <rgw@google.com>
Change-Id: I47c56e110f0b3acc2011fa0c169d979297856a3c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4072086
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Riley Wong <rgw@google.com>
Version updates a bug where lucicfg fmt was erroring out on sentinel when it should safely continue
Change-Id: Ic62d82176b4c9b8ded139338c7742a2b0cbe56a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4072884
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Riley Wong <rgw@google.com>
Including this change:
https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/3777409
This was tried before, but didn't stick because legacy CQ doesn't
handle location_filters; now almost all projects are migrated to CV.
Bug: 1171945
Change-Id: I6a5734922973dd8b506dc018d8838a6f2dacd271
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3965089
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Auto-Submit: Quinten Yearsley <qyearsley@chromium.org>
Changes in this release:
55ee5cd215996e99b807bd19060f8c6845423985 Switch to a buffered channel.
c18f898c8628f7063328a553de31b5a13ebbd47a Fix comment typos.
c55184b5835c789d073ce8ba10745cc7efedcd65 Fix typo
50e0d6a61bf2706e8096a4c3785331f2fa1f2bad Fix some warnings that are causing presubmit errors for the 2.7 fork.
39ca9cb80c0c7f5a18bcdcc6ce65bfdb1cc64879 Update vpython deployment doc
c93fd3c5ebdc3999eea86a7623dbd1ed4b40bc78 Roll chromiumos/config manually to fix the broken roller
149a1934123a29ca32c85f73597e7ffbfa7dbf4a Add initial PRESUBMIT support for linting python3
Change-Id: I1155342ace04e2944a9abe531e0f8b5d0206a0eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3951269
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Brian Ryner <bryner@google.com>
This will be used in ChromeOS build_packages.
Bug: b/242680623, b/203606263
Change-Id: I3eedec7b245405c24091db43a450181a270d1305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3833266
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Chan Li
Ricardo Ribalda
Chenlin Fan
Yiwei Zhang
Jeff Yoon
Junji Watanabe
Takuto Ikuta
Yue She
Vadim Shtayura
Camilo Jacomet
Fumitoshi Ukai
Yoshiki Iguchi
Robert Iannucci
Eric Lok
Patrick Meiring
randymaldonado
Scott Lee
Riley Wong
Richard Wang
Leina Sun
Brian Ryner
Quinten Yearsley
Weiwei Lin
Yuanjun Huang
Allen Xie
Zhaoyang Li
Roberto Carrillo-Navarrete
Philipp Wollermann