This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/4194868d9f0bf2e8f8fc86198a01ebfbfe0f6164 Fix gerrit tryproperties to be more realistic. (tandrii@chromium.org)
R=phajdan@chromium.org,martiniss@chromium.org,tandrii@chromium.org
BUG=604735
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Review URL: https://codereview.chromium.org/1910753003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300078 0039d316-1c4b-4281-b951-d872f2087c98
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/ecf8b481c75c1b1d43a2d7c80ea57c38cca6e9a7 Fix Gerrit tryserver properties test_data. (tandrii@chromium.org)
R=phajdan@chromium.org,tandrii@chromium.org
BUG=604735
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Review URL: https://codereview.chromium.org/1912663002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300076 0039d316-1c4b-4281-b951-d872f2087c98
Without this change, the extracted directory could be missing but
the downloaded file could match the hash, and in turn
download_from_google_storage will not download the file and will
not extract it, and any tools depending on the extracted
directory will fail.
Review URL: https://codereview.chromium.org/1904483002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300051 0039d316-1c4b-4281-b951-d872f2087c98
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/c55462b5c2458036648d53e6a4d923a63ed8b7cc Add tryserver_gerrit test properties. (tandrii@chromium.org)
R=phajdan.jr@chromium.org,martiniss@chromium.org,tandrii@chromium.org
BUG=604735
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Review URL: https://codereview.chromium.org/1907473002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300038 0039d316-1c4b-4281-b951-d872f2087c98
Before, for the common case that the actual_merge_base was already set
as base, the check for is_ancestor(base, actual_merge_base) would have
caused the base to be re-set.
This is a writing operation, which causes trouble e.g. for the parallel
operation of 'git cl status'.
R=iannucci@chromium.org, tandrii@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1888213004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300003 0039d316-1c4b-4281-b951-d872f2087c98
Gerrit doesn't allow arbitrary non-member emails for now,
thus removign this feature until either Gerrit allows it,
or we have a per-repo opt-in way.
TBR=andybons@chromium.org
BUG=604377
Review URL: https://codereview.chromium.org/1895863002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299988 0039d316-1c4b-4281-b951-d872f2087c98
git config key should consist of alphanumeric characters and '-'.
The underscore '_' is not allowed. So we're getting 'invalid key' error
when GERRIT_SKIP_ENSURE_AUTHENTICATED is set.
Let's use '-' instead of '_'.
BUG=603378
Review URL: https://codereview.chromium.org/1882833005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299952 0039d316-1c4b-4281-b951-d872f2087c98
Adding this line to codereview.settings should do the trick:
GERRIT_SKIP_ENSURE_AUTHENTICATED: true
And I also cleaned up tests so they don't spill too much to stdout.
BUG=603378
R=machenbach@chromium.org,andybons@chromium.org
CC=shinyak@chromium.org
Review URL: https://codereview.chromium.org/1884173003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299926 0039d316-1c4b-4281-b951-d872f2087c98
Reason: so I can not lgtm/revert anything which doesn't come with
more tests.
R=iannucci@chromium.org,dpranke@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1873403004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299921 0039d316-1c4b-4281-b951-d872f2087c98
Checks creds before uploading and running presubmit, generalizing
the case of Rietveld. If they are missing, suggests a URL to
generate them.
R=andybons@chromium.org,phajdan.jr@chromium.org
BUG=583153
Review URL: https://codereview.chromium.org/1882583003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299883 0039d316-1c4b-4281-b951-d872f2087c98
Namely these errors when applying patch:
<urlopen error [Errno 10060] A connection attempt failed
because the connected party did not properly respond after
a period of time, or established connection failed because
connected host has failed to respond>
<urlopen error [Errno 104] Connection reset by peer>
R=sergiyb@chromium.org,phajdan.jr@chromium.org
BUG=601260
Review URL: https://codereview.chromium.org/1876093002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299837 0039d316-1c4b-4281-b951-d872f2087c98
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
R=
BUG=
TBR=martiniss@chromium.org
Review URL: https://codereview.chromium.org/1880503003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299830 0039d316-1c4b-4281-b951-d872f2087c98
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
R=
BUG=
TBR=martiniss@chromium.org
Review URL: https://codereview.chromium.org/1869323002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299794 0039d316-1c4b-4281-b951-d872f2087c98
CMDupdate and CMDsync have different option parsers, which means they pass
different options objects to the same underlying code!
R=agable@chromium.org, dnj@chromium.org, smut@chromium.org
BUG=601564
Review URL: https://codereview.chromium.org/1869593004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299777 0039d316-1c4b-4281-b951-d872f2087c98
Reported in https://codereview.chromium.org/1852803002/#msg5.
Also some cleanup in nearby code AND fix of the git cl diff's previous behavior that actually updated local branch config with latest *uploaded* CL values.
BUG=579182
R=machenbach@chromium.org,andybons@chromium.org
CC=servolk@chromium.org
Review URL: https://codereview.chromium.org/1871463003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299759 0039d316-1c4b-4281-b951-d872f2087c98
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
R=
BUG=
TBR=martiniss@chromium.org
Review URL: https://codereview.chromium.org/1861693004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299743 0039d316-1c4b-4281-b951-d872f2087c98
This will clean up index.lock and refs/heads/master.lock-style locks when
invoked as part of the update_scripts step on the bots.
R=dpranke@chromium.org, estaab@chromium.org, pgervais@chromium.org
BUG=421769
Review URL: https://codereview.chromium.org/1862943002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299737 0039d316-1c4b-4281-b951-d872f2087c98
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
R=
BUG=
TBR=martiniss@chromium.org
Review URL: https://codereview.chromium.org/1865863002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299724 0039d316-1c4b-4281-b951-d872f2087c98
Avoid to call git reset --soft to preserve current revision to
FETCH_HEAD. 'got_revision' property would also be that from
FETCH_HEAD.
BUG=596787
Review URL: https://codereview.chromium.org/1837453002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299721 0039d316-1c4b-4281-b951-d872f2087c98
In theory this shouldn't fire if gsutil is running without a tty (ie, in a subprocess).
In practice we're still seeing processes hang because it still thinks it's in a tty
This should in theory disable the prompt for good
BUG=577325,576979
Review URL: https://codereview.chromium.org/1587793002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299714 0039d316-1c4b-4281-b951-d872f2087c98
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must commit the change manually.
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
R=
BUG=
TBR=martiniss@chromium.org
Review URL: https://codereview.chromium.org/1860913002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299692 0039d316-1c4b-4281-b951-d872f2087c98