The bash command "local myvar=$(mycommand)" has the exit status of the
bash builtin "local" rather than the exit status of mycommand. To get
the exit status of mycommand, "local myvar" should be run separately
on a previous line.
Review URL: https://chromiumcodereview.appspot.com/11308129
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@169446 0039d316-1c4b-4281-b951-d872f2087c98
Currently, if an unversioned directory is present where we would expect
a versioned repository to be, the following error is printed:
Can't update/checkout %s if an unversioned directory is present.
Delete the directory and try again.
If --reset and --delete_unversioned_trees are used, gclient should delete
the unversioned directory in this case.
This problem can be reproduced using the following recipe:
$ rm -rf src/third_party/webrtc/.svn
$ gclient sync -nRftD
BUG=none
TEST=Verify that above error is fixed. Run all smoke tests.
Review URL: https://chromiumcodereview.appspot.com/11366239
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@167942 0039d316-1c4b-4281-b951-d872f2087c98
Turning off could be interpreted as having a lasting impact instead of just being a notice for the current run.
Review URL: https://chromiumcodereview.appspot.com/11359168
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@167476 0039d316-1c4b-4281-b951-d872f2087c98
Not all developers have =~ support in bash, apparently.
Switching to standard globbing.
R=tapted
TBR=maruel
Review URL: https://codereview.chromium.org/11369147
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166867 0039d316-1c4b-4281-b951-d872f2087c98
Otherwise the try slaves run the hooks twice, once in the apply_issue, another
in the runhooks step. It is unnecessary. It will reduce the problem with
apply_issue timeouts.
TBR=xusydoc@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/11362176
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166826 0039d316-1c4b-4281-b951-d872f2087c98
In an effort to make some local commands faster, I propose we
exclude them from network dependent update step.
R=maruel@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/11312143
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166793 0039d316-1c4b-4281-b951-d872f2087c98
This causes an excepiton on Windows,
File "E:\b\depot_tools\subprocess2.py", line 341, in communicate
TypeError: Using timeout and shell simultaneously will cause a process leak
since the shell will be killed instead of the child process.
TBR=petermayo@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/11368148
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166732 0039d316-1c4b-4281-b951-d872f2087c98
svn commit likes to hang indefinitely whenever the svnserve server forgets
about the client. This changes ensures the commit queue won't be blocked by
this problem.
Add --quiet to the git fetch command but do not capture anymore.
R=petermayo@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/11358165
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166725 0039d316-1c4b-4281-b951-d872f2087c98
apply_issue step hangs and the output is often in the reverse order. This CL is
to help diagnose the problem.
TBR=cmp@chromium.org
BUG=159868
Review URL: https://chromiumcodereview.appspot.com/11359093
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166505 0039d316-1c4b-4281-b951-d872f2087c98
page output. Rather than recreate the entire msysgit zip file and
for everyone to download it again, just modify git.bat in place.
TBR=maruel@chromium.org,cmp@chromium.org
Review URL: https://codereview.chromium.org/11358128
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166295 0039d316-1c4b-4281-b951-d872f2087c98
/usr/local/google/home/gspencer/depot/depot_tools/git-cl: line 22:
/usr/local/google/home/gspencer/depot/depot_tools/git-cl/git_cl.py: Not a directory
/usr/local/google/home/gspencer/depot/depot_tools/git-cl: line 22: exec:
/usr/local/google/home/gspencer/depot/depot_tools/git-cl/git_cl.py: cannot execute: Not a directory
TBR=szager@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/11366117
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166274 0039d316-1c4b-4281-b951-d872f2087c98
This is unfortunately imperfect in a number of ways:
* Needs to get info from git commits, so needs a local WebKit git repo, and an explicit option to find it.
* Bugzilla doesn't return nearly as much information as other bug servers, and individual issues would have to be hit (and parsed) to get it.
* Searching for comments includes any issue ever commented on that was changed over the time period requested, so may have false positives.
* Reviews themselves can't be searched from Bugzilla, so can only be detected as "reviews" once landed and "issues" until then.
BUG=158993
Review URL: https://chromiumcodereview.appspot.com/11365078
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166100 0039d316-1c4b-4281-b951-d872f2087c98
Added checks:
- Block upload of a diff from sha not in current branch
(this includes tracking against an unrebased local master)
- Block upload of a diff containing shas from origin/master
(should never happen)
- Use explicit calls to git merge-base instead of calling git diff
with "<branch>..." which implicitly uses merge-base.
BUG=157503
Review URL: https://chromiumcodereview.appspot.com/11262057
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@165887 0039d316-1c4b-4281-b951-d872f2087c98
This allows specificying that a target OS list should override the base
list instead of adding to it. This is useful for iOS builds, where the
desired behavior is to pull only the iOS deps, not the union of the Mac
and iOS deps.
Review URL: https://chromiumcodereview.appspot.com/11363036
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@165671 0039d316-1c4b-4281-b951-d872f2087c98
TEST=`~/src/depot_tools/ninja --version` works when depot_tools isn't in PATH
Review URL: https://chromiumcodereview.appspot.com/11366044
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@165510 0039d316-1c4b-4281-b951-d872f2087c98
If the keyring password doesn't work on the first try, it probably won't
work on the second or third. The KeyringCreds object already supports
this, we just were recreating the object at each step.
Also, if after three tries authentication to code.google.com still
fails, then the script should continue and just use un-authenticated
access to code.google.com.
BUG=158388
Review URL: https://chromiumcodereview.appspot.com/11340023
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@165446 0039d316-1c4b-4281-b951-d872f2087c98
Rearrange some of the pipe redirections to avoid crashing on Windows.
TBR=cmp@chromium.org
Review URL: https://codereview.chromium.org/11260036
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@164140 0039d316-1c4b-4281-b951-d872f2087c98
These calculations were not dropping the time from the provided date.
And so a week would be Monday 11AM to Monday 11AM when run at 11AM.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11233041
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@163360 0039d316-1c4b-4281-b951-d872f2087c98
Ensure the gcl change directory is created when gcl was never used by itself but
used through trychange.py
R=nsylvain@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/11193040
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@162769 0039d316-1c4b-4281-b951-d872f2087c98
Found to be particularly helpful in writing snippets.
This tool looks up all activity for a particular user across many
different services. It looks up changes and reviews across various
Rietveld and Gerrit instances and looks up issues in various google code
projects.
Running with no arguments will look up activity of $USER over the
current week (last week on Monday). I.e. the primary use case is for
looking up your activity for writing snippets.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11140010
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@162561 0039d316-1c4b-4281-b951-d872f2087c98
enne@chromium.org
newt@chromium.org
ilevy@chromium.org
bauerb@chromium.org
davidjames@chromium.org
scheib@chromium.org
maruel@chromium.org
szager@google.com
sivachandra@chromium.org
stuartmorgan@chromium.org
thakis@chromium.org
cjhopman@chromium.org
ukai@chromium.org
dpranke@chromium.org
iannucci@chromium.org
scottmg@google.com
cmp@chromium.org