This is part 2 of a 2-part change which fixes a bug where git-cl
hangs if ~/.codereview_upload_cookies does not exist. It is
actually waiting on user input for email/password (but you don't see the
prompt because it's happening in a subprocess).
This is a do-over of http://codereview.chromium.org/3622002.
Much thanks to Lei Zhang for fixing the bugs in the original CL. His
fixup CL was http://codereview.chromium.org/3541019.
BUG=none
TEST=Verified that the hang is fixed.
Wrote a quick pre-submit to test that issue and patchset are ints:
http://codereview.chromium.org/3533020
Output:
** Presubmit Warnings **
Patchset is 1
Issue is 3533020
Review URL: http://codereview.chromium.org/3591017
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61957 0039d316-1c4b-4281-b951-d872f2087c98
This is part 2 of a 2-part change which fixes a bug where git-cl
hangs if ~/.codereview_upload_cookies does not exist. It is
actually waiting on user input for email/password (but you don't see the
prompt because it's happening in a subprocess).
BUG=none
TEST=Verified that the hang is fixed.
Review URL: http://codereview.chromium.org/3622002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61822 0039d316-1c4b-4281-b951-d872f2087c98
Otherwise, git try breaks for some users.
Also, make testUpdateCheckout pass if the path to the temp directory contains a symlink (like on Mac OS X).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3620011
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61786 0039d316-1c4b-4281-b951-d872f2087c98
smarter about finding the most appropriate settings file.
Before this change, I inadvertently did a [gcl try] on a chrome-internal
change (it was a trivial change and not really secret, so no harm done).
After this change, that won't be possible.
Also, change breakpad to not upload the exception that is thrown when
the user fails to provide correct log-on credentials.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3390013
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61738 0039d316-1c4b-4281-b951-d872f2087c98
python does not seem to be able to import for a dir with dashes in it.
BUG=none
TEST=Ran git-cl help and verified it worked and new dir was created.
Review URL: http://codereview.chromium.org/3530012
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61694 0039d316-1c4b-4281-b951-d872f2087c98
sys.stdout.isatty() is True even on buildbot.
Otherwise, logs can't be untangled when using --jobs.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3596006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61552 0039d316-1c4b-4281-b951-d872f2087c98
Added a unit test to verify .hg detection.
Also refactor the test a bit to reduce the amount of reduncdant code.
TEST=fixed unit tests
BUG=none
Review URL: http://codereview.chromium.org/3516015
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61551 0039d316-1c4b-4281-b951-d872f2087c98
Otherwise the scripts make it looks like they are hung when the presubmit checks
are slow.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3613007
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61506 0039d316-1c4b-4281-b951-d872f2087c98
looking for non-standard-named depot_tools directory
in git cl hooks python script. Otherwise, python
ignores the path.
Patch contributed by James Jones @ nvidia.
BUG=chromium-os:7007
Review URL: http://codereview.chromium.org/3467013
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@60499 0039d316-1c4b-4281-b951-d872f2087c98
The user will get an idea of what data is sent.
Getting the current working directory is useful to know what checkout was used.
the repr(last_tb) call was stripping off a lot of useful information for
debugging.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3384020
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@60339 0039d316-1c4b-4281-b951-d872f2087c98
It doesn't give me useful information.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3493005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@60209 0039d316-1c4b-4281-b951-d872f2087c98
This makes the code saner to understand.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3420014
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@60050 0039d316-1c4b-4281-b951-d872f2087c98
This breaks non-ascii output on Windows but if it's not there it breaks unicode
output on all other platforms. Ah code pages...
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3415010
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59966 0039d316-1c4b-4281-b951-d872f2087c98
Had to update a few tests, removed redundant code in gclient_scm_tests.
TEST=more readable unit tests
BUG=none
Review URL: http://codereview.chromium.org/3473003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59959 0039d316-1c4b-4281-b951-d872f2087c98
In the next change, we can now remove all the options.stdout bookeeping since
it's not unnecessary.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3398008
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59795 0039d316-1c4b-4281-b951-d872f2087c98
The end goal is to remove options.stdout, to remove a lot of bookkeeping.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3418014
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59792 0039d316-1c4b-4281-b951-d872f2087c98
That fixes the common usage "git-try <branch>" so the diff is generated against
a branch.
BUG=46697
TEST=none
Review URL: http://codereview.chromium.org/3433011
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59550 0039d316-1c4b-4281-b951-d872f2087c98
It seems execfile() has different properties than exec().
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3448001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59407 0039d316-1c4b-4281-b951-d872f2087c98
The previous 'fix' would fail if drover.properties would contain FILE_PATTERN = None
or something similar.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3363013
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59254 0039d316-1c4b-4281-b951-d872f2087c98
The class WindowsError is only a builtin on Windows. Use OSError instead.
Also make the exception more comprehensible on the other platforms when
pylint is not installed.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3331022
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59253 0039d316-1c4b-4281-b951-d872f2087c98
It hoses the chromium slaves on build.webkit.org.
It was fun while it lasted.
TBR=bradnelson
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3350018
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59146 0039d316-1c4b-4281-b951-d872f2087c98
For now that involves disabling a lot of tests when they can't be run.
I'm unsure about the ascii encoding, it fails here if I keep this call on a French UI.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3333028
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59137 0039d316-1c4b-4281-b951-d872f2087c98
It seems sys.stdout.isatty() is not a good signal on the build slaves.
TBR=bradnelson
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3342028
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59131 0039d316-1c4b-4281-b951-d872f2087c98
This way engineers can still enjoy the perf benefit while someone fixes the
buildbot stdio parsing issue.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3334017
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59127 0039d316-1c4b-4281-b951-d872f2087c98
This is because buildbot can't parse gclient output with parallel checkout,
causing got_revision to not be set, causing some scripts to fail.
TBR=bradnelson
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3325023
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59121 0039d316-1c4b-4281-b951-d872f2087c98
Now reuse compile.py and almost make them platform agnostic.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/306031
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59108 0039d316-1c4b-4281-b951-d872f2087c98
This tool has been quite useful noticing errors in the past and I'd have avoided a breakage in r58936 if I had run it.
Had to fix a few scripts first.
BUG=none
TEST=new test
Review URL: http://codereview.chromium.org/3337018
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59107 0039d316-1c4b-4281-b951-d872f2087c98
BUG=54084
TEST=updated smoke test and added a new one + stdout untangling
Review URL: http://codereview.chromium.org/3357020
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59002 0039d316-1c4b-4281-b951-d872f2087c98
I saw that in the exceptions and the current error (file not found) is not useful.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3332017
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58978 0039d316-1c4b-4281-b951-d872f2087c98
Simplify ExecutionQueue.run() by moving code into utility functions.
Reduce the amount of code in WorkerThread.run() to improve reliability.
Don't trap exceptions in single-threaded usage!
BUG=54084
TEST=none
Review URL: http://codereview.chromium.org/3336015
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58974 0039d316-1c4b-4281-b951-d872f2087c98
This is needed to improve the git tests further in a later change.
BUG=54084
TEST=none
Review URL: http://codereview.chromium.org/3294017
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58934 0039d316-1c4b-4281-b951-d872f2087c98
Added try/except to the places where errors are tolerated.
Renamed scm.SVN.CaptureBaseRevision to CaptureRevision and removed CaptureHeadRevision.
BUG=54084
TEST=none
Review URL: http://codereview.chromium.org/3307016
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58932 0039d316-1c4b-4281-b951-d872f2087c98
msb@chromium.org
bauerb@chromium.org
joi@chromium.org
maruel@chromium.org
morrita@chromium.org
thakis@chromium.org
laforge@chromium.org