Commit Graph

6 Commits (dcbf502f02ffa11a74e8f33cb7512c2cfab4a65b)

Author SHA1 Message Date
Struan Shrimpton 46ad34abca Reland "telemetry: Collect until opt-out"
This is a reland of commit 9c11bcef1f

Original change's description:
> telemetry: Collect until opt-out
>
> The pdd says we will collect by default:
> https://eldar.corp.google.com/assessments/570486509/revisions/1/sections/550004#questions/550404/revisions/2
>
> Also reduce the notice count to 9 since it notices on "0 remaining"
>
> Bug: 326277821
> Change-Id: I4de584c36868b45cefaa5cea42f88d245485dce7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6616983
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Commit-Queue: Struan Shrimpton <sshrimp@google.com>

Bug: 326277821
Change-Id: Ieee21e20ede1dfa71e6c7944ba0e92e74b5a5ded
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6624994
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
2 months ago
Struan Shrimpton 4e7e235dc8 Revert "telemetry: Collect until opt-out"
This reverts commit 9c11bcef1f.

Reason for revert: Last patch introduced a bug:
https://ci.chromium.org/ui/p/chromium/builders/try.shadow/mac-utr-tester/6/infra

Bug: 326277821
Original change's description:
> telemetry: Collect until opt-out
>
> The pdd says we will collect by default:
> https://eldar.corp.google.com/assessments/570486509/revisions/1/sections/550004#questions/550404/revisions/2
>
> Also reduce the notice count to 9 since it notices on "0 remaining"
>
> Bug: 326277821
> Change-Id: I4de584c36868b45cefaa5cea42f88d245485dce7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6616983
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Commit-Queue: Struan Shrimpton <sshrimp@google.com>

Bug: 326277821
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Iffaf2a8318cd93c3dd1014080c57de92cfdc4eff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6622519
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Auto-Submit: Struan Shrimpton <sshrimp@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
2 months ago
Struan Shrimpton 929a231882 Telemetry: add win support
The .vpython3 change is only necessary for running the opt in/out on
windows. Otherwise the only oddity was temporary files being weird
in windows.

Bug: 326277821
Change-Id: I88326410526d6fe7f6feb14a0bc27ab22eb12b58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6615021
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
2 months ago
Struan Shrimpton 9c11bcef1f telemetry: Collect until opt-out
The pdd says we will collect by default:
https://eldar.corp.google.com/assessments/570486509/revisions/1/sections/550004#questions/550404/revisions/2

Also reduce the notice count to 9 since it notices on "0 remaining"

Bug: 326277821
Change-Id: I4de584c36868b45cefaa5cea42f88d245485dce7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6616983
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
2 months ago
Struan Shrimpton d495580f42 Add telemetry initialization and opt out utility
This includes initializing the module which will handle printing the
notice and enabling/disabling telemetry based on config. The __main__
file also allows for the banner to have a consistent entry point for
disabling telemetry so instrumenting programs don't need to worry
about it if they are using the same default config file.

Bug: 326277821
Change-Id: I861d6b9311ed48c2e1effcac22b314b73e2641e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5901465
Reviewed-by: Terrence Reilly <treilly@google.com>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
10 months ago
Struan Shrimpton 9903e62e20 Add config to the telemetry lib
This provides the consistent config between runs. This only supports
linux at the moment, a windows support CL will follow up. Note the
current count down is stored to ensure we provide the banner a minimum
of 10 times and a uuid is stored which is collected in lieu of the
actual username

Bug: 326277821
Change-Id: I3817436ea213c755f490914023508a10cf3cef1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5855459
Reviewed-by: Terrence Reilly <treilly@google.com>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
11 months ago