aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
9,536 Commits
6 Branches
0 Tags
206 MiB
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'c333c3424e'
${ noResults }
Commit Graph

9536 Commits (c333c3424e17cbac765ccda5ab84888742dfa56c)
 

Author SHA1 Message Date
Bruce Dawson 424814829a Specify encoding when opening text files 
When opening a text file it is important to specify encoding='utf-8'
since otherwise the behavior will depend on your system locale. This
change fixes various encoding omissions in PRESUBMIT.py files, found
when presubmits were run when uploading crrev.com/c/4290775.

Bug: 1418846
Change-Id: Ief5f6d6bb749de95bc4071055492e6c9c6b6c56d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4292516
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
 2 years ago
Ho Cheung d437c34c1c [win_toolchain] Update toolchain version 
Chromium has now switched to MSVS2022+SDK22621 toolchain.
We should update some parameters and annotations in the file
to avoid inconsistent situations.

After applying this patch locally, no abnormal situation
is found. We can pack the toolchain normally.

Change-Id: I10ca115a076001efaa2b020251f2e448622598dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4297895
Auto-Submit: Ho Cheung <uioptt24@gmail.com>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
 2 years ago
Junji Watanabe 07edc50f39 Fix ninjalog_uploader.py to exclude /path/to/depot_tools/ninja.py 
Bug: b/270907050
Change-Id: I2bb5ffbb9ae8590078c92e2c7e0095f28f0c21be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4297356
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
 2 years ago
Takuto Ikuta b48200edc1 make tikuta as owner of ninjalog related files again 
Ownership was removed accidentally in https://crrev.com/c/4171506.

Change-Id: Ie52bf9c7d8180743d24f84e32fe8ede1e1fe0398
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4297357
Reviewed-by: Junji Watanabe <jwata@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
 2 years ago
recipe-roller 0eed4ac133 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8787880531313888865

recipe_engine:
14de8f5a56
  14de8f5 (bsheedy@chromium.org)
      Add env post_process checks

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia9836bb20feb07c77448902080ae2f7a8229088d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4297451
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
recipe-roller 2149f7d69e Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8787882416137709009

recipe_engine:
fa9f214a14
  fa9f214 (catduncan@google.com)
      [archive] preserve symlinks when extracting files

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1f33b7097897b0b8ed29a74782878bc2fef0d3d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4297448
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Aravind Vasudevan 19794fe91f Reset origin/HEAD when it points to master 
This change tries resetting origin/HEAD when it points to master and the ref cannot be found. Post master->main migration, some cached repositories seem to point origin/HEAD to master.

Bug: 1418866
Change-Id: I83942901b105cace4d51deeac7e400f98d200168
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4296441
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Thiago Perrotta f8cab106a4 Update vpython spec for yapf to 0.31.0 
R=sokcevic@google.com

Bug: 1306598
Change-Id: Idd5d4216dad62bf1c2d28d27e415046d6b1a311a
Follow-up-of: https://crrev/c/4284800
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4289682
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Thiago Perrotta <tperrotta@chromium.org>
 2 years ago
recipe-roller e6ceef1d26 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8787956657385866769

recipe_engine:
63fb46b46c
  63fb46b (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 2aa3db4b8128 to 5189c8c55b31

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie74c80ff3e3e7fe63e451cd045c12d03b8a4c4a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4297193
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Takuto Ikuta 7bf7e06945 disable log collection temporarily 
This is for b/270907050#comment2.

Bug: b/270907050
Change-Id: I4e816d38c1a0f379662533e278ab77cc46a8664a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4290688
Commit-Queue: Dirk Pranke <dpranke@google.com>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
 2 years ago
recipe-roller df034056c6 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8787971756857893553

recipe_engine:
8272518fc3
  8272518 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 6ad71d98b5c2 to 13094503b2de

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib40d26587c6505c671c8437fb7b803ae81a34061
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4296516
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Collin Baker 97f6d11cef Set presubmit line length check to 100 for Rust 
Rust style dictates 100 columns instead of 80. Update presubmit check
accordingly.

Bug: chromium:1292073
Change-Id: I4f0c0cc3b84ebb4559f29a6500ffd843febc8f93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4295201
Auto-Submit: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
 2 years ago
recipe-roller 03b4ba83f3 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8787976790426702945

recipe_engine:
e844823b0f
  e844823 (abrachet@google.com)
      [path] Add normpath

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic8842a91720d32d5c5359541c6001070dfff89e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4296327
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Edman Anjos 543fdf32d1 Fix typo in ninja.py: oterweise -> otherwise 
Bug: N/A
Change-Id: I04e9a60ff2047ae8d77e2504505aef3cf22e6050
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4295213
Auto-Submit: Edman Anjos <edman@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Joanna Wang 9144b67c7f gclient: Create graphviz file in flatten command. 
Change-Id: I57808ecb43df51a007945874339400fee2342807
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4229571
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
 3 years ago
Joanna Wang b54d0f013b Only trigger stacked changes dogfood path when in squash mode. 
Bug: 1419551
Change-Id: Idbc345798ba81c3e1abd2038db8fadbef0b7391e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4291331
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 3 years ago
recipe-roller eee53367c1 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8788258018828047713

recipe_engine:
e824444477
  e824444 (tperrotta@google.com)
      Update yapf style from "chromium" to "yapf"

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4c446061d40f7ec26777e13d37b87653c11e3929
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4291854
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
recipe-roller 27ac29f980 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8788303317206950801

recipe_engine:
2c10cb0f10
  2c10cb0 (garthbryden@google.com)
      Revert "Check Content-Length when downloading"

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9d237583214c58926f93d76d40b9cc2ec89b16ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4288238
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Ben Segall 6a71052c7f Add messages to inform users that reproxy is shutting down 
Otherwise there can be a moment at the end of the build where it feels like ninja hangs when you ctrl-c to kill

Bug: b/264405266
Change-Id: Ie67b48cb3ceb624885dc4cf62d5bd631a763ee76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4286582
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Ben Segall <bentekkie@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
 3 years ago
recipe-roller b9fe918590 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8788314012159066113

recipe_engine:
d992bd75dc
  d992bd7 (fancl@chromium.org)
      Check Content-Length when downloading

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0998d86e71bab487597dd485881174ff4f3704b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4288235
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Thiago Perrotta 223f48d7ad git cl split: recognize bug patterns of the form "Bug: chromium:123" 
Currently, only the "Bug: 123" form is recognized.

Bug: none
Change-Id: I4348779bb14f4c02bb8781ce4fe2bd55892e8cfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4289407
Commit-Queue: Thiago Perrotta <tperrotta@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
 3 years ago
Brian Sheedy fce87337b1 Convert recipe_modules expectation tests 
Converts all remaining recipe_modules expectation-based tests to be
assert/post_process-based.

Bug: 1418547
Change-Id: I0f45c92a4f682edcf186b5202ec2001475d04bec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4288230
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
 3 years ago
Bruce Dawson 58da0c8284 Add elapsed-time sorting option to build summary 
post_build_ninja_summary.py normally sorts its output by weighted time,
which is elapsed time divided by how many steps are running. Sometimes
it is more appropriate to sort by elapsed (wall clock) time instead.
This adds a -e/--elapsed_time_sorting option to do this.

Change-Id: I13a1b094f8fd7f6795a871bee91932ce0ddab79d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4285697
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
 3 years ago
Josip Sokcevic a6898e71ab Add presubmit check for git submodule 
This change allows repos that use depot_tools to have submodules. It
relies on a "magic" text `SUBMODULE_MIGRATION` and
`use_git_submodules`in DEPS file.

SUBMODULE_MIGRATION is placed in DEPS file when git submodules should be
accepted but parity with DEPS file is expected. We don't rely on gclient
getdep as it's too slow for a presubmit check. Instead, we just naively
check presence of git submodule commit hash in the DEPS file.

use_git_submodules (to be a proper variable in DEPS file) indicates the
project migrated to git submodules and no git dependencies are specified
in DEPS file.

R=aravindvasudev@google.com, jojwang@google.com

Bug: 1417051
Change-Id: I03fcd98a001ee8513740108e58bc1dfe3c9a460e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4262472
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 3 years ago
Victor Hugo Vianna Silva dd03016926 Don't prompt for confirmation in `git cl upload --dependencies` 
This is a pretty intentional command, I don't see why the confirmation
would be required.

Bug: None
Change-Id: I111bb39e3b5f467901be5c986847ace3c6efa7ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4261467
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Victor Vianna <victorvianna@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 3 years ago
Thiago Perrotta d85c5bc6ff Update vpython spec for yapf to 0.29.1 
R=cjmcdonald@chromium.org, gavinmak@google.com, sokcevic@google.com

Bug: 1306598
Change-Id: I57b2be45f2d34ef63eee58cdf24196790a940ea1
Follow-up-of: https://crrev/c/4188739
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4284800
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Thiago Perrotta <tperrotta@chromium.org>
 3 years ago
Brian Sheedy 4756d7c420 Add tryserver test_api method 
Updates the tryserver recipe module's test_api to support overriding
get_footers data.

Bug: angleproject:7985
Change-Id: Ie571bc8d1c77cbb1cd4f18955b50d56e377ca903
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4278466
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
 3 years ago
recipe-roller 0e503522b9 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8788501487278159873

recipe_engine:
3bd372a45d
  3bd372a (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from df03dcec6a49 to 8a8b4f2ea65c

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie802c29818da22434278efe8f8761d25762929a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4278467
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
recipe-roller a104c01252 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8788515965680486305

recipe_engine:
6b5bebd202
  6b5bebd (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 692be227c775 to 5b086ea152ab

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I43655fd1871f33829fdf8ffa25db6b13aedfc644
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4277827
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Eric Lok 30136f0cb7 Reinstate reclient 
Adding back reclient to depot tools. This will allow it to be used for
chromeos-chrome builds, and other packages in the future as well

Bug: b/270080866, b/242680623
Change-Id: Ibb800a7c36f61312d540ee5595c585493e5e3578
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4273546
Commit-Queue: Eric Lok <lokeric@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
 3 years ago
recipe-roller 62c7a8bad0 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8788888420150508369

recipe_engine:
b74a15e57b
  b74a15e (olivernewman@google.com)
      [cas] Forward kwargs to api.step()

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I133e55bf0cbeae72182bd593a0bbd939d9fb500f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4264819
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Aravind Vasudevan 3879bd830c Reland "Warn users when .boto might be outdated" 
This is a reland of commit e2f35370f5

Original change's description:
> Warn users when .boto might be outdated
>
> Fixed: 1414152
> Change-Id: I887de64a72777c92413ee921099dd762361f6c5c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4251897
> Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
> Reviewed-by: Traian Captan <tcaptan@chromium.org>

Change-Id: Ib77921c172d6d5953c0df6a823b37d8d544ed5f6
Fixed: 1416952
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4260819
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
 3 years ago
recipe-roller c72b0e286d Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8788964542832583905

recipe_engine:
6bfbee5c8c
  6bfbee5 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 2321089ab31a to c543f47ae455

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iab74f474593fa2715acc1d1e06b9329634d4db28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4260820
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Peter Kasting 0074158bf6 Fix various lint false positives. 
* C++11: Expressions related to type_traits templates. Cherry-pick of
  internal cl/477737746.
* C++20: requires-expressions. Cherry pick of internal cl/450768176.
* C++20: `co_return *p;`. Unique to Chromium (cpplint_chromium.py).

Bug: 1284275
Change-Id: I06ede7b708dfe71308f669a2d6c37d00ded6c086
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4226465
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
 3 years ago
Aravind Vasudevan f15baeae48 Revert "Warn users when .boto might be outdated" 
This reverts commit e2f35370f5.

Reason for revert: Potentially breaks https://source.chromium.org/chromium/chromium/src/+/main:build/fuchsia/gcs_download.py;l=34 

Original change's description:
> Warn users when .boto might be outdated
>
> Fixed: 1414152
> Change-Id: I887de64a72777c92413ee921099dd762361f6c5c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4251897
> Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
> Reviewed-by: Traian Captan <tcaptan@chromium.org>

Change-Id: Idd403b3054643b437ee165b8af2e775dc7e1abb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4262468
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 3 years ago
Joanna Wang 6b98cdcbc1 Check for detached HEAD state. 
Bug: 1416683
Change-Id: I538715d05170662001ac7193a86dbd2e7f50e3f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4258505
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Joanna Wang <jojwang@chromium.org>
 3 years ago
Chan Li 78db513359 [depot_tools] Roll led 
To release https://crrev.com/8a2853232613a9b6ad94dfcb3ea911a41861b42b

Change-Id: I0781f63aed104691c992f81b735fe760bc02bf93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4256627
Reviewed-by: Yuanjun Huang <yuanjunh@google.com>
Commit-Queue: Chan Li <chanli@chromium.org>
 3 years ago
Aravind Vasudevan e2f35370f5 Warn users when .boto might be outdated 
Fixed: 1414152
Change-Id: I887de64a72777c92413ee921099dd762361f6c5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4251897
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
Reviewed-by: Traian Captan <tcaptan@chromium.org>
 3 years ago
Aravind Vasudevan 9ae55e5d77 Cleanup GSUTIL_ENABLE_LUCI_AUTH flag 
This change cleans up GSUTIL_ENABLE_LUCI_AUTH flag from gsutil. This is the final change to transition to luci-auth.

Fixed: 1359383
Change-Id: I1b4ac4bf95a887ebec92f71df343e855829846a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4197458
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
 3 years ago
recipe-roller e8ca7709cb Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8789153922331963633

recipe_engine:
086386d9ca
  086386d (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from e2d67b2cb935 to d120042f61f6

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2e8b1d99a2e40d6287cb76917d00970be744a244
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4249563
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
recipe-roller ce1ef9afdf Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8789248290143892817

recipe_engine:
4b7bc24b24~..29c7df628b1b7ea7510b91ca80eebf66953727b5
  4b7bc24 (machenbach@chromium.org)
      [led] Retain fluency with inject_input_recipes
  73273ae (olivernewman@google.com)
      [test] Avoid creating empty expectation file dirs
  e12221e (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from fca00f1dc785 to 7fdf5527267e
  9529a65 (iannucci@chromium.org)
      [warnings] Fix error on py3 where str is not comparable to None.
  0caaa20 (iannucci@chromium.org)
      Fix typo in warn/escape.py
  29c7df6 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 7fdf5527267e to a4b0cf91f9d6

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic047e7b1b204e0c3a0ec2179dfd45ecb8c8d03b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4246317
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Robert Iannucci b2429ece99 [recipes] Mark repo as py3 only. 
This will allow autoroller to continue to roll into this repo.

Since there are no recipes (only modules) in this repo, this will have
no effect on any production builders.

R=ajp@google.com

Bug: 941669
Change-Id: I3e1847d6782ac4dfad4a5bdbb01388e8dd3ccebf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4241140
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
 3 years ago
Ben Segall c4efd8a7aa Set path based reproxy flags in autoninja to sandbox developer builds 
This is being added as per go/chromium-reclient-dev-cfg-op#heading=h.kt0ffeuv1ll4

Bug: b/264405266
Change-Id: I69c6ae2343a206516cb3425300741ede46628ece
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4189202
Commit-Queue: Ben Segall <bentekkie@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
 3 years ago
Yiwei Zhang e636a25853 split the config validation request into smaller requests 
R=iannucci, yuanjunh

Bug: b/268065448
Change-Id: I6d700c39bdea8438815e3bf5a462038b05619a9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4240362
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Yuanjun Huang <yuanjunh@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 3 years ago
recipe-roller 10369890bb Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8789588660140111505

recipe_engine:
d82cf3c7fd
  d82cf3c (godofredoc@google.com)
      Use python3 instead of python in file module.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5491d13acfe9fda047037813690bdf66cc3d16f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4237879
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
recipe-roller ea8c51d18b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8789599357096474433

recipe_engine:
343085eec3
  343085e (mohrr@google.com)
      cq: Add NEW_PATCHSET_RUN constant

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I78be761d524afd490c2787279986ffba618f9130
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4237547
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
recipe-roller 023ee12319 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8789609422789286209

recipe_engine:
95a79f0a5d
  95a79f0 (ddoman@chromium.org)
      [recipes-py] remove no longer owners

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5bd8de9ba7c98d244a00e6c92b24ad239e543fe3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4237535
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Camilo Jacomet d8fb7c9667 [auth][oob-deprecation]: Update CIPD entries for LUCI Auth. 
Fixed issue where token to paste was refreshing fast and made it difficult to copy in terminal emulators such as Alacritty and Konsole.

Bug:1411481, 1406354
Change-Id: I260c18c4aca873530d7ead55ab8826b01edffd9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4231602
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Camilo Jacomet <cjacomet@google.com>
 3 years ago
chrome-bot cd2395991f Add crossbench to the gclient config 
Bug:1410350
Change-Id: Iaf9fa01a92ed50c70224d480c3ee1b4acaf71aeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4234360
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Ashwin Verleker <ashwinpv@google.com>
 3 years ago
recipe-roller 7bad7fdbe9 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8789705043284449409

recipe_engine:
4f7d370e33
  4f7d370 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 49c144dcbda8 to fc9d7a3dff50

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic03af3d11c3212177830cbdcf50f8cc90cfcf5e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4232881
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago