dpranke@chromium.org
e3b1c3d1e3
Fix swapping of args in call to relpath() that was causing
...
OWNERS checks on DEPS to fail.
TBR=maruel@chromium.org
BUG=157022
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@163192 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
dpranke@chromium.org
17cc244cdb
implement per-file OWNERS support
...
R=maruel@chromium.org
BUG=119394
Review URL: https://chromiumcodereview.appspot.com/11114005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@162529 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
zork@chromium.org
04704f7b4a
Readd missing unittests for owners
...
TEST=Run tests/owners_unittest.py
Review URL: https://chromiumcodereview.appspot.com/10384099
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@137041 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
zork@chromium.org
046e175ff0
Output a list of suggested OWNERS reviewers when needed.
...
BUG=None
TEST=Change files that need OWNERS review. Upload the patch. Check that the warning suggests a minimum set of reviewers.
Review URL: https://chromiumcodereview.appspot.com/10222020
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@135619 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
pam@chromium.org
f46aed992a
Show a list of directories missing OWNER reviewers on upload, and show directories rather than files missing OWNER approvals on commit.
...
BUG=117166
TEST=covered by presubmit unittests
Review URL: http://codereview.chromium.org/9621012
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@125588 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org
0927b7eef8
Create a new testing_support module to move utility modules there
...
It will simplify importing utility modules from other projects. Otherwise I was getting name conflicts with 'test'.
Reenable W0403 that was disabled in the previous CL.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/8508015
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109636 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org
428342a0a7
Standardize the sys.path fix up and fix a few pylint warnings.
...
Disable temporarily W0403, will be reenabled on the next CL
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/8508017
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109435 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org
45d8db04f9
Add more python 2.5 compatibility.
...
Makes all the tests runnable on python 2.5.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/6690034
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80068 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
dpranke@chromium.org
e6a4ab30db
merge in fixes for python 2.5
...
R=maruel@chromium.org
Review URL: http://codereview.chromium.org/6740012
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79942 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
dpranke@chromium.org
972c6acdee
add test with an OWNERS file that has names plus a wildcard
...
Review URL: http://codereview.chromium.org/6717004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79206 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
dpranke@chromium.org
fdecfb77a2
Fix the owners implementation to validate method inputs.
...
R=chase@chromium.org,maruel@chromium.org
Review URL: http://codereview.chromium.org/6677090
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78454 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
dpranke@chromium.org
86bbf19ccf
Add more tests for owners.py, remove unneeded code, make syntax errors more helpful
...
Review URL: http://codereview.chromium.org/6639010
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77522 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
dpranke@chromium.org
7eea259694
use PEP-8 naming for method names in owners.py, tests/owners_unittest.py
...
Review URL: http://codereview.chromium.org/6646007
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77521 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
dpranke@chromium.org
6dada4eef1
make tests work, implement 'set noparent', owners propagating down
...
Review URL: http://codereview.chromium.org/6627059
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77351 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
dpranke@chromium.org
ae43f83fe3
add owners_file() convenience constructor function for testing, make user names a bit more generic
...
Review URL: http://codereview.chromium.org/6632014
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77178 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
dpranke@chromium.org
3c08dd45cc
Add some unit tests. They don't pass yet.
...
Review URL: http://codereview.chromium.org/6612011
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@76980 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago