Reapply r79006 with fixes for ubuntu 10.4.
The only change is in fix_default_encoding() to trap an exception
locale.getlocale() may throw.
R=dpranke@chromium.org
BUG=none
TEST=unit test
Review URL: http://codereview.chromium.org/6721029
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79144 0039d316-1c4b-4281-b951-d872f2087c98
It is causing exception for some users on ubuntu 10.4 with:
"category LC_ALL is not supported"
TBR=dpranke
Review URL: http://codereview.chromium.org/6717025
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79012 0039d316-1c4b-4281-b951-d872f2087c98
With this code in action, I can successfully print arabic and chinese on linux
and cygwin. It fails to print chinese on my Mac but prints arabic. It prints '?'
on Windows console but it *doesn't throw* which is the biggest improvement here.
It was particularly a problem on windows because WindowsError's description text
is in the current ANSI code page so it failed to print if the text was not pure
ASCII, like error message when using Windows' French UI.
R=dpranke@chromium.org
BUG=none
TEST=manual unit test ./tests/fix_encoding_test.py and it shouldn't throw
Review URL: http://codereview.chromium.org/6676090
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79006 0039d316-1c4b-4281-b951-d872f2087c98
This change moves most of the code into presubmit_support and gclient_utils and just leaves the formatting differences for the messages between the two tools.
Review URL: http://codereview.chromium.org/6719004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79002 0039d316-1c4b-4281-b951-d872f2087c98
Split presubmit_support.Main() in two to make it simpler.
Handle better the case with unversioned files and add a unit test.
R=dpranke@chromium.org
Review URL: http://codereview.chromium.org/6674059
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78700 0039d316-1c4b-4281-b951-d872f2087c98
pass pylint cleanly.
There should be no functional changes in this patch, although there's at least one minor bug that lint caught.
Review URL: http://codereview.chromium.org/6685023
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78638 0039d316-1c4b-4281-b951-d872f2087c98
output object, I forgot to modify the commit command, and so now we're
ignoring failures complete. That's not good :(
Landing w/o review (but with unit tests!) to minimize damage.
Review URL: http://codereview.chromium.org/6688017
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78627 0039d316-1c4b-4281-b951-d872f2087c98
bugs that for some reason the presubmit missed the first time around.
TBR=chase@chromium.org,maruel@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78497 0039d316-1c4b-4281-b951-d872f2087c98
"Fix regression introduced in r78329."
"Modify gcl to use suggested_reviewer output from presubmit_support."
My quick fix was insufficient.
TBR=dpranke
Review URL: http://codereview.chromium.org/6667042
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78356 0039d316-1c4b-4281-b951-d872f2087c98
This really needs a unit test.
TBR=dpranke
TEST=none
Review URL: http://codereview.chromium.org/6670046
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78355 0039d316-1c4b-4281-b951-d872f2087c98
EDITOR environment variable shouldn't be required anymore
can contain quotes and multiple arguments.
Uses shell=True to let the shell parse the quoted string
instead of handling all forms of quotes ourselves.
By default, msysgit ships with the TERM environment variable
set, when set to 'msys', we prepend 'env' to the executed
command. That is required so msys knows which program
to run the given file.
BUG=none
TEST=On many platforms. Win7, WinXP, Ubuntu.
Review URL: http://codereview.chromium.org/6685062
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78332 0039d316-1c4b-4281-b951-d872f2087c98
It also simplifies all of the PresubmitResult* objects and the way we're using output streams since we can assume more about how the callers are calling us.
Note that I uses PEP-8 style method names where I was adding entirely new classes (or rewriting existing classes completely) since per maruel@ he is trying to new that style for new code.
This change also contains two small changes to git_cl to fix bugs and restore the previous behavior of --force skipping the presubmit checks.
Review URL: http://codereview.chromium.org/6694009
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78328 0039d316-1c4b-4281-b951-d872f2087c98
Revert the order back to deleting then svn revert'ing, which is safer than the
reverse. Document a bit better the behavior.
R=dpranke@chromium.org
BUG=none
TEST=commit queue should die less often
Review URL: http://codereview.chromium.org/6681032
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78224 0039d316-1c4b-4281-b951-d872f2087c98
default and can fill the pipe used by subprocess.Popen(), leading to
hangs.
Review URL: http://codereview.chromium.org/6684025
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78084 0039d316-1c4b-4281-b951-d872f2087c98
then at some point prior to my recent changes "git-cl upload master..."
stopped working and you need to do only "git-cl upload master".
Review URL: http://codereview.chromium.org/6679033
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78082 0039d316-1c4b-4281-b951-d872f2087c98
something with spaces in it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6686046
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78027 0039d316-1c4b-4281-b951-d872f2087c98
An error message would be printed at each update_depot_tools invocation.
TBR=mhm
BUG=none
TEST=running gclient shouldn't print an error message at each invocation anymore
Review URL: http://codereview.chromium.org/6690008
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78021 0039d316-1c4b-4281-b951-d872f2087c98
BUG=none
TEST=message appears only when new revision changes.
Review URL: http://codereview.chromium.org/6691001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77997 0039d316-1c4b-4281-b951-d872f2087c98
It is cleaner this way since in Win32 console, the
value is always "dumb" while in msysgit it is always
"msys" The user shouldn't change the value of $TERM
in msysgit otherwise their whole copy of msysgit
will be flaky.
BUG=70548
TEST=check $TERM in windows
Review URL: http://codereview.chromium.org/6686027TBR=mhm@chromium.org
Review URL: http://codereview.chromium.org/6683033
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77972 0039d316-1c4b-4281-b951-d872f2087c98
It is cleaner this way since in Win32 console, the
value is always "dumb" while in msysgit it is always
"msys" The user shouldn't change the value of $TERM
in msysgit otherwise their whole copy of msysgit
will be flaky.
BUG=70548
TEST=check $TERM in windows
Review URL: http://codereview.chromium.org/6686027
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77954 0039d316-1c4b-4281-b951-d872f2087c98
It would fail on win32 when these modules are not present.
BUG=75902
TEST=none
R=mhm@chromium.org
Review URL: http://codereview.chromium.org/6683028
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77947 0039d316-1c4b-4281-b951-d872f2087c98
An explicit msysgit check is needed since it requires
the usage of 'env' to open the editor.
BUG=70550, 70548
TEST=Win,Linux
Review URL: http://codereview.chromium.org/6680019
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77946 0039d316-1c4b-4281-b951-d872f2087c98
Editor doesn't come up due to Shell=True
BUG=none
TEST=linux and win works
Review URL: http://codereview.chromium.org/6679023
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77913 0039d316-1c4b-4281-b951-d872f2087c98
The unix editor doesn't popup resulting in a unsuccessful upload. This change successfully fixes it.
BUG=70550
TEST=git cl upload works as expected under msysgit.
Review URL: http://codereview.chromium.org/6679019
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77910 0039d316-1c4b-4281-b951-d872f2087c98
gcl is now fully compatible with msysgit.
BUG=70550
TEST=gcl change through msysgit.
Review URL: http://codereview.chromium.org/6689001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77909 0039d316-1c4b-4281-b951-d872f2087c98
This change requires us to change the previous signature for the CheckOwners() hook to provide the server address and email regexp to use for parsing approvals from Rietveld.
Review URL: http://codereview.chromium.org/6657028
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77891 0039d316-1c4b-4281-b951-d872f2087c98
maruel@chromium.org
dpranke@chromium.org
bauerb@chromium.org
mhm@chromium.org
thomasvl@chromium.org
jam@chromium.org