Commit Graph

8 Commits (b96f2d5b1dd025c4392bc9b41a95d75e749e04d0)

Author SHA1 Message Date
phajdan.jr 4f00aa0b49 infra_paths: keep cache paths super short to avoid long path issues (attempt #2)
This is a reland of https://codereview.chromium.org/2102613002/ .

See https://goto.google.com/ljfzu (Google-internal) for more context. Summary:
- the only builders with chromium checkout affected by this are on chromium.fyi
- we can't clean up old cache directories before switching to new ones

Also see https://goto.google.com/oyxwm why so short directory names are OK.
Similarly https://codereview.chromium.org/2061213002 .

BUG=623575

Review-Url: https://codereview.chromium.org/2102403002
9 years ago
nodir 460d557eec Revert of infra_paths: keep cache paths super short to avoid long path issues (patchset #1 id:1 of https://codereview.chromium.org/2102613002/ )
Reason for revert:
/b/cache dir on slaves were not cleaned up and now disk alerts are firing

please come up with a cleanup strategy before re-landing this CL

Original issue's description:
> infra_paths: keep cache paths super short to avoid long path issues
>
> BUG=623575
>
> Committed: aa0b3b6bd0

TBR=emso@chromium.org,sergiyb@chromium.org,tandrii@chromium.org,thakis@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=623575

Review-Url: https://codereview.chromium.org/2100793004
9 years ago
phajdan.jr aa0b3b6bd0 infra_paths: keep cache paths super short to avoid long path issues
BUG=623575

Review-Url: https://codereview.chromium.org/2102613002
9 years ago
phajdan.jr c2054c2fb0 infra_paths: enable persistent cache also on Windows
BUG=584079, 459840, 593999, 596887

Review-Url: https://codereview.chromium.org/2102503002
9 years ago
phajdan.jr 44945e7838 infra_paths: enable persistent cache also on Mac
BUG=584079, 459840, 593999, 596887

Review-Url: https://codereview.chromium.org/2095333002
9 years ago
phajdan.jr@chromium.org 32f9abc277 depot_tools: create builder cache path config
BUG=chromium:596887

Review-Url: https://codereview.chromium.org/1937953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300403 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
phajdan.jr@chromium.org ecbb63d08b depot_tools: add specific cache directory for goma deps in kitchen path config
BUG=chromium:596887

Review-Url: https://codereview.chromium.org/1933683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300343 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
phajdan.jr@chromium.org c3c1229013 depot_tools: add infra_paths recipe module for infra-specific paths (attempt #2)
This is different from previous attempt https://codereview.chromium.org/1915463002 .

The change is completely backwards-compatible, and doesn't introduce recipe
expectation changes.

Modules can be switched to depend on infra_paths independently,
without any expectation changes either.

By moving path module's config.py to paths_config.py here, we also guarantee
that the returned results are going to be exactly the same.

Depends on https://codereview.chromium.org/1923363003 .

BUG=chromium:605919

Review-Url: https://codereview.chromium.org/1926033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300324 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago