hinoka
b61b9b7583
Reland bot_update: add --auth-refresh-token-json passthrough for apply_issue
...
Reland of https://codereview.chromium.org/2294413002/ after a rebase fix.
BUG=642150
Review-Url: https://codereview.chromium.org/2353833002
9 years ago
vadimsh
23fe6cfb9d
Updating git-for-windows to 2.10.0.
...
R=iannucci@chromium.org, hinoka@chromium.org
BUG=647446
Review-Url: https://codereview.chromium.org/2357633004
9 years ago
hinoka
ad842878e4
Revert of bot_update: add --auth-refresh-token-json passthrough for apply_issue (patchset #7 id:120001 of https://codereview.chromium.org/2294413002/ )
...
Reason for revert:
Pointing to the wrong file :(
Original issue's description:
> bot_update: add --auth-refresh-token-json passthrough for apply_issue
>
> BUG=642150
>
> Committed: e465667e78
TBR=vadimsh@chromium.org,martiniss@chromium.org,tandrii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=642150
Review-Url: https://codereview.chromium.org/2350363003
9 years ago
benhenry
186449d3e7
docs: Removing references to SVN
...
BUG=643697
TEST=None
Review-Url: https://codereview.chromium.org/2350293002
9 years ago
hinoka
e465667e78
bot_update: add --auth-refresh-token-json passthrough for apply_issue
...
BUG=642150
Review-Url: https://codereview.chromium.org/2294413002
9 years ago
recipe-roller
e4abcee60e
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/f7ada90c926c78704f048767e29e8ae836d8a65b Prefer overridden dependencies. (dnj@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=None
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2354683004
9 years ago
hinoka
8ea74908a6
depot_tools: Remove third_party/gsutil
...
A quick "git grep gsutil" reveals that this is no longer being used, and all
references to gsutil are pointed to gsutil.py.
BUG=
Review-Url: https://codereview.chromium.org/2280023003
9 years ago
rmistry
9eadede7df
Add ability to set topic during "git cl upload"
...
BUG=chromium:628237
Review-Url: https://codereview.chromium.org/2343363003
9 years ago
nick
7e16cf3032
owners.py: partial fix for owners-check perf regression
...
fnmatch.fnmatch seems to fall off a performance cliff once you start cycling through more patterns than can fit in its internal cache.
BUG=642793
Review-Url: https://codereview.chromium.org/2293233002
9 years ago
vadimsh
6ac12ffd59
Make bot_update.py print git version it uses.
...
R=iannucci@chromium.org, dnj@chromium.org
BUG=647446
Review-Url: https://codereview.chromium.org/2344313002
9 years ago
vadimsh
7f245d07b2
Bump git-on-windows bleeding edge version to 2.10.0.
...
R=iannucci@chromium.org
BUG=647446
Review-Url: https://codereview.chromium.org/2347243002
9 years ago
tandrii
15a248123d
Revert of bot_update: ensure correct depot_tools checkout is used. (patchset #2 id:20001 of https://codereview.chromium.org/2346973003/ )
...
Reason for revert:
broke win_chromium_x64_rel_ng/builds/281022
because of apply_issue.bat calls local python.
Original issue's description:
> bot_update: ensure correct depot_tools checkout is used.
>
> R=vadimsh@chromium.org,martiniss@chromium.org
> BUG=635641,647446
>
> Committed: 972ac50401
TBR=martiniss@chromium.org,vadimsh@chromium.org,iannucci@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635641,647446
Review-Url: https://codereview.chromium.org/2349673002
9 years ago
tandrii
972ac50401
bot_update: ensure correct depot_tools checkout is used.
...
R=vadimsh@chromium.org,martiniss@chromium.org
BUG=635641,647446
Review-Url: https://codereview.chromium.org/2346973003
9 years ago
vadimsh
18ca30ca80
Teach bot_update to remove partially deleted git repos.
...
Also add logging to 'remove', helps to debug issues with 'build.dead' filling
up with crap.
R=iannucci@chromium.org, hinoka@chromium.org
BUG=647046
Review-Url: https://codereview.chromium.org/2342973002
9 years ago
thakis
adcd4b78d5
presubmit_support: Remove a noisy logging.debug()
...
On a CL with a single file, presubmit writes all this noise:
Running /b/build/slave/linux/build/src/PRESUBMIT.py
DEBUG:root:Running CheckChangeOnCommit in /b/build/slave/linux/build/src/PRESUBMIT.py
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.(cc|cpp|cxx|mm)$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:git diff -p --no-color --no-prefix --no-ext-diff 691e0c7d46341465de7a605b5f2aee941ccfedc0...HEAD --no-renames; cwd=/b/build/slave/linux/build/src
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:/usr/bin/python /b/build/slave/linux/build/src/tools/checkperms/checkperms.py --root /b/build/slave/linux/build/src --file content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:^(android_webview|base|content|net)[\\\/].* matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.(cc|cpp|cxx|mm)$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:LocalPaths: ['content/browser/gpu/gpu_data_manager_impl_private.cc']
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.(cc|cpp|cxx|mm)$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:Running CheckChangeOnCommit done.
The "a matched b" lines are boring and numerous, so remove this log line.
If we ever need it to debug something, we can add it back then (temporarily).
(From https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/260304/steps/presubmit/logs/stdio )
BUG=none
Review-Url: https://codereview.chromium.org/2341103002
9 years ago
vapier
7475196d4c
repo: update to v1.12.17-cr1
...
We've synced our fork of repo to upstream. This change copies the new
version into depot_tools.
BUG=chromium:632203
TEST=`repo sync` still works
TEST=`repo sync` with a tag signed by me works
TEST=`repo init` with my tag is accepted
Review-Url: https://codereview.chromium.org/2340073002
9 years ago
tandrii
bf42940536
git cl land to refs/pending: remove unused arg.
...
R=iannucci@chromium.org
BUG=642493
Review-Url: https://codereview.chromium.org/2322783002
9 years ago
tandrii
73449b0bd4
Gerrit git cl land: abort if not uploaded.
...
R=agable@chromium.org
BUG=642759,609225
Review-Url: https://codereview.chromium.org/2317253003
9 years ago
tandrii
5d0a0421ce
git_cl: update outdated TODOs.
...
R=machenbach@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2339903002
9 years ago
tandrii
f46c20fcee
codereview.settings: add GIT_NUMBER_FOOTER setting.
...
This will be used in repositories that use Cr-Commit-Position footers
to generate them at the time of git cl land instead of gnumbd.
R=iannucci@chromium.org
BUG=642493
Review-Url: https://codereview.chromium.org/2324583002
9 years ago
recipe-roller
34aa4d98f1
Roll recipe dependencies (nontrivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must CQ the change manually.
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/82c60d376b779c86f78ce98884fd4f887382e9ec Add better documentation, trigger namedtuple. (dnj@chromium.org )
R=dnj@chromium.org
BUG=None
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2335163004
9 years ago
martiniss
33061f78a1
Add recipe-roller as an OWNER of recipe modules.
...
See https://codereview.chromium.org/2335163004 for why this is needed. The
roller can't land a non-trivial CL with the upstream author's LGTM, because
it's not an OWNER of the recipes in the repo it's rolling into.
Review-Url: https://codereview.chromium.org/2337263002
9 years ago
recipe-roller
65cc5b1918
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/ca75ca80dcfcc2a2dc38096ba0522065ebd347ec Revert of Require recipe tryjob for CQ. (patchset #1 id:1 of https://codereview.chromium.org/2153303002/ ) (martiniss@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=644609,628801
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2338723003
9 years ago
recipe-roller
1ce79108a3
Roll recipe dependencies (nontrivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must CQ the change manually.
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/dbdcd3b5c9096b3a770bdb61e15039115b6a8dd3 Revert of Add better documentation, trigger namedtuple. (patchset #3 id:40001 of https://codereview.chromium.org/2332833003/ ) (martiniss@chromium.org )
R=martiniss@chromium.org
BUG=None
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2336313002
9 years ago
rmistry
ea9e93f28c
Skip apply_gerrit rebase when there is a rebase failure.
...
Not doing so causes a failure in the 'git checkout $base_rev' step as visible here: https://build.chromium.org/p/client.skia.fyi/builders/Infra-PerCommit-Trybot/builds/4995
This causes the checkout to remain in the "rebase in progress" state.
BUG=chromium:645955
BUG=skia:5749
Committed: 9736fe8938
Review-Url: https://codereview.chromium.org/2328313002
9 years ago
recipe-roller
53323d7320
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/be22c9a16dd89f9780e193a24edd98346870271d Formally define step config, pass to stream. (dnj@chromium.org )
https://crrev.com/8ad49e0698f1e74e3f500fda6ca5b65a2af29fd0 Add better documentation, trigger namedtuple. (dnj@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=None,chromium:628770
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2338573002
9 years ago
rmistry
b940385856
Revert of Skip apply_gerrit rebase when there is a rebase failure (patchset #2 id:20001 of https://codereview.chromium.org/2328313002/ )
...
Reason for revert:
The "git rebase --abort" should only happen when there is a failure during rebase not when it succeeds.
Original issue's description:
> Skip apply_gerrit rebase when there is a rebase failure.
>
> Not doing so causes a failure in the 'git checkout $base_rev' step as visible here: https://build.chromium.org/p/client.skia.fyi/builders/Infra-PerCommit-Trybot/builds/4995
> This causes the checkout to remain in the "rebase in progress" state.
>
>
> BUG=chromium:645955
> BUG=skia:5749
>
> Committed: 9736fe8938
TBR=agable@chromium.org,andybons@chromium.org,tandrii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:645955
Review-Url: https://codereview.chromium.org/2331103002
9 years ago
rmistry
9736fe8938
Skip apply_gerrit rebase when there is a rebase failure.
...
Not doing so causes a failure in the 'git checkout $base_rev' step as visible here: https://build.chromium.org/p/client.skia.fyi/builders/Infra-PerCommit-Trybot/builds/4995
This causes the checkout to remain in the "rebase in progress" state.
BUG=chromium:645955
BUG=skia:5749
Review-Url: https://codereview.chromium.org/2328313002
9 years ago
agable
c6787971b5
Use 'draft' status to restrict access to private Gerrit reviews
...
R=andybons@chromium.org, tandrii@chromium.org
Review-Url: https://codereview.chromium.org/2324283002
9 years ago
iannucci
d1d31d5d41
A bunch more little cleanups in bot_update.
...
R=agable@chromium.org, estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org
BUG=643885
Review-Url: https://codereview.chromium.org/2321203003
9 years ago
scottmg
9fc458976c
Don't try svn.chromium.org for src-internal check
...
svn://svn.chromium.org/chrome-internal/trunk/src-internal/ doesn't seem
to exist any more.
d:\src>"d:\src\depot_tools\svn_bin\svn.exe" ls --non-interactive svn://svn.chromium.org/chrome-internal/trunk/src-internal/
svn: Can't connect to host 'svn.chromium.org': A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
R=brucedawson@chromium.org
Review-Url: https://codereview.chromium.org/2327213002
9 years ago
kjellander
9abf453c3a
WebRTC: Remove references to src/third_party/libjingle/source/talk
...
A while back, we removed the last pieces of code in
src/third_party/libjingle/source/talk and it is no longer synced
in Chromium's DEPS file. Clean this up to avoid confusion in the
buildbot recipes.
BUG=webrtc:4256
Review-Url: https://codereview.chromium.org/2325043002
9 years ago
agable
c958da4979
Switch bot_update to use exponential backoff on clone
...
R=iannucci@chromium.org
BUG=472386
Review-Url: https://codereview.chromium.org/2324073002
9 years ago
iannucci
3dd7436899
Remove unused PATCH_TOOL and resulting dead code from bot_update.
...
R=agable@chromium.org, estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org
BUG=643885
Review-Url: https://codereview.chromium.org/2328883002
9 years ago
agable
3454ae85da
Reland "Delete lots of svn logic from bot_update"
...
This is a reland of 082267a659
which was reverted in 4dcad385f4
BUG=472386
Review-Url: https://codereview.chromium.org/2325513002
9 years ago
recipe-roller
0c2dfcb7ce
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/227f56ba6353986a7fe6d56fb283ad73c84e94d9 Track step nesting in StreamEngine (Reland). (dnj@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:628770
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2325773004
9 years ago
iannucci
0abcd2640a
Fix typobug in bot_update.py.
...
Extra comma changes type from dict to tuple :(
TBR=agable@chromium.org, estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org
BUG=643885
NOPRESUBMIT=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2325763002
9 years ago
recipe-roller
92ded3f292
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/339eace18cba35868b8bbb039100448fbfc58d15 Revert of Track step nesting in StreamEngine. (patchset #5 id:80001 of https://codereview.chromium.org/2245113002/ ) (dnj@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:628770
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2328713002
9 years ago
iannucci
16e7f097a7
Remove bogus master/builder/slave parameters from bot_update.
...
Bot update now always runs regardless of environmental context.
R=estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org, tandrii@chromium.org
BUG=643885
Review-Url: https://codereview.chromium.org/2308193002
9 years ago
iannucci
990ab1b42c
Remove force parameter from bot_update.ensure_checkout.
...
This is the simplest change I can make here. The bot_update.py script already
ignores the value of force (and sets it to True in all cases). This is an
expectations-only change.
I'll refactor the content of the bot_update.py script to account for this
removed option in a followup CL as well.
R=agable@chromium.org, estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org
BUG=643885
Review-Url: https://codereview.chromium.org/2316323002
9 years ago
recipe-roller
1332f33d42
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/4b3ff6014bcb018aff9ae2755faf47cc304f47af Track step nesting in StreamEngine. (dnj@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:628770
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2321813004
9 years ago
agable
dce6ddcd21
Propagate use_relative_paths into recursedeps
...
Currently, if a DEPS file sets use_relative_paths, but *also* sets
recursedeps, then the recursed-upon DEPS files still get checked
out relative to the .gclient root. This change makes it so that
recursed-upon DEPS files check their dependencies out relative to
where their parent wants them to be, if that parent sets
use_relative_paths=True.
R=maruel@chromium.org
Review-Url: https://codereview.chromium.org/2324513003
9 years ago
agable
73baf85348
Update gclient test to assert both dir and url
...
This makes it easier to reason about tests which care about
both the url being fetched and the directory to which it is
being fetched, like those concerning relative paths and
recursion.
R=maruel@chromium.org
Review-Url: https://codereview.chromium.org/2316963004
9 years ago
dsansome
e2d6fd987e
Prompt to delete pending edits before changing the Gerrit CL description.
...
BUG=641838
Review-Url: https://codereview.chromium.org/2318903002
9 years ago
hinoka
eb20eaeced
Copy over bot_update_coverage_test.py
...
BUG=
Review-Url: https://codereview.chromium.org/2316393002
9 years ago
bpastene
4dcad385f4
Revert of Delete lots of svn logic from bot_update (patchset #5 id:80001 of https://codereview.chromium.org/2280213002/ )
...
Reason for revert:
Everything's purple :(
Original issue's description:
> Delete lots of svn logic from bot_update
>
> R=hinoka@chromium.org
> BUG=472386
>
> Committed: 082267a659
TBR=hinoka@chromium.org,hinoka@google.com,iannucci@chromium.org,agable@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=472386
Review-Url: https://codereview.chromium.org/2320653003
9 years ago
bpastene
2a3e9913be
gclient: Prune dangling remote tracking refs when fetching with --force
...
BUG=644722
Review-Url: https://codereview.chromium.org/2320573005
9 years ago
agable
082267a659
Delete lots of svn logic from bot_update
...
R=hinoka@chromium.org
BUG=472386
Review-Url: https://codereview.chromium.org/2280213002
9 years ago
tandrii
8da412cf5a
Remove redundant output in git_cl.py tests.
...
R=agable@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2319903002
9 years ago
martiniss
925b910ac3
Revert of Require recipe tryjob in CQ (patchset #1 id:1 of https://codereview.chromium.org/2157503003/ )
...
Reason for revert:
Downstream tester messed up now, see https://crbug.com/644609
Original issue's description:
> Require recipe tryjob in CQ
>
> BUG=628801
>
> Committed: ac74456f1e
TBR=phajdan.jr@chromium.org,estaab@chromium.org,iannucci@chromium.org
NOTRY=true
(no try because the tester itself is broken)
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=628801, 644609
Review-Url: https://codereview.chromium.org/2322763002
9 years ago