mbjorge
f2d73522b8
Fix relative file: paths in OWNERS with roots other than '/'
...
If an OWNERS file used the file: directive with a relative file
path, but was using a root other than '/' (e.g.
'/path/to/my/real/root'), then the include resolver would incorrectly
leave a leading '/' on the include path. When os_path.join was then
called, the leading '/' meant the path was treated as an absolute path
and the join did not behave as expected.
Review-Url: https://codereview.chromium.org/2148683003
10 years ago
hinoka
9a0de0b9f1
Add cipd binary support to cit.py
...
BUG=
Review-Url: https://codereview.chromium.org/2117943002
10 years ago
recipe-roller
a543853d41
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/b088fe54ff42ce40f6ccb0fbb51aa12a8f831491 Implement "refs" command for easy lookup of recipe module references (phajdan.jr@chromium.org )
R=phajdan.jr@chromium.org
BUG=none
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Review-Url: https://codereview.chromium.org/2151873003
10 years ago
recipe-roller
15c0b36e4e
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/c445d9dcff82a1cbe10102384b360bd9a5f3688c shtuil.remove: get rid of the flag_smart_tree. (tandrii@chromium.org )
R=phajdan.jr@chromium.org,martiniss@chromium.org,tandrii@chromium.org
BUG=584783
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Review-Url: https://codereview.chromium.org/2143923003
10 years ago
lhchavez
2d1b6dae5a
Support C++11 types in build/include_what_you_use
...
This is a cherry-pick of https://github.com/google/styleguide/pull/159
(plus some code that it depends on).
BUG=627514
TEST=cpplint_unittest.py
Review-Url: https://codereview.chromium.org/2146553003
10 years ago
lhchavez
9b2173c419
Make build/include_what_you_use more consistent
...
This is a cherry-pick of https://github.com/google/styleguide/pull/158/
BUG=627202
TEST=cpplint_unittest.py
Review-Url: https://codereview.chromium.org/2147593002
10 years ago
recipe-roller
d5c7b7adbd
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/3de962bcccb8eac10810d7247618c5c9089b8fe7 shutil.rmtree: transition everything to new implementation. (tandrii@chromium.org )
R=phajdan.jr@chromium.org,martiniss@chromium.org,tandrii@chromium.org
BUG=584783
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Review-Url: https://codereview.chromium.org/2148793002
10 years ago
tandrii
9de9ec66b3
git cl try: Trigger CQ Dry Run by default.
...
If bots are specified manually on command line OR in PRESUBMIT.py,
then old behavior remains, namely triggering just those bots.
Otherwise, git cl try will now trigger CQ Dry Run. This is a good
default and also resolves several bugs:
* https://crbug.com/581150 where git cl try used to load cq.cfg
from infra/config, but that's not always correct for all projects.
* https://crbug.com/625697 where even if cq.cfg is in default location.
it might be outdated.
* https://crbug.com/585237 where git cl try would ignore special
in CL description CQ_INCLUDE_TRYBOTS, which is processed by CQ,
but not git cl try.
BUG=625697,585237,581150
R=sergiyb@chromium.org,emso@chromium.org
Review-Url: https://codereview.chromium.org/2147563003
10 years ago
tandrii
d9e5ce518a
Fix git cl set-commit --clear.
...
aka sergiyb@ was right.
R=sergiyb@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2141283002
10 years ago
recipe-roller
83e4442768
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/6bf9ca763de94c641328900358642ec44cf3932e Set proper result (purple/red) for "Uncaught Exception" and "Failure reason" steps (phajdan.jr@chromium.org )
R=phajdan.jr@chromium.org
BUG=none
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Review-Url: https://codereview.chromium.org/2143373002
10 years ago
recipe-roller
25f1dc3036
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/2b31483ac5f58781c138af391a35ccf3a3f63245 shutil recipe_module: port chromium_utils rmtree implementation. (tandrii@chromium.org )
R=martiniss@chromium.org,tandrii@chromium.org
BUG=584783
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Review-Url: https://codereview.chromium.org/2135383006
10 years ago
recipe-roller
c290ab04d4
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/c3683107b331a0f9f0392c0a376ecf8143b1e2ac Revert of shutil recipe_module: port chromium_utils rmtree implementation. (patchset #2 id:20001 of https://codereview.chromium.org/2146523003/ ) (tandrii@chromium.org )
R=martiniss@chromium.org,tandrii@chromium.org
BUG=584783
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Review-Url: https://codereview.chromium.org/2147703002
10 years ago
recipe-roller
4b9967207b
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/774c69370e740a8a5c85dce90f88a2bbd11911f5 shutil recipe_module: port chromium_utils rmtree implementation. (tandrii@chromium.org )
R=martiniss@chromium.org,tandrii@chromium.org
BUG=584783
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Review-Url: https://codereview.chromium.org/2148493002
10 years ago
tandrii
6b410ec471
Gerrit CQ will not allow customization of CQ label values.
...
R=andybons@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2135313005
10 years ago
recipe-roller
a406fc8802
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/d6ce1c413a63efd635af9cac02d21f52228c97bd Make Step API support type long in commands (borenet@chromium.org )
R=borenet@chromium.org
BUG=
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Review-Url: https://codereview.chromium.org/2147623003
10 years ago
tandrii
2bdadf1e0d
git cl upload: remove no longer aplicable message.
...
R=andybons@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2143693002
10 years ago
tandrii
45f10aecb5
Fix CQ.cfg for Gerrit.
...
Follow up of https://codereview.chromium.org/2144723002 .
BUG=627540
TBR=andybons@chromium.org
Review-Url: https://codereview.chromium.org/2139603004
10 years ago
tandrii
875a01234f
Enable Gerrit CQ on depot_tools project.
...
TBR=andybons@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2144723002
10 years ago
phajdan.jr
27726869d2
tryserver: make it possible to override cwd for get_files_affected_by_patch
...
BUG=584079, 593999
Review-Url: https://codereview.chromium.org/2144473003
10 years ago
recipe-roller
00c2cdbf30
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/ce485a8a394dcc1561b5ecdd337a85002083de5b Fix bootstrap on windows (martiniss@chromium.org )
https://crrev.com/ba76686b6729174d9b7c7900ada4946ea5329632 Revert of Fix bootstrap on windows (patchset #2 id:20001 of https://codereview.chromium.org/2136303002/ ) (martiniss@chromium.org )
R=dnj@chromium.org,martiniss@chromium.org
BUG=
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Review-Url: https://codereview.chromium.org/2138293002
10 years ago
recipe-roller
8cd13991b7
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/0a6ab680699355151bf3387074f4656c48698d72 Fix bootstrap cwd (martiniss@chromium.org )
R=martiniss@chromium.org
BUG=
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Review-Url: https://codereview.chromium.org/2137253002
10 years ago
phajdan.jr
b2580abf45
Manually roll recipes.cfg recipe_engine 2c5509f:9d78ba3
...
TBR=estaab, iannucci, martiniss
BUG=chromium:593999
Review-Url: https://codereview.chromium.org/2132363002
10 years ago
recipe-roller
dee56dd717
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/2c5509f0c2cd87af90844ed597d9aaa108194943 Fix pylint warnings (phajdan.jr@chromium.org )
R=phajdan.jr@chromium.org
BUG=none
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Review-Url: https://codereview.chromium.org/2131183002
10 years ago
phajdan.jr
90b9f5f404
update recipe bootstrap script (2c5509f)
...
BUG=chromium:618127
Review-Url: https://codereview.chromium.org/2131153002
10 years ago
recipe-roller
6874ac10da
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/02034be07bc11acb23994feb2ce3a40d94782d5d Retry all errors in recipe bootstrap script (phajdan.jr@chromium.org )
R=phajdan.jr@chromium.org
BUG=chromium:618127
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Review-Url: https://codereview.chromium.org/2136483002
10 years ago
recipe-roller
d914e91a22
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/ab4c628b8432cb3d3dbcee32a539f486115a329b Retry errors during fetch (phajdan.jr@chromium.org )
R=phajdan.jr@chromium.org
BUG=chromium:618127
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Review-Url: https://codereview.chromium.org/2135563002
10 years ago
zengster
bf47014c1a
Added '.m' pattern to git cl format files to be covered.
...
BUG=
Review-Url: https://codereview.chromium.org/2123283005
10 years ago
recipe-roller
c55ba20c62
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/5f18b96cc381e6c9df75bab13cdb99004e8b6779 Add recipe developer workflow doc. (martiniss@chromium.org )
R=martiniss@chromium.org
BUG=584182
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Review-Url: https://codereview.chromium.org/2131443002
10 years ago
tandrii
4d0545a439
Implement git cl upload --dry-run or --use-commit-queue for Gerrit.
...
Previously, it only worked for Rietveld.
BUG=622828
R=emso@chromium.org,machenbach@chromium.org
Review-Url: https://codereview.chromium.org/2117183004
10 years ago
tandrii
4b233bdb48
Implement git cl set-commit --dry-run for Rietveld.
...
BUG=622828
R=emso@chromium.org,machenbach@chromium.org
Review-Url: https://codereview.chromium.org/2127633003
10 years ago
sergiyb
f8a3b38c36
Report keyboard interrupt as abnormal (infra) failure
...
R=tandrii@chromium.org
BUG=579589
Review-Url: https://codereview.chromium.org/2125713002
10 years ago
phajdan.jr
7dba71bfbc
remove blink_or_chromium gclient config
...
It's not needed after blink merge.
TBR=emso, sergiyb, tandrii
BUG=none
Review-Url: https://codereview.chromium.org/2117063002
10 years ago
tandrii
f9aefb774c
Implement git cl upload -b BUG --bug=BUG.
...
CC=friedman@chromium.org
R=sergiyb@chromium.org
BUG=500658
Review-Url: https://codereview.chromium.org/2117483002
10 years ago
recipe-roller
70c04847b5
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/97de2622765bdf58b51b827f9e9ba07b19e0a1e2 Fix raw_io input placeholders not using unicode. (martiniss@chromium.org )
R=martiniss@chromium.org
BUG=
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Review-Url: https://codereview.chromium.org/2115603003
10 years ago
recipe-roller
44118b1127
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/52e644c188ec824afb9ca763ffd6c11d2ff9db60 Add expanduser to path recipe module. (bpastene@chromium.org )
R=bpastene@chromium.org
BUG=624502
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Review-Url: https://codereview.chromium.org/2112883003
10 years ago
martiniss
6eda05f9e6
Allow git_cl to be called when no default server is given
...
Review-Url: https://codereview.chromium.org/2109253002
10 years ago
tandrii
d0b10a0b31
Remove old compatibility for git_cl_upload branches.
...
R=machenbach@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2116493002
10 years ago
sergiyb
2546dcc080
Do not remove issue from branch after it is landed manually
...
This is consistent with the way CQ works. Also git-cl-archive won't work if
branch looses info about its matching CL.
R=tandrii@chromium.org
Review-Url: https://codereview.chromium.org/2111543002
10 years ago
recipe-roller
ced6ad9364
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/7efa94d613f430f85af7f8c8364f85319ee9fa94 Make it possible to use 'cwd' in api.step.context (phajdan.jr@chromium.org )
R=phajdan.jr@chromium.org
BUG=chromium:593999,chromium:585401
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Review-Url: https://codereview.chromium.org/2112533002
10 years ago
phajdan.jr
4f00aa0b49
infra_paths: keep cache paths super short to avoid long path issues (attempt #2 )
...
This is a reland of https://codereview.chromium.org/2102613002/ .
See https://goto.google.com/ljfzu (Google-internal) for more context. Summary:
- the only builders with chromium checkout affected by this are on chromium.fyi
- we can't clean up old cache directories before switching to new ones
Also see https://goto.google.com/oyxwm why so short directory names are OK.
Similarly https://codereview.chromium.org/2061213002 .
BUG=623575
Review-Url: https://codereview.chromium.org/2102403002
10 years ago
martiniss
575e6766f2
bot_update: Allow patch_oauth2 to work in kitchen
...
site config is not present on builders which use kitchen, so we need to use credentials provided by puppet in the /creds directory.
BUG=624212
TBR=hinoka
Review-Url: https://codereview.chromium.org/2108073002
10 years ago
agable
d4aedc811b
Switch gclient config to default to unmanaged mode.
...
BUG=339055
R=hinoka@chromium.org
Review-Url: https://codereview.chromium.org/2099153003
10 years ago
martiniss
808d7ea4f6
Add upload and issue to git_cl recipe module
...
Depends on https://codereview.chromium.org/2088343002
Review-Url: https://codereview.chromium.org/2087093002
10 years ago
agable
8c51b6f148
Slight fix for gclient readability
...
R=hinoka@chromium.org
Review-Url: https://codereview.chromium.org/2103663004
10 years ago
agable
2697cd19a7
Restore --head/-H to gclient
...
R=dmazzoni@chromium.org, maruel@chromium.org
BUG=109184
Review-Url: https://codereview.chromium.org/2105493002
10 years ago
recipe-roller
42cb56e1b7
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/94866be976d923ef7647641cec47baf345962c15 Add logging to recipe bootstrap script (phajdan.jr@chromium.org )
R=phajdan.jr@chromium.org
BUG=chromium:618127
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Review-Url: https://codereview.chromium.org/2104853003
10 years ago
recipe-roller
a232815b5e
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/2ff633218b008abdc19a3f4d98de5b93a3dd5cd9 fix diffs after unicode (martiniss@chromium.org )
R=martiniss@chromium.org
BUG=
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Review-Url: https://codereview.chromium.org/2100383002
10 years ago
nodir
460d557eec
Revert of infra_paths: keep cache paths super short to avoid long path issues (patchset #1 id:1 of https://codereview.chromium.org/2102613002/ )
...
Reason for revert:
/b/cache dir on slaves were not cleaned up and now disk alerts are firing
please come up with a cleanup strategy before re-landing this CL
Original issue's description:
> infra_paths: keep cache paths super short to avoid long path issues
>
> BUG=623575
>
> Committed: aa0b3b6bd0
TBR=emso@chromium.org,sergiyb@chromium.org,tandrii@chromium.org,thakis@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=623575
Review-Url: https://codereview.chromium.org/2100793004
10 years ago
nodir
ca166003fb
upload.py: honor explicit empty title
...
R=pauljensen@chromium.org
BUG=
TEST=PatchSet 3 of this CL
Review-Url: https://codereview.chromium.org/2096123003
10 years ago
phajdan.jr
aa0b3b6bd0
infra_paths: keep cache paths super short to avoid long path issues
...
BUG=623575
Review-Url: https://codereview.chromium.org/2102613002
10 years ago