Internal teams are relying on git-try as the sole mean to run try jobs so revert
this.
Hopefully most target users (chromium folks) got the message at least once.
R=cmp@chromium.org
BUG=
Review URL: https://codereview.chromium.org/88743003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@237361 0039d316-1c4b-4281-b951-d872f2087c98
Some people just don't want to read chromium-dev@. Wake them up.
R=iannucci@chromium.org
BUG=
Review URL: https://codereview.chromium.org/74273002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@235548 0039d316-1c4b-4281-b951-d872f2087c98
Using "%@" will correctly requote quoted arguments. Tested with repro case.
The fix in r232184 missed the necessary argument quoting.
R=iannucci@chromium.org
BUG=314192
BUG=241769
Review URL: https://codereview.chromium.org/47873010
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@232501 0039d316-1c4b-4281-b951-d872f2087c98
Tested to work now with the repro case of bug 313552.
"/c" was interpreted by cygwin's bash as a path and was replaced with c:/. :(
Using //c seems to be passed through properly.
There is probably other escaping problem but this should be good enough at
this stage.
Ref: http://www.mingw.org/wiki/Posix_path_conversionR=iannucci@chromium.org
BUG=241769
BUG=313552
Review URL: https://codereview.chromium.org/50143013
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@232184 0039d316-1c4b-4281-b951-d872f2087c98
This broke git cl patch due to escaping. I tried removing the double quotes but
it didn't work out. Reverting in the meantime to unblock people until I figure
out a permanent way.
BUG=313552,241769
TBR=iannucci
Review URL: https://codereview.chromium.org/50293009
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@232112 0039d316-1c4b-4281-b951-d872f2087c98
Fix the git-* wrapper scripts, PRESUBMIT.py and .gitignore.
The previous python wrapping scripts assumed python_bin\python.exe. This CL
modifies the wrapping scripts to use python.bat. This requires some quoting
magic and explicitly defer to cmd.exe.
This may break some cases where double quotes are used as arguments. We can't do
miracles on Windows.
R=iannucci@chromium.org
BUG=
Review URL: https://codereview.chromium.org/50563008
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@231888 0039d316-1c4b-4281-b951-d872f2087c98
Since we clobber the .pyc, it's not useful to generate them in the first place.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/8060026
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@103066 0039d316-1c4b-4281-b951-d872f2087c98
This mirrors the git-cl changes by first moving git-try
to git_try.py (which git cl already had), then copying
git-cl to git-try and updating all references to git-cl
and git_cl.py to the corresponding git try references.
The main issue is that in the MINGW/Msysgit case we want
to use the Python in depot_tools since that is 100%
compatible with the Command Prompt. Hence we need
to call it directly and then pass it the name of the
git_try.py script.
Note that 'git-try' will not (ever) work on Windows,
and users should only ever run 'git try'. Hence the
need to modify the output of the command to avoid
further confusion.
Review URL: http://codereview.chromium.org/7114002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89031 0039d316-1c4b-4281-b951-d872f2087c98
Most of them are style issues or variable aliasing.
TEST=Can almost enable pylint warnings
BUG=none
Review URL: http://codereview.chromium.org/4360002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64908 0039d316-1c4b-4281-b951-d872f2087c98
smarter about finding the most appropriate settings file.
Before this change, I inadvertently did a [gcl try] on a chrome-internal
change (it was a trivial change and not really secret, so no harm done).
After this change, that won't be possible.
Also, change breakpad to not upload the exception that is thrown when
the user fails to provide correct log-on credentials.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3390013
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61738 0039d316-1c4b-4281-b951-d872f2087c98
That fixes the common usage "git-try <branch>" so the diff is generated against
a branch.
BUG=46697
TEST=none
Review URL: http://codereview.chromium.org/3433011
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59550 0039d316-1c4b-4281-b951-d872f2087c98
Moved tests/pymox to third_party/pymox
Moved upload.py to third_party/upload.py
Fixed tests so they can run standalone
Fixed the executable bit on some scripts
TEST=none
BUG=34376
Review URL: http://codereview.chromium.org/562031
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37987 0039d316-1c4b-4281-b951-d872f2087c98
Some external contributors need their CL's try'd quickly, but currently its not easy unless we patch locally. This will allow you to submit the rietveld issue number and will do the rest automatically. As well, renable the dry_run option. It was removed.
BUG=None
TEST=git try --issue 12345
Review URL: http://codereview.chromium.org/481006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35881 0039d316-1c4b-4281-b951-d872f2087c98
and append them to the patch sent to the try bots. This is
very useful for chromium+webkit tries.
Review URL: http://codereview.chromium.org/212034
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26817 0039d316-1c4b-4281-b951-d872f2087c98
Make git-try use trychange for both SVN and HTTP try
server submits. Simplifies git-try and reduces chance
of differences in behavior between SVN and HTTP try
job submits.
Exit early if the checkout's configured email address
does not pass validation.
Simplify trychange import.
BUG=none
TEST=git-try submits a job to the try server
Review URL: http://codereview.chromium.org/173394
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@24315 0039d316-1c4b-4281-b951-d872f2087c98
Otherwise, all the parameters are coagulated into a single one.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/119308
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17968 0039d316-1c4b-4281-b951-d872f2087c98
They automatically git clone the original repository and execute the original script. So if they are first in the path, they will be executed. If a user has another git-cl/try in the path prior, these stubs won't be used at all and won't mess with the user's setup.
Also fix a bug with git handling in trychange.py
Review URL: http://codereview.chromium.org/119244
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17737 0039d316-1c4b-4281-b951-d872f2087c98
maruel@chromium.org
szager@google.com
cmp@chromium.org
joi@chromium.org
nasser@codeaurora.org
mhm@chromium.org
shess@chromium.org
mattm@chromium.org
thestig@chromium.org
thakis@chromium.org
yaar@chromium.org
johnnyg@chromium.org
chase@chromium.org