d6db3d5398
Use properties for more members that do not change
...
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7889047
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101950 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
f1c2f43cad
Fix gcl sometimes stripping the new line characters when changing the issue description on the server. This change replaces \n with \r\n before giving the description to the editor on Windows (not through cygwin though), and then replaces \r\n with \n when saving it locally or sending it to reitveld.
...
BUG=95618
Review URL: http://codereview.chromium.org/7875004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101863 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
6ca8bf80b4
Retry "Initial step into making Dependency thread safe""
...
I had forgot one access to _requirements. Now that tests are run, this change is
safer to commit.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7909012
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101856 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
8a312c56e9
GTTF: Make gclient try harder when doing svn cleanup.
...
BUG=96775
Review URL: http://codereview.chromium.org/7922018
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101771 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
0e863f9078
Allow a trailing slash in the rietveld url.
...
Review URL: http://codereview.chromium.org/7894003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101356 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
3c74bc9df5
Fix member lookup to be more stable.
...
Add regression test.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7891061
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101351 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
fae707be99
Fix a typo that resulted in no tests to be run in depot_tools. :(
...
Add a warning when RunUnitTestsInDirectory() finds no test to run to
catch this kind of regression.
Fix all the regressions that where introduced in the meantime...
TBR=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7906009
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101347 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
adcf5b702d
Revert "Initial step into making Dependency thread safe"
...
Broke the tree. :(
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101136 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
89d51c245c
Initial step into making Dependency thread safe
...
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7892034
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101135 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
109cb9d31f
Print diagnosis message when a task is Ctrl-C'ed out
...
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7891058
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101133 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
f36c0ee520
Add diagnostics if an item is run multiple times
...
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7885032
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101117 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
8fbb77614d
Revert to --jobs 1 again.
...
I need to add real thread locking to some Dependency methods. That was long
needed anyway.
TBR=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7891053
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101100 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
91def9be75
Replace check_output() call site into check_call(). Would throw otherwise.
...
subprocess2.check_ouput() doesn't accept stdout argument to correctly mimic
subprocess implementation in python 2.7.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7888042
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101085 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
8b36594b47
Sets --jobs 8 as the default.
...
I've fixed the From() issue that was causing it to hangs. We'll see if anything
pops up again.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7885028
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101084 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
32f9f5ed3e
Retry r100190 "Change git_cl.py to use subprocess2""
...
Now with more fixes and take in account subprocess2.check_output() correctness
w.r.t. stderr.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7866007
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101072 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
485dcab61e
Fix the case where a dep not processed could be set as a requirement.
...
This would result in a hang during gclient sync.
Includes regression test.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7885008
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101070 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
69bc538f97
subprocess2.check_output() doesn't allow stdout, like python2.7's version.
...
Don't bother, but redirect stderr.
TBR=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7865005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100464 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
6a05169568
Use check_call(), not check_output()
...
There is user interaction when the svn credential isn't cached. (Duh)
TBR=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7864007
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100462 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
87e6d33103
Update subprocess2.check_output() to behave like subprocess.check_output().
...
stderr is not redirected by default. stdout is not allowed.
Both were oversight.
Do not override stdin=None in case the user would response to stderr output for
example.
Increase test coverage.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7860041
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100456 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
e3606abc5a
Fix check_output usage in trychange.py
...
Update the command for subprocess.CalledProcessError
TBR=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7860047
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100410 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
2a5b6a2aba
Now that CheckCallAndFilter() throws subprocess2.CalledProcessError, use e.returncode.
...
deferring e.args[0] would throw an error.
TBR=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7859032
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100402 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
73c87e9483
Some callers expect e.stderr to be filled on exception
...
TBR=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7860038
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100393 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
d4b4e11328
Revert r100190 "Change git_cl.py to use subprocess2"
...
Revert r100267 "git cl assumes no shell is used."
It's causing exceptions, r100190 still need some work.
TBR=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7858029
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100390 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
904af08901
SVN.GenerateDiff assumes SVN.Capture captures stderr.
...
TBR=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7787008
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100270 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
b10e1c75ed
git cl assumes no shell is used.
...
This is necessary for msysgit usage on windows.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7858008
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100267 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
0112bfb516
GIT.Capture doesn't throw gclient_utils.Error anymore.
...
Fix case where git-try fails for branch not still uploaded to rietveld.
TBR=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7860004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100244 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
087066c553
Make the rietveld client code ignore file status more often.
...
It's proved to be unreliable.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7857006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100236 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
57bf78d82a
Update docstrings w.r.t. subprocess2.
...
No code change.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7858001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100212 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
e2335ae8fe
Fix support when 2 properties are modified.
...
Add regression test.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7754020
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100209 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
75547c3f98
Fix rietveld when status is only one char
...
Update unit test accordingly.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7754016
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100207 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
77f47793de
Make rietveld_test.py use patches_data.py
...
Also verify source_filename properly.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7849015
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100205 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
a82a8ee4ec
Remove CheckCall, CheckCallError and Popen from gclient_utils.
...
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7846003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100203 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
fd19a3032f
Move sample patches to its own file so it can be reused by rietveld_test.py
...
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7847021
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100201 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
c73a5303dd
Move fail tests into a separate class.
...
Makes the code clearer by separating good and bad use cases.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7850018
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100198 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
eafd7ae790
Change git_cl.py to use subprocess2
...
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7848003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100190 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
bffad37d6f
Remove gclient_utils.CheckCall() from gclient_scm.py
...
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7847004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100185 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
da64d639c1
Remove gclient_utils.CheckCall() usage from scm.py
...
Remove reference to shutil while at it.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7851001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100182 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
ca0f839801
Make gclient_utils.CheckCallError inherit from subprocess2.CalledProcessError.
...
This will simply the transition
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7839038
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100174 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
1ba646fccc
Remove gclient_utils.Popen() usage from gclient.py
...
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7795061
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100173 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
e13e12a8ad
Reorder gcl.py imports and remove gclient_utils.Popen() usage
...
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7840038
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100172 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
13c271b712
Remove usage of gclient_utils.CheckCall() from trychange.py
...
I'd like to eventually remove this function.
TBR=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7795060
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100169 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
ad9c97b6c2
Revert r100162 "Change default --jobs value from 1 to 4.""
...
One day it'll work. It still breaks webkit.
TBR=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7850021
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100168 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
442ab8fcb2
Reapply r99735 "Change default --jobs value from 1 to 4."
...
It should be fine now that requirements with /@ works fine.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7782034
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100162 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
8b8d8bef35
Add lint check against "Foo *bar" and "Foo &bar" declarations.
...
Depends on extension mechanism for cpplint.py: http://codereview.appspot.com/4950069/
Pulls r74 of cpplint.py from:
http://google-styleguide.googlecode.com/svn-history/r74/trunk/cpplint/cpplint.py
Taken from WebKit's fork of cpplint.py.
WebKit patch was: http://trac.webkit.org/changeset/46856
Credit Torch Mobile, Inc. who have contributed the WebKit patch in question.
BUG=none
TEST=Run gcl lint on a CL that has a Foo *bar style declaration.
Review URL: http://codereview.chromium.org/7834045
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100151 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
8baaea7b83
Add automatic is_new=True on git copy or rename.
...
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7847005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100140 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
a19047cdf4
Add support forcopied and renamed files.
...
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/6874006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100138 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
63c2c1d2ad
Add PRESUBMIT.py exclusion for cpplint_chromium.py.
...
Needed for: http://codereview.chromium.org/7834045/
BUG=none
TEST=Check that cpplint_chromium.py does not trigger presubmit warnings.
Review URL: http://codereview.chromium.org/7789033
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100025 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
98023dfb35
Urls with /@ won't be processed correctly when used as a requirements.
...
This is important for parallel checkout.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7840033
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99981 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
ed6ce00382
Centralize testing to make it simpler to test when rename are supported correctly
...
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7789030
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99980 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
6cdac9ef45
Make rietveld status handling saner
...
Add support for a few svn:* properties.
Silently ignore svn:mergeinfo. It's useless once we're switched to git-land anyway.
More testing.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7840003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99952 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org
jam@chromium.org
phajdan.jr@chromium.org
craig.schlenter@chromium.org
asvitkine@chromium.org