This is required as it is impossible to catch a keyboard interrupt in a
windows batch file and we dont want zombie reproxy instances running on
developer's machines for performance and metric collection reasons.
Bug: b/264405266
Change-Id: I00f036c8f14451cdb1b99a5cad1c2af03dd57d57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4171506
Reviewed-by: Dirk Pranke <dpranke@google.com>
Auto-Submit: Ben Segall <bentekkie@google.com>
Commit-Queue: Ben Segall <bentekkie@google.com>
This reverts commit b6a0b58b9f.
Reason for revert: we should have a good coverage now within just
chops source. You are welcome to stay owner if you'd like tho.
Original change's description:
> Add iannucci to depot_tools owners
>
> Change-Id: Ic85057a6075ba398e4800edffd183f5e2eccd259
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3440929
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Change-Id: I0a5138d8a119d2d2699e04857c95e6f2875aaac0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3657058
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
I feel like a PRESUBMIT owner now and this makes it official.
Bug: 1309977
Change-Id: I38356bc52c8d03d93c4ec42e4952b5872b31a79a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3589901
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
I'll be out for a while, so I'm removing myself from various
OWNERS files to avoid confusion.
Change-Id: Icfc161229f8376c856a25a4f4849270bd9f39924
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3434226
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
We deleted this in chromite back in 2013. Looks like we forgot to
clean up depot_tools.
Bug: 216050
Change-Id: I7e7591aaa319ab1aeb7cc3f34e33b313b5029257
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2812199
Reviewed-by: Stephane Belmon <sbelmon@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
This is a reland of 19512276d2.
It includes an update to .gitattributes for recipes.
Original change's description:
> repo: auto-update depot_tools when used
>
> Since gclient automatically syncs this checkout when used,
> have repo do the same for CrOS users.
>
> Bug: 1148984
> Test: ran and saw it auto-update when used externally
> Test: ran and saw it not auto-update when used inside of a repo checkout
> Change-Id: I56b9a45ef3a9ed501f6277e8f8357d4719cf2557
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2537164
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Michael Mortensen <mmortensen@google.com>
> Commit-Queue: Mike Frysinger <vapier@chromium.org>
Bug: 1148984
Change-Id: Ia7844016cb04d3197e51ad05da64c885cf3277a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2561229
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
This reverts commit 19512276d2.
Reason for revert: broke ART bots.
Bug: 1153114
Original change's description:
> repo: auto-update depot_tools when used
>
> Since gclient automatically syncs this checkout when used,
> have repo do the same for CrOS users.
>
> Bug: 1148984
> Test: ran and saw it auto-update when used externally
> Test: ran and saw it not auto-update when used inside of a repo checkout
> Change-Id: I56b9a45ef3a9ed501f6277e8f8357d4719cf2557
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2537164
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Michael Mortensen <mmortensen@google.com>
> Commit-Queue: Mike Frysinger <vapier@chromium.org>
TBR=vapier@chromium.org,ehmaldonado@chromium.org,mmortensen@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,mmortensen@chromium.org
Change-Id: Ic0ac9155e3acde87966f518213a5a8440e167295
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1148984
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2560955
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Since gclient automatically syncs this checkout when used,
have repo do the same for CrOS users.
Bug: 1148984
Test: ran and saw it auto-update when used externally
Test: ran and saw it not auto-update when used inside of a repo checkout
Change-Id: I56b9a45ef3a9ed501f6277e8f8357d4719cf2557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2537164
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
I've consistently switched over to using dpranke@google.com for all
my work and should no longer have the @chromium.org address listed
in OWNERS.
Change-Id: Ibafa6d0fe0c0673a3216ade62b5997af62b06e76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2335909
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
I've switched to using my @google.com address for most work,
so adding it to //OWNERS here.
I'm not removing my @chromium.org address yet, just to make
switching over a bit easier.
Change-Id: If8d6ac06a5193eac79bbd32ea9a5524dcf24b1dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2276571
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
And allow us to self-service this file in the future.
Change-Id: I699480919bcb41250552123e691ddf1432077003
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2231900
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Change-Id: Iac0797ddb6331d5b07f9919932560519d78c640a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2226049
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Bruce created the script and is most qualified to review changes to it.
Bug: None
Change-Id: I238c88ad03db422f9c7f5b2760ff2dd25d431e65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2141224
Commit-Queue: Peter Wen <wnwen@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
The Goma team releases the Goma client in depot_tools via CIPD.
Let me add all the Goma client release rotation so that they do not
need to wait for the review.
Bug: b/148421866
Change-Id: I45eb24ac8c34bba2183c16e72dcf0a9d7f13d603
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2040850
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
goma team will release goma client cipd in depot_tools,
by modifying cipd_manifest.txt and cipd_manifest.versions
add ukai as OWNERS so that goma cilent release won't need
to wait for review.
Change-Id: I7f49d9c07b23d18c4a05ab11bea855d3f557a6ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2024208
Auto-Submit: Fumitoshi Ukai <ukai@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
This is used to help people figure out where to file bugs against
code in the repo.
Change-Id: I0253359f703c67116785995b84ed5ff0bbcae28c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1796610
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
I added document explaining ninjalog collection.
This document explains what type of data is collected and how the data will be used.
Bug: 900161, b/120645342
Change-Id: If47517aaa7a5510e4a634b5ccc0e4127d014dcb9
Reviewed-on: https://chromium-review.googlesource.com/c/1381912
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
This syntax seems to be invalid, so remove it to unblock others.
Bug: 900461
No-Presubmit: True
Change-Id: I16569b8f8236a14b6dc879c973e4925a99649ac2
Reviewed-on: https://chromium-review.googlesource.com/c/1382975
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
This CL introduces ninjalog_uploader to autoninja for posix environment.
This is to collect build statistics from googler to find user side build performance bottleneck.
ninjalog_uploader_wrapper is used to notify user and manage small config of upload script.
Bug: 900161
Change-Id: I48ac8cd1d52f64e8fdafaec43636d2d79ef9040d
Reviewed-on: https://chromium-review.googlesource.com/c/1345255
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
bradleynelson is no longer active in depot_tools. agable@ is
unavailable for the rest of 2018.
Change-Id: Idf5be1db84b8f6857f9edd7ed16c56d4c89f81ef
Reviewed-on: https://chromium-review.googlesource.com/1256170
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
He's been doing great work in depot_tools over last year,
and has sufficient knowledge to know when to review and when to find
better reviewers for this repo.
R=ehmaldonado@chromium.org
Change-Id: Idc8c9103906b9a48b69c4a2743e344d0886a759d
Reviewed-on: https://chromium-review.googlesource.com/1213589
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
I think the statute of limitations has run out on me.
I'm no longer on the infra list so OWNERS doesn't make much sense.
Change-Id: I3b3815d5f93980574c319d74438e0a3732a25680
Reviewed-on: https://chromium-review.googlesource.com/1011461
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
This code appears unused, and if it is used, it isn't useful anymore.
R=tandrii@chromium.org
Bug: 770408
Change-Id: I8b96a119be8ed20132e0b7439e466ad90f3757c2
Reviewed-on: https://chromium-review.googlesource.com/693337
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
Ben Segall
Brian Ryner
Dirk Pranke
Joanna Wang
Josip Sokcevic
Jochen Eisinger
Bruce Dawson
David Dorwin
Edward Lesmes
Mike Frysinger
Edward Lesmes
Gavin Mak
Andrii Shyshkalov
Scott Lee
Aaron Gable
Peter Wen
Robert Iannucci
Yoshisato Yanagisawa
Anthony Polito
Fumitoshi Ukai
Dirk Pranke
Takuto Ikuta
Andrii Shyshkalov
Peter Mayo
Paweł Hajdan, Jr
Takuto Ikuta