Test case being added in https://codereview.chromium.org/1984623002/
NOTICE:
* Only patches from the webrtc/ subdirectory in a standalone
WebRTC checkout will work, since the root is set to src/third_party.
This can be changed once http://crbug.com/611808 is fixed.
* The Chromium checkout will be synced to the DEPS-pinned revision
of WebRTC. Changing this to HEAD will be addressed in a future CL.
BUG=438952
Review-Url: https://codereview.chromium.org/1976243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300588 0039d316-1c4b-4281-b951-d872f2087c98
I often ends up with a corrupt toolchain because I've used Windbg and there's now a bunch of PDB files in win_sdk/Debuggers/sym/... , I think that it's safe to ignore these files (the original package doesn't contain any of these files).
It's also useful to have more details about which files are missing and or which ones shouldn't be here when we get an invalid toolchain hash.
Finally, if you the hash of a toolchain doesn't correspond to the name of its root directory then it should be removed.
Review-Url: https://codereview.chromium.org/1974453003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300557 0039d316-1c4b-4281-b951-d872f2087c98
This change adds a --override option to the VC++ packaging script so
that an arbitrary bin/include/lib containing directory can be used to
package up those components of VC++. See this post for details:
https://blogs.msdn.microsoft.com/vcblog/2016/02/16/try-out-the-latest-c-compiler-toolset-without-waiting-for-the-next-update-of-visual-studio/
Typical usage is like this:
package_from_installed.py 2015 --override <projdir>\packages\VisualCppTools.14.0.24109-Pre\lib\native
In order to make this work the path tuple support was fixed so that the
local relative path was propagated to the destination path, instead of
just the file name.
At the same time, the code to package up the UCRT installers was deleted
because it isn't needed, and windows.winmd is filtered out because it
makes consistent package creation impossible (it is different on every
machine).
While removing the UCRT installers I discovered nested if VS_VERSION
checks. Oops. Fixed.
BUG=440500
Review-Url: https://codereview.chromium.org/1967653002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300527 0039d316-1c4b-4281-b951-d872f2087c98
This was breaking presubmit because the linked gae_ts_mon subdir was absent.
R=andybons@chromium.org, dsansome@chromium.org, dnj@chromium.org
BUG=608490
Review-Url: https://codereview.chromium.org/1959193002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300511 0039d316-1c4b-4281-b951-d872f2087c98
Also make _RietveldOwnerAndReviewers have same semantics as before,
to resolve immediate bug until chromium checkouts of developers are
updated.
BUG=609832
R=machenbach@chromium.org
Review-Url: https://codereview.chromium.org/1955223002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300494 0039d316-1c4b-4281-b951-d872f2087c98
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/c4983774444a86eab0eef16173345ccde1eb32c1 Change sys.exit to os._exit to make sure the recipe engine really quits (iannucci@chromium.org)
R=dpranke@chromium.org,estaab@chromium.org,iannucci@chromium.org,martiniss@chromium.org
BUG=522396
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Review-Url: https://codereview.chromium.org/1954153004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300486 0039d316-1c4b-4281-b951-d872f2087c98
This is a cherry-pick of the GitHub commit, created after merging relevant
changes from Google's internal cpplint.py implementation.
456 - Tweak lint to sometimes allow { on line following array initialization.
455 - Recognize more types.
454 - Try a bit harder to detect templated types.
453 - Changed error message wording on build/storage_class to be less ambiguous.
452 - Recognize more types to silence false positives for brace warnings.
451 - <skipped>
450 - <skipped>
449 - Ignore whitespace/tab for Linux Kernel files.
448 - Remove some more false positive lint warnings for int64{n}.
447 - Just one warning message for line length is enough, don't need two.
446 - Allow braced conversions to int16, uint64, etc. per the style guide.
445 - Fixed handling of backslash escapes for checking whether a "//" is quoted.
444 - Reduced dependency on hardcoded .cc extension.
443 - Disable single-arg constructor checks by default, since ClangTidy has the
same check. We could just delete the check entirely, but it's slightly
useful in places that can't run ClangTidy.
442 - Fix matching of macro names in CheckTrailingSemicolon to include digits.
441 - Deleted checks:
- All checks for RValue references.
- Spacing check around boolean &&, because those look like RValue
references.
A huge amount of code and effort were dedicated to tell RValue
references apart from boolean expressions, and to differentiate
allowed versus banned RValue references. But we still get regular
false positives from this one check. Rather than making the check
more complex than what it already is, it seemed safer to just delete
it altogether for now, and have a different process for catching
RValue references.
440 - Add rule to cpplint to throw error on empty if statement bodies without
else clauses. If statement bodies with comments are not considered empty.
439 - Allow spaces before closing brace of namespace block so that namespaces
inside of macro definitions (where the entire macro definition is
indented) are not treated as errors.
438 - cpplint: fix a false positive on `new const int(x)`.
437 - Only check for function length when current line is inside a function.
436 - cpplint: Catch static `std::string` instances as well as those written as
`string`. Previously users would sometimes work around the lint warning by
changing their code to even worse code by adding the "std::" prefix.
435 - cpplint: Be a little smarter about warning on indentation.
434 - cpplint: Remove false positives on some functions returning string const&.
433 - cpplint: improve diagnostics of global/static string objects.
432 - Allow non-const reference parameters for iostream based types.
431 - Better handling of raw strings inside comments.
430 - <noop>
429 - <skipped>
428 - <skipped>
427 - Add support to CHECK_NOTNULL when checking if a member variable is
initialized with itself.
426 - Allow suppressing specific warnings in C headers.
425 - Allow spaces before parens for inline assembly.
424 - Remove lint checks for {EXPECT,ASSERT}_.*_M.
423 - Allow comment lines of more than 80 characters if they contain a single
"word" (without any spaces).
422 - cpplint: Warn on inclusion of C++14 headers.
421 - cpplint: recognize <shared_mutex> as a standard library header.
420 - Add <scoped_allocator> to cpplint's list of C++ standard headers.
419 - Add cpplint check for tr1/ headers. We removed the nanny guards for these
418 - <skipped>
417 - Update the styleguide and cpplint to allow unnamed parameters
416 - Remove the rule explicitly banning non-default move operations.
415 - Remove the check for explicit multi arg constructors
414 - Include clarity of lambda default captures in "pros" section, mention
of capturing `this` and lambdas which escape the current scope in "cons".
Soften the ban on default captures to a preference, with admonition against
using them for capturing `this` or when they will escape the current scope.
This is a fairly straightforward change with a brief inclusion
of 2 problematic cases for implicit capture. As this is the style
guide, I'm not sure how much more detail is appropriate.
413 - Fixed a bug by making regex in CleanseRawStrings match multiple raw strings
on a single line in left-to-right order.
412 - Fixed false positive for classes derived using decltype()
411 - <skipped>
410 - Recognize '1LL<<20' as numeric and don't flag it for spacing.
BUG=
Review-Url: https://codereview.chromium.org/1959503003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300481 0039d316-1c4b-4281-b951-d872f2087c98
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/614e66740642550cba38bc78a2776866dae66ea6 Use subprocess42 in recipe_engine to avoid threading madness. (iannucci@chromium.org)
R=estaab@chromium.org,iannucci@chromium.org,maruel@chromium.org,martiniss@chromium.org,tansell@chromium.org
BUG=522396
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Review-Url: https://codereview.chromium.org/1960713002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300472 0039d316-1c4b-4281-b951-d872f2087c98
This will allow ANGLE to have a recursible deps-file in their repo instead of
relying on chromium's DEPS file to specify an accurate dependency for itself.
Previously: https://chromiumcodereview.appspot.com/1919103003/
R=agable@chromium.org, dpranke@chromium.org, jmadill@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/1948853002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300446 0039d316-1c4b-4281-b951-d872f2087c98
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/0eba5ac3953b892d26a5a91decf84730261e1d09 Make the pipe-reader threads daemon threads. (iannucci@chromium.org)
R=estaab@chromium.org,iannucci@chromium.org,martiniss@chromium.org,tansell@chromium.org
BUG=522396
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Review-Url: https://codereview.chromium.org/1949003002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300434 0039d316-1c4b-4281-b951-d872f2087c98
This CL fixes an issue where map branches would hang when trying to
retrieve a deleted issue due to a long timeout. This has been fixed by
reducing the timeout.
This CL also fixes a small issue where {NO_UPSTREAM} would show the
current branch's codereview URL.
BUG=470765
Review-Url: https://codereview.chromium.org/1847693004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300369 0039d316-1c4b-4281-b951-d872f2087c98
Reason for revert:
splitlines man
Original issue's description:
> git_cl: Add the ability to set the description.
>
> BUG=607359
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300357
TBR=iannucci@chromium.org,tandrii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=607359
Review-Url: https://codereview.chromium.org/1935633002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300360 0039d316-1c4b-4281-b951-d872f2087c98
Reason for revert:
now it doesn't work for gerrit. Damn it.
Original issue's description:
> Implement owners check in presubmit for Gerrit.
>
> R=machenbach@chromium.org,phajdan.jr@chromium.org
> BUG=605563
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300350
TBR=machenbach@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605563
Review-Url: https://codereview.chromium.org/1935563002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300352 0039d316-1c4b-4281-b951-d872f2087c98
Reason for revert:
Was me - too fast to pull the revert trigger. The CL in question has notry set to true :(
Original issue's description:
> Revert of git cl try: don't skip presubmit builders, but set dry_run property. (patchset #2 id:20001 of https://codereview.chromium.org/1926663002/ )
>
> Reason for revert:
> Now only presubmit is scheduled on dry run, example CL:
> https://codereview.chromium.org/1804003002
>
> Original issue's description:
> > Reland of git cl try: don't skip presubmit builders, but set dry_run property.
> >
> > With a fix: actually set dry_run for presubmit, and don't set it for other builders.
> >
> > R=machenbach@chromium.org,sergiyb@chromium.org
> > BUG=601128,594127,591030
> >
> > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300295
>
> TBR=sergiyb@chromium.org,tandrii@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=601128,594127,591030
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300337
TBR=sergiyb@chromium.org,tandrii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=601128,594127,591030
Review-Url: https://codereview.chromium.org/1930363003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300338 0039d316-1c4b-4281-b951-d872f2087c98
Reason for revert:
Now only presubmit is scheduled on dry run, example CL:
https://codereview.chromium.org/1804003002
Original issue's description:
> Reland of git cl try: don't skip presubmit builders, but set dry_run property.
>
> With a fix: actually set dry_run for presubmit, and don't set it for other builders.
>
> R=machenbach@chromium.org,sergiyb@chromium.org
> BUG=601128,594127,591030
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300295
TBR=sergiyb@chromium.org,tandrii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=601128,594127,591030
Review-Url: https://codereview.chromium.org/1928373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300337 0039d316-1c4b-4281-b951-d872f2087c98
This is a preparation for removal of infra-specific
paths from the recipe engine.
BUG=chromium:605919
Review-Url: https://codereview.chromium.org/1930373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300335 0039d316-1c4b-4281-b951-d872f2087c98
This is different from previous attempt https://codereview.chromium.org/1915463002 .
The change is completely backwards-compatible, and doesn't introduce recipe
expectation changes.
Modules can be switched to depend on infra_paths independently,
without any expectation changes either.
By moving path module's config.py to paths_config.py here, we also guarantee
that the returned results are going to be exactly the same.
Depends on https://codereview.chromium.org/1923363003 .
BUG=chromium:605919
Review-Url: https://codereview.chromium.org/1926033002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300324 0039d316-1c4b-4281-b951-d872f2087c98
This was broken in r299682 (adding setup_color). git_hyper_blame now
initializes setup_color.
BUG=607771
Review-Url: https://codereview.chromium.org/1930813003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300316 0039d316-1c4b-4281-b951-d872f2087c98
With a fix: actually set dry_run for presubmit, and don't set it for other builders.
R=machenbach@chromium.org,sergiyb@chromium.org
BUG=601128,594127,591030
Review-Url: https://codereview.chromium.org/1926663002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300295 0039d316-1c4b-4281-b951-d872f2087c98
This will allow ANGLE to have a recursible deps-file in their repo instead of
relying on chromium's DEPS file to specify an accurate dependency for itself.
R=agable@chromium.org, jmadill@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/1919103003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300293 0039d316-1c4b-4281-b951-d872f2087c98
tandrii@chromium.org
kjellander@chromium.org
recipe-roller@chromium.org
sebmarchand@chromium.org
brucedawson@chromium.org
hans@chromium.org
iannucci@chromium.org
phajdan@google.com
dbeam@chromium.org
avakulenko@chromium.org
phajdan.jr@chromium.org
martiniss@chromium.org
calamity@chromium.org
estaab@chromium.org
machenbach@chromium.org
mgiuca@chromium.org
bsep@chromium.org
rmistry@google.com