Commit Graph

24 Commits (9aca104a0f04072cf28643a5d5be6b372b0612e2)

Author SHA1 Message Date
maruel@chromium.org bb12314170 Use --nohooks when gclient sync in apply_issue.
Otherwise the try slaves run the hooks twice, once in the apply_issue, another
in the runhooks step. It is unnecessary. It will reduce the problem with
apply_issue timeouts.

TBR=xusydoc@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11362176

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166826 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
maruel@chromium.org fc490ffc98 Disable buffering in apply_issue.py to try to find out the problem.
apply_issue step hangs and the output is often in the reverse order. This CL is
to help diagnose the problem.

TBR=cmp@chromium.org
BUG=159868


Review URL: https://chromiumcodereview.appspot.com/11359093

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166505 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
maruel@chromium.org 93477fd5fa Add another print statement to debug apply_issue problem.
TBR=cmp@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11366030

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@165354 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org 370a623c70 Add a print to figure out where the hang occurs.
TBR=rogerta@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11235034

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@163342 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org a73435aa98 Fix private issues, take two.
The object creation order was wrong

TBR=rogerta@chromium.org
BUG=149941


Review URL: https://chromiumcodereview.appspot.com/11024009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159524 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org 0aca0f9684 Enforce the checkout object to use an absolute path.
Stop using stderr so the output is more readable on buildbot.
Otherwise stderr arrives before stdout in apply_issue step.

TBR=rogerta@chromium.org
BUG=153284


Review URL: https://chromiumcodereview.appspot.com/11038002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159508 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org 4dd9f7205a Make apply_issue.py much more verbose about what it's doing.
It's to help users figuring out what is happening.

TBR=rogerta@chromium.org
BUG=153284


Review URL: https://chromiumcodereview.appspot.com/11028002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159504 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org 9d5f4ad1b9 Works around rate limiting by trying to apply CL unauthenticated first.
TBR=rogerta@chromium.org
BUG=153284


Review URL: https://chromiumcodereview.appspot.com/11019015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159488 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
rogerta@chromium.org 9824629157 Allow the password to be specified through stdin.
BUG=149941

Review URL: https://chromiumcodereview.appspot.com/10958049

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@158068 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
rogerta@chromium.org 33578fe270 Allow the caller to specify a username and password so that private issues
can be applied.  This is the first part for this bug; the second part is in commands.py where this is called by the TS.

BUG=149941

Review URL: https://chromiumcodereview.appspot.com/10917306

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@157355 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org 6afd0c36e8 Do not assume gclient is in the PATH.
Also specify the batch file on Windows. Python's subprocess is picky about that.

TBR=rogerta@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/10939008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@157337 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org 1833e57b47 When a DEPS file is modified, run gclient sync.
It runs it by specifying BASE/HEAD to stay at the current revision.
This works around the lack of gclient sync when a DEPS file is applied on the
Try Server when triggered from Rietveld. This was handled my the Try Server
inside scripts/slave/chromium_command.py manually in the case a 'patch' is
specified.

TBR=rogerta@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/10918264

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@157110 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org 9d72d2b9e0 Ensure buildbot knows that the checkout was patched when patching.
R=rogerta@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/10905160

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@155506 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org 083cd45914 Fix apply_issue.py to work on python 2.6 with anonymous request.
Fix RawCheckout support in apply_issue.py.

TBR=rogerta@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/10908063

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@154703 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org 3bf4b3c864 Enable anonymous apply_issue behavior by default and only fall back to login when needed.
Patch in upload.py fix for python 2.7.

TBR=rogerta@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/10914068

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@154696 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org 9dbbe54f8f Handle when a patchset doesn't exist instead of printing a stack trace.
Print a meaningful error message so the user can try diagnosing himself.

R=rogerta@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/10913026

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@154436 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org 38ab82d6d8 Add outputs to apply_issue.py
apply_issue.py didn't have output, making it a bit boring. Now it's super cute.

R=rogerta@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/10889037

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@153948 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org 827cb81918 Due to a temporary bug in the try server, ignore '=' as an email address.
This CL shall be reverted once the try server is fixed.

R=rogerta@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/10900029

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@153916 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
rogerta@chromium.org ed2332542c Allow apply_issue.py to make api calls to rietveld that don't require
authentication.  Also allow apply_issue.py to specify a username if needed.

BUG=43563
TEST=Make sure that sending try jobs directly from rietveld works.

Review URL: https://chromiumcodereview.appspot.com/10704111

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@145600 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org 34f6855218 Improve error message in patch application failure.
Make exception PatchApplicationFailed() self printable.

R=cmp@chromium.org
BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10391033

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@136091 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org 5e975633a8 Fix handling of file renames.
The patches needs to by applied 'in-order' to not delete source files.

Added more tests.

R=dpranke@chromium.org
BUG=94330
TEST=

Review URL: http://codereview.chromium.org/8038056

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@103309 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 58fe662dc7 Add support for empty files, __init__.py is a common example.
Use p.is_new signal and set it manually with rietveld patches.
Add regression test for +x.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7054057

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87858 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 3cdb7f3661 Complete apply_issue.py.
This is to be able to apply patches directly from rietveld for the try server.

TEST=tested on both svn and git with binary files. unit tests will follow up.
R=dpranke@chromium.org
BUG=

Review URL: http://codereview.chromium.org/6904152

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@84255 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 61e0b691d6 Add script to apply a patch from rietveld.
At the moment it just fetches the patch. It's still useful to debug rietveld
issues.

Improve resiliency to invalid patches.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6825085

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81305 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago