6d7ab1bfe5
Refactor ReadHttpResponse to be error-friendlier
...
Gerrit sometimes returns a full response json object at
the same time as returning a non-200 status code. This
refactor makes it easier for calling code to request
access to that object and handle error cases on its own.
Bug: 710028
Change-Id: Id1017d580d2fb843d5ca6287efcfed8775c52cd6
Reviewed-on: https://chromium-review.googlesource.com/479450
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
f2708bd74a
[git-cl] add --r-owners
...
This will be useful for tools like the recipe autoroller to
semi-intelligently choose a collection of reviewers.
Bug:
Change-Id: I7a238127e126340c033fc8e80523ef2408ebf970
Reviewed-on: https://chromium-review.googlesource.com/479679
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
9c0930ef20
setup_color.py should not be executable, as it pollutes $PATH.
...
R=iannucci@chromium.org
Change-Id: Ieb9d76736203a346d8364c6c0448d9bb4391a3f7
Reviewed-on: https://chromium-review.googlesource.com/475832
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
550e924d20
Gerrit git cl upload <diff_base>: respect diff_base argumnent.
...
This CL propagates <diff_base> all the way to become parent commit
of the syntentic commit generated by squashing the current branch.
BUG=649846
R=agable@chromium.org
Change-Id: Ided7ebbb5c3a1114cac18adb62b3a9c27610018c
Reviewed-on: https://chromium-review.googlesource.com/475229
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
d0573ec067
Use OldContents() for OWNERS files to do checks
...
BUG=141253
R=dpranke@chromium.org
Change-Id: Iacbc2f0571e725e4f2ccf5ea7878f101972289bb
Reviewed-on: https://chromium-review.googlesource.com/476610
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
8 years ago
7d1681b412
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/d4e0f46079a50a1707240e214809bf4bbac63bc6 [package] fix race in cleanup_pyc. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Change-Id: Ie3a314ff2e4676187ff190c72a469bbed02fdf66
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/479152
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
8 years ago
971533c2ae
[recipes.cfg] add autoroll options.
...
TBR=dnj@chromium.org
Bug:
Change-Id: I6f607578197408734da238189465ae1ff6a2000d
Reviewed-on: https://chromium-review.googlesource.com/478833
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
8 years ago
01dfb361e5
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/71848f7add95e74692387c3feadaee93e185169d [autoroll] exclude recipes_simulation_test stdout from non-verbose json. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Change-Id: I07f0e821dbaed7771cf5bf796083ae98bc084c8a
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/479051
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
8 years ago
2093ebefcf
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/b7cd5ee1ea736116d35559ff0e2fb61081d1ca01 [autoroll] Count empty rolls as successful. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Change-Id: I841a8ba5845bfe9149627c9e2a5b26376372704f
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/478651
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
8 years ago
7a9b425ddb
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/cb0d71bf2638680b85a7937ab57add4ba776ade0 Speedier autoroller algorithm. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Change-Id: I047f940bc70f0bdbe4fd6b918b850077af6ba1bf
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/478431
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
8 years ago
48f1fdcd07
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/a161d97046d010134d81308a27b9c6490b090005 errors_test: switch to new 'test' command (phajdan.jr@chromium.org )
https://crrev.com/88d8d807fbcd9c59be19dbb1068c63fab11b1915 Add post_process hooks to verify recipe result (phajdan.jr@chromium.org )
TBR=iannucci@chromium.org
Change-Id: I5c1c5be5761e3fc62064ff326e27a109cf14d166
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/478251
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
8 years ago
9b9b94c412
[presub] lstrip line limit exceptions; ignore <g and <path
...
Previously, the <link lines in HTML are allowed to have longer than 80 characters.
This CL adds <g and <path to the HTML lines that may have unlimited characters.
(These g and path tags are used in svg image data).
These HTML exemptions also have a trailing space. The space is intended to reduce
false-positives in matching. There are some occurrences of these tags followed by a
\n which will not match (but the line ends there, so it's not an issue).
These new tags may be preceded by blank space so .lstrip() was added to
the test. I believe this .lstrip() should not be an issue for the other
languages and exemptions present.
Bug: None
Change-Id: Ie9c2bca0e7147033e360ddcfc6eee3b73e167228
Reviewed-on: https://chromium-review.googlesource.com/477371
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
8 years ago
cc45863958
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/0afe202a0f678a31dd725b31268e9629ead6f20a [autoroll] make json even less verbose, use nicer keys. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Change-Id: I26ae23a4b0bbea66b24dfc5a988a317a0f8e7209
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/477670
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
8 years ago
d67e7158df
Fix GetOldContents() to return an empty string if the file didn't exist.
...
Bug: 700108
Change-Id: I9010aa3b4aa467c91b93ffac924b3ec5a16cfaa2
Reviewed-on: https://chromium-review.googlesource.com/476590
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
8 years ago
3a3de33b72
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/3a3f9c4eb9219f52e3203f38ac38de87b31daeb4 [autoroller] remove unused diff field. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Change-Id: I0dd92aec95984574b577785f51d141fbf6b50606
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/476313
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
8 years ago
f84a8abf44
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/a7afc5a62ed0e2c5237785128159a65921816796 [autoroll] remove unused --projects option. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Change-Id: I3028cd65c26e98bba04c48418e5b589f3d35e1eb
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/476191
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
8 years ago
2c8a25e3ea
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/7d77ae17f27d76191bc42e370de2b19b4cdd66bd [autoroll] make rejected_candidate_details optional. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Change-Id: I84b3e5a51bdf8d404422c6e2f5faf2f7eeb3f79f
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/476312
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
8 years ago
9705d61c7c
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/c0de54ec5af381455323647cf5611ef51a2db3a6 [bootstrap] make ultimate invocation more isolated (iannucci@chromium.org )
TBR=iannucci@chromium.org
Change-Id: I9d4a58a3396a6dddb55d85d852d008390793584a
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/476270
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
8 years ago
8dd4edae99
bot_update: Show failed patch in "Patch Failure".
...
Have "bot_update.py" export the failing patch body in its JSON. Have the
recipe actually emit the patch body in the "Patch Failure" step instead
of the "bot_update" step, and remove the "Patch Failure" step's
indirection to the "bot_update" step for patch failure.
This will provide a more straightforward user interface: the red step
that says "Patch Failure" now includes the details of the patch failure!
BUG=chromium:710477
TEST=expectations
Change-Id: I6ad305f0b972de89e4f0b5eb70edf41980447abd
Reviewed-on: https://chromium-review.googlesource.com/475950
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
8 years ago
3978290b21
Enable strict coverage for all modules
...
Bug: chromium:693058
Change-Id: I6e00f73141722dc47f8da16e21dadd1d4e26a14f
Reviewed-on: https://chromium-review.googlesource.com/475911
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
8 years ago
313c4e4430
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/6357a418547dc444ed93544fa236642515f8ddca Correctly handle unused expectations for recipe module tests (phajdan.jr@chromium.org )
TBR=iannucci@chromium.org
Change-Id: Ifebcc357d97c76e843d953917d67d9587860368f
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/475167
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
8 years ago
f4597a4f91
bot_update: add with_tags argument to ensure_checkout
...
Bug: 710817
Change-Id: Ifb2a9abe605d9e403c55ec1360d186af12dd2f34
Reviewed-on: https://chromium-review.googlesource.com/475775
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
8 years ago
7ac2c9a292
bot_update: add --with_tags switch
...
Bug: 710817
Change-Id: Ice7cefaf5c5a5cac431a95d3adfa44f323eafb2f
Reviewed-on: https://chromium-review.googlesource.com/475230
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
8 years ago
73827d154b
Refactor git cl tests.
...
R=machenbach@chromium.org
Change-Id: I54f4a0507352f4d4e460188c9bc6425ff83f28bb
Reviewed-on: https://chromium-review.googlesource.com/475910
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
413b9ccff1
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/addc0640c912a43c6ea02dbfda992407cc9957ff Revert of path: Add tracking of volatile paths. (patchset #3 id:40001 of https://codereview.chromium.org/2808713003/ ) (dnj@chromium.org )
TBR=iannucci@chromium.org
Change-Id: I1b643d307efcfc0dbbc7b9e575e9df7e9f6d4d9d
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/475166
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
8 years ago
e05d488235
git cl tests: improve readability of test helper.
...
Shorten lines and remove useless stacktrace to make sure the actually
usefull exception fits on tandrii@'s screen :)
R=sergiyb@chromium.org
Change-Id: I387da6c70f72a122d64f7a044d201d72a858fc3f
Reviewed-on: https://chromium-review.googlesource.com/475811
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
fcc67b45a5
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/d6ceb66a08508d430a0fbdd5a6a17c09b9633694 Enable strict coverage for step module (reland #1 ) (phajdan.jr@chromium.org )
TBR=iannucci@chromium.org
Change-Id: I208c0ad51e88e052682315628247a0389167dfd7
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/475246
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
8 years ago
a143749f26
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/f9234eae58f62b6af33d74391de1ead436fb3117 [fetch.py] only do a reset if diff is unclean. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Change-Id: I9a2e5e960810826065e7469407ed15f4075ba922
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/475510
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
8 years ago
a1bab27a25
Give Rietveld git-cl-status the 'not lgtm' state
...
While working on fixing git-cl-status for gerrit, I realized
it would be really easy to bring the Rietveld version up to
parity and simplify it at the same time.
Bug: 706460
Change-Id: Icff32b532fa29f8869205111cd117176e0d34b8f
Reviewed-on: https://chromium-review.googlesource.com/470448
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
3922f54b9d
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/7bd2024cede7b97a253c496d263bf9bde6cc9815 [test] make --filter imply *.* instead of .* (iannucci@chromium.org )
TBR=iannucci@chromium.org
Change-Id: Ie635aaf72e305cd1c89b1d269ee4f5ea1acdfbda
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/475244
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
8 years ago
9ab38c6885
Fix gerrit git-cl-status to be simpler and correct
...
The loop over the messages didn't early-exit when it found
a non-CQ message, so it would continue looking until it
found any message by a non-owner. So all CLs with any comments
by anyone other than the uploader would be in 'reply' state
forever.
This CL fixes that, and also makes some other tweaks to
make the gerrit status code simpler and faster.
Bug: 706460
Change-Id: I5cc06962f5121fe042a315e5e2e205e556eb85da
Reviewed-on: https://chromium-review.googlesource.com/470586
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
8 years ago
a6c7d95fbe
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/5a74d04e181b07592fb57abd5602bafe276e2b17 bootstrap: Invoke "pip" through Python. (dnj@chromium.org )
TBR=iannucci@chromium.org
Change-Id: Iadb36eb631b2fbbefa9ea61b72c55a69564f9b81
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/473894
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
8 years ago
898c279588
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/939068138596e0259bd19be9e40c1ab17f55b3d6 Revert of Enable strict coverage for step module (patchset #3 id:40001 of https://codereview.chromium.org/2806363004/ ) (phajdan.jr@chromium.org )
TBR=iannucci@chromium.org
Change-Id: I54dcc754d21caff570f9a6473130cb288a147f61
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/473851
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
8 years ago
36d66752a7
bot_update: add basic deapply_patch logic
...
This will make it reusable, e.g. for https://chromium-review.googlesource.com/c/465417/
Bug: none
Change-Id: I96f13c6ff3aff22c787e290979602e7a0d725213
Reviewed-on: https://chromium-review.googlesource.com/474139
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
8 years ago
f20776d5ba
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/3bd327959845d8cb93d1987b3da790a20384a1e1 Enable strict coverage for step module (phajdan.jr@chromium.org )
TBR=iannucci@chromium.org
Change-Id: I7c49190fc5fa556ad462e9a0c9b0f25bb042f5ad
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/473950
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
8 years ago
eebca917f6
apply_issue: remove old hack.
...
Nothing should depend on this magic file any more.
R=maruel@chromium.org,agable@chromium.org
Change-Id: Ibff8e2b575b119733c6c21ca6aebe38856c578c1
Reviewed-on: https://chromium-review.googlesource.com/474826
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
8 years ago
51acef998a
Shamelessly plug $ git cl creds-check into yet another place.
...
R=machenbach@chromium.org
Bug: 689543
Change-Id: I73607e7afe78bac3bbe509fe9c4387dfd0095011
Reviewed-on: https://chromium-review.googlesource.com/474138
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
c971239edd
git cl patch <url>: better handling of URLs.
...
* if --rietveld or --gerrit is given, parse only using appropriate
parser.
* if url has '$HOST-review' in the beginning, assume it's Gerrit
* if type of codereview is detected based on URL, then print this
information for the user.
This also applies to `git cl description` but message is logged instead,
because in '-d|--display' option git cl is supposed to print only description,
and some tooling likely relies on this :(
R=jochen@chromium.org
BUG=706406
Change-Id: I21c9355c5334fd71db27618cda11287f75168b59
Reviewed-on: https://chromium-review.googlesource.com/473186
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
8 years ago
38bbd23a26
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/05d9ed6145e2b05b7430fb7306f279fb2e2f19b2 [bundle] allow empty directories. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Change-Id: I98f5d744f11e7de7ce82ad4ee648c367799fabd6
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/474685
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
8 years ago
ec576ecfa2
Stop running deprecated simulation_test
...
See https://codereview.chromium.org/2808833003/
for context.
Bug: 699120, 693058
Change-Id: I1420c347d4ae2bac8bea54bc1b921fe6b65e6161
Reviewed-on: https://chromium-review.googlesource.com/474027
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
8 years ago
94fd88eeea
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/168be2068b30c07600603f1ce7fffe8f21348965 [doc/recipes.py] stop intercepting --help (iannucci@chromium.org )
TBR=iannucci@chromium.org
Change-Id: If3c76b68fd224eae3bf5c333ca80ef633a7554a1
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/473791
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
8 years ago
b55f20bc3b
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/e47e63a157739d48e41f71a2d3827d1a38277359 Fix autoroller updates() criteria. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Change-Id: Ifda7ecac9682dbf5cfd72b0ff911187180bcc3f8
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/473790
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
8 years ago
1eedff073a
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/8ccde4e6c9059cd907363ff4771fc6f222aee05e Fix typobug (iannucci@google.com )
TBR=iannucci@chromium.org
Change-Id: I0de51cbb16b8bc7f94f054e39a7242b8f0afff1a
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/474188
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
8 years ago
17a530722b
git hyper-blame: Fixed --no-default-ignores option to not take argument.
...
BUG=709835
Change-Id: Ia203cf24adf752ef3acdf660b4fe0990503782b9
Reviewed-on: https://chromium-review.googlesource.com/472587
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
8 years ago
56431bf304
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/cc1f2ad78df7d3d19cff8e2d31866b9e49f732a9 Heavily refactor repo backends system. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Change-Id: I6d0883bd514106852ad11bab40422392389e0fcc
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/473890
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
8 years ago
109907e6a9
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/f5e47cfc28b5964701572db12f96c7a5a3f1821a Enable strict coverage for json, path, platform, properties, raw_io (phajdan.jr@chromium.org )
TBR=iannucci@chromium.org
Change-Id: Ib252420e515f7521a4b36129edcdcc6d2dbe1be4
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/474186
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
8 years ago
10364a7c74
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/56ba34248d8319cfdaff19ae55d68004fdd8ebf8 Stop running deprecated simulation_test (phajdan.jr@chromium.org )
TBR=iannucci@chromium.org
Change-Id: I7c379c112ee63a2daf6050ab3ccccd9ae940d90b
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/473929
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
8 years ago
93e1a76ec4
Actually enable crash dump collection on builders
...
Change crrev.com/1825163003 attempted to enable crash dump collection
on build machines, and it worked fine on local testing. However it only
worked because local testing was done using 64-bit Python. The builders
use python from depot_tools which is 32-bit Python so the changes all
went to "HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Microsoft" instead of
to "HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft", which means they were
ignored. For a year. This made investigation of linker crashes more
complicated than needed.
This change uses the necessary winreg.KEY_WOW64_64KEY dance so that the
64-bit registry is always used, whether running 32-bit Python or 64-bit
Python. Both versions were tested locally. The behavior on 32-bit
Windows is unknown but we don't support building on 32-bit Windows
anyway, and any failures would be rendered harmless by the try/except
block.
R=scottmg@chromium.org
BUG=704286
Change-Id: I6abc0e1e9c69b9a4e4b9c705bea9e4faadd0945c
Reviewed-on: https://chromium-review.googlesource.com/473567
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
8 years ago
2b4ac39884
Add *.proto to git-gs
...
Change-Id: I393579c9cfafbd6a5331abb13e33b61c8fa69df7
Reviewed-on: https://chromium-review.googlesource.com/473548
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
8 years ago
5c25aae6fa
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/4afdf69bc15cbcf6a88076da7074d24cb88780d2 Add test coverage for testing recipe configs and test_api (phajdan.jr@chromium.org )
TBR=iannucci@chromium.org
Change-Id: Ia28a35f38794ae2baae3b29a58594eb67b6647b6
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/473927
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
8 years ago
Aaron Gable
Robert Iannucci
Andrii Shyshkalov
Jochen Eisinger
recipe-roller
Dave Schuyler
Daniel Cheng
Dan Jacques
Paweł Hajdan, Jr
Matt Giuca
Bruce Dawson
Scott Graham