The main fix is 'Accept new empty files, like __init__.py'
TBR=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/8519005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109431 0039d316-1c4b-4281-b951-d872f2087c98
isatty() wasn't defined on Windows, causing it to crash.
R=dpranke@chromium.org
BUG=
TEST=manually gclient sync on windows
Review URL: http://codereview.chromium.org/8371006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@106865 0039d316-1c4b-4281-b951-d872f2087c98
For now only affect gclient help to figure out if there is any issue with it.
Because of the way it's done, there is no way to disable coloring, which could
be annoying when redirected. This needs to be taken in consideration.
R=dpranke@chromium.org
TEST=manually tested on linux, cygwin and windows, both run manually and
redirected to a text file.
BUG=
Review URL: http://codereview.chromium.org/8365001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@106708 0039d316-1c4b-4281-b951-d872f2087c98
---
Trap failure to get password from keyring
It happens when using upload.py from a ssh session without a X session but
gnomekeyring is used.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7715013
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@97909 0039d316-1c4b-4281-b951-d872f2087c98
It was added in r80045 but was overwriten in r82495 when I synced upload.py to
r705 since upstreaming that part staled.
TBR=dpranke
TEST="git mv foo bar; git commit -a; git cl upload" shows 2 files, one A+, one D.
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@84264 0039d316-1c4b-4281-b951-d872f2087c98
Exposes InputApi.rietveld and deprecate host_url.
This is useful since it places authentication at a single place.
BUG=
TEST=
Review URL: http://codereview.chromium.org/6825008
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81019 0039d316-1c4b-4281-b951-d872f2087c98
Removed all the local hacks as they are not necessary anymore.
R=dpranke@chromium.org
BUG=none
TEST=manually verified that HTTP 302 redirect works fine.
Review URL: http://codereview.chromium.org/6730004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79296 0039d316-1c4b-4281-b951-d872f2087c98
Make json files known as a text mimetype so that they can be seen in reviews.
Original review at http://codereview.appspot.com/4133046/
Also make sure that the copy in third_party and in git_cl are the same. I'll
remove the copy in git_cl in a later change.
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@74116 0039d316-1c4b-4281-b951-d872f2087c98
("Connection timed out"). This allowed me to successfully upload a CL I had
been stuck on for a couple of hours.
Manually tested by raising both HTTPError and URLError within this code block
and ensuring both are caught correctly.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6304006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@71702 0039d316-1c4b-4281-b951-d872f2087c98
introduced a bug which I didn't encounter during testing.
BUG=none
TEST=none
TBR=maruel
Review URL: http://codereview.chromium.org/6340006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@71520 0039d316-1c4b-4281-b951-d872f2087c98
("Connection timed out"). This allowed me to successfully upload a CL
I have been stuck on for a couple of hours.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6345001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@71513 0039d316-1c4b-4281-b951-d872f2087c98
If the host parameter is invalid, like having a trailing backslash, it will
result on HTTP 400 later which is much harder to diagnose.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/5339001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@67295 0039d316-1c4b-4281-b951-d872f2087c98
This issue is only on python 2.4.
BUG=
TEST=
Review URL: http://codereview.chromium.org/5216004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@66867 0039d316-1c4b-4281-b951-d872f2087c98
We need this now for an imminent rietveld instance move.
TEST=worked with manual testing
BUG=none
Review URL: http://codereview.chromium.org/5138007
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@66810 0039d316-1c4b-4281-b951-d872f2087c98
Moved tests/pymox to third_party/pymox
Moved upload.py to third_party/upload.py
Fixed tests so they can run standalone
Fixed the executable bit on some scripts
TEST=none
BUG=34376
Review URL: http://codereview.chromium.org/562031
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37987 0039d316-1c4b-4281-b951-d872f2087c98
maruel@chromium.org
kbr@chromium.org
jam@chromium.org
jabdelmalek@google.com
nasser@codeaurora.org