from the same repository.
TEST=added regression test.
BUG=none
Review URL: http://codereview.chromium.org/6578029
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@75937 0039d316-1c4b-4281-b951-d872f2087c98
To reproduce, svn delete a file, then svn merge -c -N the file to revive it.
Also fix a unit test that was broken for a while.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/6576005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@75835 0039d316-1c4b-4281-b951-d872f2087c98
BUG=none
TEST=second git-cl upload of a CL doesn't set CC again
Review URL: http://codereview.chromium.org/6546042
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@75531 0039d316-1c4b-4281-b951-d872f2087c98
When I renamed setup_mock to local_rietveld, I had forgot one place in
PRESUBMIT.py.
TBR=evan
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6501001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@74627 0039d316-1c4b-4281-b951-d872f2087c98
This makes the code more comprehensible and reusable.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6460015
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@74623 0039d316-1c4b-4281-b951-d872f2087c98
The recent changes to the chromite wrapper hid all import errors
in chromite, simply giving an error that chromite couldn't be found.
This fixes the problem.
For associated review in chromiumos git:
http://codereview.chromium.org/6461009
Review URL: http://codereview.chromium.org/6487003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@74452 0039d316-1c4b-4281-b951-d872f2087c98
So pass a single item array. The presubmit checks would fail otherwise.
This code path was definitely not exercised by the unit tests. Unit tests are
left as an exercise to the reader.
TBR=vbendeb
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6479006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@74396 0039d316-1c4b-4281-b951-d872f2087c98
Unittest is being also updated.
TEST=manual
. run ./presubmit_unittest.py, observe success
.create a CL with code style violations (long lines, traling spaces) and observe the violations reported by 'git cl presubmit'
Patch contributed by Vadim
Review URL: http://codereview.chromium.org/6461011
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@74378 0039d316-1c4b-4281-b951-d872f2087c98
It would fail otherwise when called directly from a git checkout subdirectory.
Updated unit test.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6459010
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@74281 0039d316-1c4b-4281-b951-d872f2087c98
Disable warning W0404 in pylint.
BUG=none
TEST=should now work on googlers workstations
Review URL: http://codereview.chromium.org/6456010
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@74242 0039d316-1c4b-4281-b951-d872f2087c98
There is 2 changes while moving the code:
- Making externals handling an option.
- Not trapping EnvironmentError.
This code will be reused by the commit queue.
TEST=unit tests
BUG=none
Review URL: http://codereview.chromium.org/6250177
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@74181 0039d316-1c4b-4281-b951-d872f2087c98
Make json files known as a text mimetype so that they can be seen in reviews.
Original review at http://codereview.appspot.com/4133046/
Also make sure that the copy in third_party and in git_cl are the same. I'll
remove the copy in git_cl in a later change.
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@74116 0039d316-1c4b-4281-b951-d872f2087c98
For example, TODO(foo) is ok, but TODO: do something is not.
BUG=none
TEST=included
Review URL: http://codereview.chromium.org/6413004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@74032 0039d316-1c4b-4281-b951-d872f2087c98
This enables seamless unit tests that check-in files without side-effects on the
remaining unit tests.
BUG=none
TEST=none
TBR=dpranke
Review URL: http://codereview.chromium.org/6250073
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@73456 0039d316-1c4b-4281-b951-d872f2087c98
Improves output of git cl tree to use Chromium OS status, not Chromium Status.
BUG=chromium-os:11449
TEST=Output of 'git cl tree' for Chromium OS includes output from Chromium OS instead of from Chromium.
Review URL: http://codereview.chromium.org/6312047
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@73292 0039d316-1c4b-4281-b951-d872f2087c98
Otherwise if there is a file named breakpad.py for instance in the current
directory, it will be loaded instead of the one in depot_tools.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6312034
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@73165 0039d316-1c4b-4281-b951-d872f2087c98
This file is a copy of the chromite wrapper that lives here:
http://git.chromium.org/gitweb/?p=chromite.git;a=blob;f=bin/chromite
Anush requested that this wrapper be placed into depot_tools so
that users will get the wrapper in their path. The wrapper will go
and find the real version of chromite based on the CWD.
Patch contributed by dianders@chromium.org.
Review URL: http://codereview.chromium.org/6299018
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@73011 0039d316-1c4b-4281-b951-d872f2087c98
Also remove the harcoding of the names by putting them in a variable.
This will help testing of the commit queue.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6350013
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@72454 0039d316-1c4b-4281-b951-d872f2087c98
("Connection timed out"). This allowed me to successfully upload a CL I had
been stuck on for a couple of hours.
Manually tested by raising both HTTPError and URLError within this code block
and ensuring both are caught correctly.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6304006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@71702 0039d316-1c4b-4281-b951-d872f2087c98
svn:externals are slow to update and are unnecessary in a gclient environment.
TEST=none
BUG=55904
Review URL: http://codereview.chromium.org/3421013
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@71604 0039d316-1c4b-4281-b951-d872f2087c98
introduced a bug which I didn't encounter during testing.
BUG=none
TEST=none
TBR=maruel
Review URL: http://codereview.chromium.org/6340006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@71520 0039d316-1c4b-4281-b951-d872f2087c98
("Connection timed out"). This allowed me to successfully upload a CL
I have been stuck on for a couple of hours.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6345001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@71513 0039d316-1c4b-4281-b951-d872f2087c98
TEST=Verified that if this code breaks, the presubmit checks fail.
BUG=none
Review URL: http://codereview.chromium.org/6079003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@71229 0039d316-1c4b-4281-b951-d872f2087c98
BUG=none
TEST=git cl dcommit/push performs an index update before
checking if the tree is dirty
Review URL: http://codereview.chromium.org/6172003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@70908 0039d316-1c4b-4281-b951-d872f2087c98
Also update the PRESUBMIT check to exclude git_cl/.
BUG=none
TEST=git-cl hooks run
TBR=maruel@chromium.org
Review URL: http://codereview.chromium.org/5998008
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@70108 0039d316-1c4b-4281-b951-d872f2087c98
FakeRepos is useful for offline SCM tests but it was hardcoded for depot_tools
requirements. Luckily, it was already modular enought that it merely required to
shuffle code around to split it in two classes to be able to reuse the code
as-is.
BUG=
TEST=
Review URL: http://codereview.chromium.org/6029004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@69845 0039d316-1c4b-4281-b951-d872f2087c98
Otherwise the following presubmit checks where never called.
TBR=nsylvain
BUG=
TEST=fixes unit tests
Review URL: http://codereview.chromium.org/5995003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@69844 0039d316-1c4b-4281-b951-d872f2087c98
Change RunPylint to parse all .py files when one is modified.
Make all depot_tools/tests pass on pylint. That mostly meant fixing some
builtins aliasing, wrong alignment and turning off most remaining warnings.
BUG=none
TEST=unit tests
Review URL: http://codereview.chromium.org/5695007
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@69159 0039d316-1c4b-4281-b951-d872f2087c98
Adding it as I figured out how to make it run correctly on ubuntu 10.4 and it's
used in enough places it warrants a canned check.
BUG=none
TEST=it self tests itself.
Review URL: http://codereview.chromium.org/5682011
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@69051 0039d316-1c4b-4281-b951-d872f2087c98
Mostly useful for commit-queue as I want to both send the trace and be able to
read it locally.
TBR=jam
Review URL: http://codereview.chromium.org/5608001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@68055 0039d316-1c4b-4281-b951-d872f2087c98
maruel@chromium.org
bradnelson@google.com
chase@chromium.org
mirandac@chromium.org
dianders@chromium.org
estade@chromium.org
msb@chromium.org
jam@chromium.org
thakis@chromium.org
kbr@chromium.org
evan@chromium.org
dpranke@google.com