Commit Graph

4 Commits (81e012ce4139b4e9a649e1fead884ed033600c74)

Author SHA1 Message Date
chase@chromium.org 94ba024845 Fixes based on maruel's comments.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/281007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@29194 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
chase@chromium.org f3c9280850 Fail gracefully when we can't import hooks library.
BUG=5339
TEST=excluding depot_tools from PATH shows an
instructive error, trying to run the hook with
git_cl_hooks.py missing shows an instructive error
Review URL: http://codereview.chromium.org/264069

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@29156 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
chase@chromium.org 7658eb3c12 Alter hooks to call into depot_tools lib.
This new method allows us to install pre-cl-upload
and pre-cl-dcommit hook files which should rarely need
to be updated (with luck).  These hooks load the real
hooks lib from depot_tools which takes over execution
of the presubmit tests.

BUG=5339
TEST=hooks are run by git cl upload/dcommit and behave
as expected
Review URL: http://codereview.chromium.org/243118

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@28409 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
chase@chromium.org 41310064b1 Add git-cl upload hooks.
Provide git-cl upload and dcommit hooks based on this
single hooks file.  Installed via git-cl config.
Loads and calls the PresubmitSupport library.
Test failure before a dcommit halts the check-in.

BUG=5339
TEST=hooks file runs presubmit checks and halts
checkin (dcommit) or repeats error messages (upload).
hooks file runs and doesn't interrupt process if no
errors present.
Review URL: http://codereview.chromium.org/256075

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@28125 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago