7f48c068c1
gclient: explicitly set checkout cwd for runhooks
...
BUG=chromium:596887
R=dsansome@chromium.org
Review URL: https://codereview.chromium.org/1956383002 .
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300503 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
116286a64a
depot_tools: add debug logic to bot_update for gerrit patches
...
BUG=606150, 602906
Review-Url: https://codereview.chromium.org/1954083002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300466 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
32f9abc277
depot_tools: create builder cache path config
...
BUG=chromium:596887
Review-Url: https://codereview.chromium.org/1937953002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300403 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
b1a1714800
Add buildtools patches to be runnable on chromium trybot.
...
TBR=machenbach@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/1936143002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300402 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
08315d9073
Avoid computing patch_root in get_files_affected_by_patch.
...
Context: See https://codereview.chromium.org/1934533002/#msg19 for context.
Allows: https://codereview.chromium.org/1933223002
Next - testing that it works for skia, upgrading old users to new method,
and finally killing old code.
R=machenbach@chromium.org,rmistry@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/1927403003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300395 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
28216cd14b
Add git_cl recipe module.
...
BUG=607359
Review-Url: https://codereview.chromium.org/1925873002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300372 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
b6552b6e45
Improve doc for gclient.pach_projects mapping.
...
R=phajdan.jr@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/1933233002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300347 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
ecbb63d08b
depot_tools: add specific cache directory for goma deps in kitchen path config
...
BUG=chromium:596887
Review-Url: https://codereview.chromium.org/1933683002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300343 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
6cfbbcf467
depot_tools: add dependencies on infra_paths
...
This is a preparation for removal of infra-specific
paths from the recipe engine.
BUG=chromium:605919
Review-Url: https://codereview.chromium.org/1930373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300335 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
c3c1229013
depot_tools: add infra_paths recipe module for infra-specific paths (attempt #2 )
...
This is different from previous attempt https://codereview.chromium.org/1915463002 .
The change is completely backwards-compatible, and doesn't introduce recipe
expectation changes.
Modules can be switched to depend on infra_paths independently,
without any expectation changes either.
By moving path module's config.py to paths_config.py here, we also guarantee
that the returned results are going to be exactly the same.
Depends on https://codereview.chromium.org/1923363003 .
BUG=chromium:605919
Review-Url: https://codereview.chromium.org/1926033002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300324 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
da3bfae5bb
Add Skia to list of can-be-patched projects in chromium checkout.
...
BUG=
Review-Url: https://codereview.chromium.org/1929993002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300287 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
b770809308
Roll recipe dependencies (nontrivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must commit the change manually.
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/d9039313202dfb6adaf890674abdd8ee6aec940d recipe engine: remove explicit cwd default in step recipe module (phajdan.jr@chromium.org )
R=phajdan.jr@chromium.org
BUG=chromium:605919
Review URL: https://codereview.chromium.org/1926633002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300229 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
25837199f3
Revert of Reland of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #1 id:1 of https://codereview.chromium.org/1917263002/ )
...
Hopefully everything will be back to normal now...
Original issue's description:
> depot_tools: add infra_paths recipe module for infra-specific paths
>
> Depends on https://codereview.chromium.org/1906323003
>
> BUG=chromium:605919
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300184
TBR=iannucci@chromium.org,hinoka@chromium.org,phajdan.jr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:605919
Review URL: https://codereview.chromium.org/1915033006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300210 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
3407a99675
Roll recipe_engine to 2f86f02a302172514bf282684e0a4aa18b683e41
...
TBR=phajdan.jr
BUG=606708
Review URL: https://codereview.chromium.org/1921893003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300206 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
d34c90601f
Reland of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #1 id:1 of https://codereview.chromium.org/1917263002/ )
...
Reason for revert:
re-landing because wrong order of reverts :(
Original issue's description:
> Revert of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #2 id:20001 of https://codereview.chromium.org/1915463002/ )
>
> Reason for revert:
> breaks skia bots :(
>
> Original issue's description:
> > depot_tools: add infra_paths recipe module for infra-specific paths
> >
> > Depends on https://codereview.chromium.org/1906323003
> >
> > BUG=chromium:605919
> >
> > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300184
>
> TBR=iannucci@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:605919
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300199
TBR=iannucci@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:605919
Review URL: https://codereview.chromium.org/1921373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300200 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
54e0d26399
Revert of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #2 id:20001 of https://codereview.chromium.org/1915463002/ )
...
Reason for revert:
breaks skia bots :(
Original issue's description:
> depot_tools: add infra_paths recipe module for infra-specific paths
>
> Depends on https://codereview.chromium.org/1906323003
>
> BUG=chromium:605919
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300184
TBR=iannucci@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:605919
Review URL: https://codereview.chromium.org/1917263002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300199 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
c808c55594
depot_tools: only add mock infra_paths when test data is enabled
...
BUG=chromium:605919
Review URL: https://codereview.chromium.org/1917093004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300193 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
cf48206332
depot_tools: add test_api to infra_paths recipe module
...
BUG=chromium:605919
Review URL: https://codereview.chromium.org/1915113006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300191 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
aa71406c1c
Add Pdfium to list of can-be-patched projects in chromium checkout.
...
R=machenbach@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1914123002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300185 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
f30e872853
depot_tools: add infra_paths recipe module for infra-specific paths
...
Depends on https://codereview.chromium.org/1906323003
BUG=chromium:605919
Review URL: https://codereview.chromium.org/1915463002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300184 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
a69d56c8ac
Revert of bot_update: call gclient sync after checking out a gerrit ref (patchset #1 id:1 of https://codereview.chromium.org/1904663002/ )
...
Reason for revert:
I believe this is mostly likely to have broken Angle, but this is speculative.
http://crbug.com/606150
Original issue's description:
> bot_update: call gclient sync after checking out a gerrit ref
>
> BUG=chromium:602906
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300109
TBR=hinoka@chromium.org,yyanagisawa@chromium.org,hinoka@google.com,phajdan.jr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:602906
Review URL: https://codereview.chromium.org/1918903003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300159 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
6149999985
patch_root hacks cleanup.
...
Removes deprecated patch_project_roots in bot_update,
and the TODOs used for migration.
Depends: https://codereview.chromium.org/1913863002
R=phajdan.jr@chromium.org,machenbach@chromium.org
BUG=605563
Review URL: https://codereview.chromium.org/1920933002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300153 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
e0b4931495
patch_root cleanup: transition everyone to new code.
...
This doesn't create recipe expectations changes.
Depends: https://codereview.chromium.org/1920903002/
Allows: https://codereview.chromium.org/1913863002
R=machenbach@chromium.org,phajdan.jr@chromium.org
BUG=605563
Review URL: https://codereview.chromium.org/1919863003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300150 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
cb3fd431fd
Generalize patch_project to patch root conversion.
...
IMPORTANT: See bug http://crbug.com/605563#c3 for deployment and emergency roll-back plan.
This patch is first of a series. It provides a cleaner and generic way to apply patches to non-root of first solution.
R=phajdan.jr@chromium.org,machenbach@chromium.org
BUG=605563
Review URL: https://codereview.chromium.org/1917433002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300141 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
ff8ce0e5a0
depot_tools: expose path to cros
...
Needed for https://codereview.chromium.org/1922503002
BUG=chromium:585401
Review URL: https://codereview.chromium.org/1917803002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300135 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
76a4900e2e
bot_update: call gclient sync after checking out a gerrit ref
...
BUG=chromium:602906
Review URL: https://codereview.chromium.org/1904663002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300109 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
3f0ac2bde4
depot_tools: expose path to gn.py
...
BUG=chromium:602906
Review URL: https://codereview.chromium.org/1902043002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300016 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
900392f6a0
depot_tools: expose path to gsutil.py
...
This is needed for https://codereview.chromium.org/1896113002
BUG=chromium:585401, chromium:593999
Review URL: https://codereview.chromium.org/1897743004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300011 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
a04cae9f58
Add --gerrit_no_reset for who need to use FETCH_HEAD revision.
...
Avoid to call git reset --soft to preserve current revision to
FETCH_HEAD. 'got_revision' property would also be that from
FETCH_HEAD.
BUG=596787
Review URL: https://codereview.chromium.org/1837453002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299721 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
7fe25f4079
V8: Add new v8 master to bot_update.
...
BUG=485955
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/1858193002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299695 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
375aa58877
Make the config -> pythonish conversion a gclient module function.
...
Also makes bot_update use this.
This allows for clank to manually set the gclient config.
BUG=590788
Review URL: https://codereview.chromium.org/1815863002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299398 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
29c3b34610
bot_update: Rewrite to use properties, and add override options for patches.
...
Depends on https://codereview.chromium.org/1755593003
BUG=591172
Review URL: https://codereview.chromium.org/1741983002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299332 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
21217f42df
Convert the bot_update module to use properties
...
R=iannucci@chromium.org
BUG=591172
Review URL: https://codereview.chromium.org/1805113003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299329 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
dabddd8a68
depot_tools: use ninja.exe instead of just ninja on Windows
...
BUG=437264
Review URL: https://codereview.chromium.org/1778243008
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299267 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
f3874aff0d
depot_tools: expose location of ninja
...
BUG=437264
Review URL: https://codereview.chromium.org/1787633003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299263 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
5fc657ba8a
Reland of Use gclient's git_cache setting in bot_update/api.py
...
https://codereview.chromium.org/1762513002/
Use gclient's git_cache setting in bot_update/api.py
BUG=589140
R=szager@chromium.org,iannucci@chromium.org
Review URL: https://codereview.chromium.org/1784043002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299260 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
88e173be1a
depot_tools: adjust for resource API changes in recipe engine
...
This is rolling in https://codereview.chromium.org/1777003003
BUG=593420
Review URL: https://codereview.chromium.org/1785443002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299187 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
907a1e7c8e
Revert of Use gclient's git_cache setting in bot_update/api.py (patchset #6 id:100001 of https://codereview.chromium.org/1762513002/ )
...
Reason for revert:
Roll into build breaks infra crons.
Original issue's description:
> Use gclient's git_cache setting in bot_update/api.py
>
> BUG=589140
> R=agable@chromium.org
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299120
TBR=agable@chromium.org,hinoka@chromium.org,hinoka@google.com,iannucci@chromium.org,wkorman@chromium.org,szager@chromium.org
BUG=589140
Review URL: https://codereview.chromium.org/1776193002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299160 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
6196039380
depot_tools: expose path to download_from_google_storage
...
BUG=585401
Review URL: https://codereview.chromium.org/1770383004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299158 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
3ce9b4446d
Make CACHE_DIR set by default in most gclient configs.
...
This is needed because bot_update changed from getting the cache directory from
the global path module to the gclient config.
BUG=589140
Review URL: https://codereview.chromium.org/1768893003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299143 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
88be9a1c5a
Use gclient's git_cache setting in bot_update/api.py
...
BUG=589140
R=agable@chromium.org
Review URL: https://codereview.chromium.org/1762513002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299120 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
5c2f2a6768
Fix recipe module git to use package_resouce.
...
TBR=phajdan.jr@chromium.org,martiniss@chromium.org
BUG=590806
Review URL: https://codereview.chromium.org/1751003002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299027 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
70a43af908
Read got_revision_mapping from built in spec
...
Sometimes the spec passed in via parameters also have got_revision_mapping that
we want to use.
BUG=590788
Review URL: https://codereview.chromium.org/1748143002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299015 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
e8f4da09ba
Revert of Fix git recipe module to use git.bad as package resouce. (patchset #1 id:1 of https://codereview.chromium.org/1742403002/ )
...
Reason for revert:
broke win builder bug 590806
Original issue's description:
> Fix git recipe module to use git.bad as package resouce.
>
> R=phajdan.jr@chromium.org
> BUG=579160
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299005
TBR=phajdan.jr@chromium.org,tandrii@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=579160
Review URL: https://codereview.chromium.org/1750733002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299011 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
575d41a4f1
Fix git recipe module to use git.bad as package resouce.
...
R=phajdan.jr@chromium.org
BUG=579160
Review URL: https://codereview.chromium.org/1742403002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299005 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
cd9a3389e1
depot_tools: add master_deps in gclient/config.py
...
BUG=574615
Review URL: https://codereview.chromium.org/1705473003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298843 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
6eb23e25bd
Revert of Bot update cleanup (patchset #5 id:80001 of https://codereview.chromium.org/1686273002/ )
...
Reason for revert:
Separating change into smaller changes.
Original issue's description:
> Bot update cleanup
>
> * Remove activation check
> * Remove messages
> * Remove deps2git
> * Remove build_internal pointer by:
> ** Moving chrome svn url into bot_update.py (This isn't secret anyways.)
> ** Move patch.exe into depot_tools (No reason this should've been internal...)
> ** Default everything to active, so no need for checks anyways.
>
> BUG=
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298809
TBR=martiniss@chromium.org,eseidel@chromium.org,estaab@chromium.org,iannucci@chromium.org,hinoka@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=
Review URL: https://codereview.chromium.org/1706893003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298826 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
b0f36188b2
Bot update cleanup
...
* Remove activation check
* Remove messages
* Remove deps2git
* Remove build_internal pointer by:
** Moving chrome svn url into bot_update.py (This isn't secret anyways.)
** Move patch.exe into depot_tools (No reason this should've been internal...)
** Default everything to active, so no need for checks anyways.
BUG=
Review URL: https://codereview.chromium.org/1686273002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298809 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
846218da18
Make git.checkout return the commit hash.
...
R=dnj@chromium.org, hinoka@chromium.org, luqui@chromium.org, martiniss@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1693993002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298774 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
edf62ce445
gclient: add depot_tools to PATH
...
BUG=437264
Review URL: https://codereview.chromium.org/1676473002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298614 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
phajdan@google.com
phajdan.jr@chromium.org
tandrii@chromium.org
martiniss@chromium.org
rmistry@google.com
recipe-roller@chromium.org
yyanagisawa@chromium.org
machenbach@chromium.org
szager@chromium.org
hinoka@chromium.org
ukai@chromium.org
hinoka@google.com
iannucci@chromium.org