Have "bot_update.py" export the failing patch body in its JSON. Have the
recipe actually emit the patch body in the "Patch Failure" step instead
of the "bot_update" step, and remove the "Patch Failure" step's
indirection to the "bot_update" step for patch failure.
This will provide a more straightforward user interface: the red step
that says "Patch Failure" now includes the details of the patch failure!
BUG=chromium:710477
TEST=expectations
Change-Id: I6ad305f0b972de89e4f0b5eb70edf41980447abd
Reviewed-on: https://chromium-review.googlesource.com/475950
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Bug: 710817
Change-Id: Ifb2a9abe605d9e403c55ec1360d186af12dd2f34
Reviewed-on: https://chromium-review.googlesource.com/475775
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Bug: 710817
Change-Id: Ice7cefaf5c5a5cac431a95d3adfa44f323eafb2f
Reviewed-on: https://chromium-review.googlesource.com/475230
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
It proved to be dangerous to introduce conditional logic into recipes
and recipe modules to alternate between buildbot and luci modes, namely
it touches buildbot code paths, which can be very dangerous.
Instead, introduce "generic" path config that configures
existing base paths from the built-in ones.
Also remove swarmbucket path config because it is not used.
--
This CL is a simpler version of
https://chromium-review.googlesource.com/c/459234/
in that it does not make generic path config a default.
This avoids behavioral change in downstream recipe packages and
makes rolling into build.git trivial.
R=iannucci@chromium.org
BUG=660481
Change-Id: Ifc147e29e68a6e0c800da73a8e356238dfc2938a
Reviewed-on: https://chromium-review.googlesource.com/461359
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
This reverts commit 8b5b594115.
Reason for revert: nothing wrong with this CL, but implementing a manual roll to build.git takes more than 20 min. I will reland this CL once my roll to build.git CL is ready
Original change's description:
> add "generic" infra path config
>
> It proved to be dangerous to introduce conditional logic into recipes
> and recipe modules to alternate between buildbot and luci modes, namely
> it touches buildbot code paths, which can be very dangerous.
>
> Instead, introduce "generic" default path config that configures
> existing base paths from the built-in ones.
>
> Also remove swarmbucket path config because it is not used.
>
> R=iannucci@chromium.org
> BUG=660481
>
> Change-Id: Ide0e1f64913fe35766b997ab5b55f01f4c63aa58
> Reviewed-on: https://chromium-review.googlesource.com/459234
> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
>
TBR=iannucci@chromium.org,nodir@chromium.org,chromium-reviews@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=660481
Change-Id: If27a537689dfe3669015bcbc7a5f07ca1f5c10af
Reviewed-on: https://chromium-review.googlesource.com/461223
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
It proved to be dangerous to introduce conditional logic into recipes
and recipe modules to alternate between buildbot and luci modes, namely
it touches buildbot code paths, which can be very dangerous.
Instead, introduce "generic" default path config that configures
existing base paths from the built-in ones.
Also remove swarmbucket path config because it is not used.
R=iannucci@chromium.org
BUG=660481
Change-Id: Ide0e1f64913fe35766b997ab5b55f01f4c63aa58
Reviewed-on: https://chromium-review.googlesource.com/459234
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
This will help remove confusion when depot_tools' recipes.py
ends up in PATH.
BUG=699120
Change-Id: Id4c21b0cc6bb022ea2c21145abe76bebb0a8d9c1
Reviewed-on: https://chromium-review.googlesource.com/458430
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
We are making depot_tools a proper (chromium) recipe package, which assumes
that recipes are located in recipes/. So I need to move these other kinds of
recipes out of the way.
BUG=564920
R=dpranke@chromium.org, iannucci@chromium.org
Review URL: https://codereview.chromium.org/1494793002 .
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297837 0039d316-1c4b-4281-b951-d872f2087c98
With this, `fetch pdfium` is all that's needed to get a pdfium checkout.
Review URL: https://codereview.chromium.org/1415243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297340 0039d316-1c4b-4281-b951-d872f2087c98
This both ensures that 'git auto-svn' has been properly run, and also that
the Blink checkout is appropriately 'unmanaged'.
R=dpranke@chromium.org, mmoss@chromium.org
BUG=289742
Review URL: https://codereview.chromium.org/1186053007
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295916 0039d316-1c4b-4281-b951-d872f2087c98
This reverts commit 78624b6839.
The reason is that install-build-deps.sh isn't meant to be run on mac
or windows, and this implementation ran it everywhere.
TBR=dpranke@chromium.org
BUG=229270
Review URL: https://codereview.chromium.org/1186893003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295686 0039d316-1c4b-4281-b951-d872f2087c98
This will make gclient download all the remote branches of
the WebRTC Git repo when the 'fetch webrtc' recipe runs.
This will result in a new fetch line in the .git/config for
branch-heads, like this:
[remote "origin"]
url = https://chromium.googlesource.com/external/webrtc.git
fetch = +refs/heads/*:refs/remotes/origin/*
fetch = +refs/branch-heads/*:refs/remotes/branch-heads/*
In order to get the same setup for an existing checkout, do:
gclient sync --with_branch_heads
git fetch origin
BUG=437776
TESTED=Ran 'fetch webrtc' and 'fetch webrtc_ios' and verified
the remote branches were available with 'git branch --remotes'
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1030573002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294528 0039d316-1c4b-4281-b951-d872f2087c98
expect_tests and testing_support are now pulled in via DEPS.
R=cmp@chromium.org, pgervais@chromium.org
BUG=
Review URL: https://codereview.chromium.org/901083003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293963 0039d316-1c4b-4281-b951-d872f2087c98
The root of problem is a _cache_temp file.
git_cache expected that it is a folder.
So rmtree failed to remove it.
BUG=
TBR= dpranke@chromium.org, enne@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/825133002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293502 0039d316-1c4b-4281-b951-d872f2087c98
Tested with the following command lines:
$ cd
$ mkdir skia_test
$ cd skia_test
$ fetch skia_buildbot
$ cd skia_buildbot
# confirm the repo is what one would expect.
BUG=None
TEST=see above
R=agable@chromium.org
Review URL: https://codereview.chromium.org/777513002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293283 0039d316-1c4b-4281-b951-d872f2087c98
Tested with the following command lines:
$ cd somewhere
$ mkdir some-test-dir
$ cd some-test-dir
$ fetch skia
$ cd skia
# confirm it is what we expected.
BUG=None
TEST=see above
R=agable@chromium.org
Review URL: https://codereview.chromium.org/746363003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293135 0039d316-1c4b-4281-b951-d872f2087c98
For Mac, we're depending on having both ios+mac for target_os.
R=agable@chromium.org
Review URL: https://codereview.chromium.org/753123003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293085 0039d316-1c4b-4281-b951-d872f2087c98
Although many things are private, the urls of the infra_internal and
build_internal repositories are not. So let's just add a fetch recipe
for them anyway.
R=iannucci@chromium.org
Review URL: https://codereview.chromium.org/544863006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292586 0039d316-1c4b-4281-b951-d872f2087c98
With the deletion of .DEPS.git, 'webkit_rev' became 'webkit_revision':
https://codereview.chromium.org/497313003
Without this change, gclient sync will not get the latest Blink commit.
Review URL: https://codereview.chromium.org/496443005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291716 0039d316-1c4b-4281-b951-d872f2087c98
The depot_tools and nacl recipes aren't setting up git-svn
properly. There is no git-svn branch in the git mirror for
depot-tools and nacl, just master.
As a consequence "fetch depot-tools" ends up recreating all
the objects from svn taking much more time than it should.
BUG=
Review URL: https://codereview.chromium.org/183743010
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@254506 0039d316-1c4b-4281-b951-d872f2087c98
This has been determined to work in a better,
more predictable and robust way.
BUG=none
R=szager@google.com
Review URL: https://codereview.chromium.org/22852017
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@219121 0039d316-1c4b-4281-b951-d872f2087c98
Dan Jacques
Paweł Hajdan, Jr
recipe-roller
Nodir Turakulov
Nodir Turakulov
luqui@chromium.org
thakis@chromium.org
mark@chromium.org
ricow@google.com
jochen@chromium.org
vadimsh@chromium.org
dpranke@chromium.org
agable@chromium.org
kjellander@chromium.org
iannucci@chromium.org
bradnelson@google.com
loislo@chromium.org
tfarina@chromium.org
machenbach@chromium.org
philipj@opera.com
agable@chromium.org
iannucci@chromium.org
jochen@chromium.org
primiano@chromium.org
bradnelson@google.com
phajdan.jr@chromium.org