maruel@chromium.org
4661e0c77b
The broken PRESUBMIT.py was fixed so reintegrating revision 17554 (which was good in the first place).
...
BUG=none
TEST=none
TBR=joi
Review URL: http://codereview.chromium.org/119130
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17578 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
0018e7313d
Seems like revision 17554 busted the presubmit scripts, reverting.
...
TEST=None
BUG=None
TBR=joi
Review URL: http://codereview.chromium.org/119122
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17561 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
8b40a9b81b
Fix ListRelevantPresubmitFiles().
...
It was affected by the current directory!
Review URL: http://codereview.chromium.org/119101
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17554 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
ca14c12a62
Rewrite the presubmit test to be much more hermetic.
...
Review URL: http://codereview.chromium.org/115964
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17314 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
77c4f0f135
Remove SVN-specific function InputApi.FilterTextFiles().
...
Review URL: http://codereview.chromium.org/115923
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17202 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
15bdffa063
Make AffectedFile member variables private.
...
Cache SvnAffectedFile.IsTextFile() return value.
Improve the unit test by not/less relying on the local file system.
Review URL: http://codereview.chromium.org/113964
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17180 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
786886257e
warnings.catch_warnings() is only available on python 2.5
...
Review URL: http://codereview.chromium.org/115881
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17114 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
1e08c00d60
Add AffectedFile.IsTextFile() and deprecate AffectedTextFiles().
...
Make DepotToLocalPath() and LocalToDepotPath() not static. It is necessary for a subsequent change since I need to factor out it's SCM assumption.
Review URL: http://codereview.chromium.org/113933
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17091 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
6ebe68a73d
Make the member variable 'protected' in the python sense.
...
Review URL: http://codereview.chromium.org/113899
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17039 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
e1a524ff00
Remove SPECIAL_KEYS and GclChange.Changelist() to simplify the code.
...
Review URL: http://codereview.chromium.org/113883
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16983 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
f3eee5692c
Add a unit test for input_api.change.tags.
...
Review URL: http://codereview.chromium.org/113859
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16959 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
9711bbafde
Add InputApi.version so the presubmit script can mark a minimum supported version for instance.
...
BUG=None
R=joi
Review URL: http://codereview.chromium.org/115719
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16819 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
dbbeedc691
Factor out SVN-specific methods out of AffectedFile.
...
TEST=New unit tests.
BUG=None
Review URL: http://codereview.chromium.org/113783
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16785 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
0ff1fab804
Add repository root presubmit support.
...
Review URL: http://codereview.chromium.org/115616
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16738 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
7b305e8c18
Add new presubmit check RunPythonUnitTests.
...
Review URL: http://codereview.chromium.org/115516
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16390 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
3d23524cb0
Add more presubmit support. Add PRESUBMIT.py to depot_tools.
...
Changed InputApi.PresubmitLocalPath() to contain the absolute path without the script name.
Review URL: http://codereview.chromium.org/113354
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16157 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
1033accb23
Rename presubmit.py to presubmit_support.py to reduce confusion and be able to add a PRESUBMIT.py check into depot_tools.
...
Review URL: http://codereview.chromium.org/113337
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15954 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
kuchhal@chromium.org
00c41e457b
Add presubmit checks to look for BUG= and TEST= tags in change list description (Part 1 of 2).
...
BUG=11287
TEST=gcl commit should fail unless BUG= & TEST= exist in change list description or --no_presubmit is used.
Review URL: http://codereview.chromium.org/113294
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15905 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
46a9410947
Deprecate gcl.GetSVNFileInfo() for gclient.CaptureSVNInfo().
...
Review URL: http://codereview.chromium.org/113290
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15891 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
c1675e27e6
Add an optional flag to gcl.ReadFile() so that presubmit can support CRLF PRESUBMIT.py scripts.
...
Also add a version number to gcl.py.
Review URL: http://codereview.chromium.org/99072
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@14644 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
02e9e068f9
When I copied presubmit_unittest.py, I picked the old one. Fix with the latest version from the "old" depot_tools.
...
TBR=nsylvain
Review URL: http://codereview.chromium.org/100055
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@14635 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@google.com
fb2b8eb2e2
Create the Next Generation of depot_tools. Eh.
...
Review URL: http://codereview.chromium.org/92087
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@14349 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago