aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
11,029 Commits
6 Branches
0 Tags
204 MiB
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '76f852ca66'
${ noResults }
Commit Graph

11029 Commits (76f852ca66cea6d885f6bf6db30aa0400feeb80c)
 

Author SHA1 Message Date
Allen Li 39ca85acf5 [scm] Add lock around all set calls 
Bug: b/356935829
Change-Id: I886d20b71af26efd828d18cb1b01f1271f42d053
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5786165
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago
Ryan Macnak 6a06d8934e Ignore missing brotli wheel for RISC-V. 
With this last step, it is now possible to `gclient sync` on a Linux RV64 host.

Bug: https://issues.chromium.org/issues/40153066
Bug: https://issues.chromium.org/issues/359654093
Bug: https://github.com/dart-lang/sdk/issues/48545
Change-Id: I38b74e26e5692b39b48a38c0e0c482ea1d0ad7ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5786164
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago
recipe-roller 8d1a0da424 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8739696156254414337

recipe_engine:
39a4ee8591
  39a4ee8 (mohrr@google.com)
      [path] Remove api.path.is_parent_of()

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I56e2b1725513d3662bfcc8c761fbecf874d7e244
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5785621
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 12 months ago
recipe-roller 16e05b7527 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8739699930384401649

recipe_engine:
b5d93ad359
  b5d93ad (chanli@chromium.org)
      [placeholder] update `bounded_child` tag

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I92c87dd87dd6d9102400b2e1414d7d5c14f98628
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5785617
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 12 months ago
Junji Watanabe 1e6454f8d2 autoninja: ignore ResourceWarning from subprocess for ninjalog_uploader.py 
The main process exits right after ninja_uploader.py subprocess starts,
which may print ResourceWarning from subprocess.
e319f774f9/Lib/subprocess.py (L946-L947)
This CL ignores the warning message.

Change-Id: I800387194763e60a16437b3bd41fa282b605dda7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5782795
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
 12 months ago
recipe-roller a64e248179 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8739748376023032545

recipe_engine:
9445247476
  9445247 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 6327541a8a4e to ad7b787aa0ee

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I58452f708a1739f9e1ddf623617c2060f3c86a7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5785394
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 12 months ago
Allen Li 9ddf1780c6 [scm] Add global config lock 
Otherwise, when this is run concurrently by gclient, it causes race conflicts.

Bug: b/356935829
Change-Id: Ic7697415f7dbb82971be511c5058206f9195e896
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5784434
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
 12 months ago
Gavin Mak 7e1a7e0fda Show message every 30s for long running presubmits 
Slow presubmits like CheckUnwantedDependencies can often take over 30s
to run. Print a "still running" message so users don't think something
hung.

Bug: b/358457858
Change-Id: I47f5589af43d8fb0f384e6f7c633e9d0addd568a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5782588
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Scott Lee <ddoman@chromium.org>
 12 months ago
recipe-roller 281d3d5286 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8739774800293860625

recipe_engine:
e8cb8fffc7
  e8cb8ff (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 83bca0e9bcba to 412218d34274

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idbb489ecc1f80ac1d4293b6b6c4d073ba1c1429d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5784606
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 12 months ago
recipe-roller 0616a64805 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8739776059105427473

recipe_engine:
ecbed2c43a
  ecbed2c (chanli@chromium.org)
      [placeholder] Add a tag to child builds

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0d7e38af4a7b52061fc1bd1aebc36ac30eb6a1c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5782590
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 12 months ago
recipe-roller ba8833b397 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8739777317159440737

recipe_engine:
4ffdc85b98
  4ffdc85 (iannucci@chromium.org)
      [lint] Add plistlib to allowed modules.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I41e885a8c1acb4477bf2d77c1570221c751ab76a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5782589
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 12 months ago
Chan Li 7e3d8cda53 [depot_tools] roll lucicfg 
To release https://crrev.com/c/5690286

Bug: 338071541
Change-Id: I0e738cc15d72e5a1fcf6c96ca5b8265ee65b88f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5784415
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
 12 months ago
Allen Li a40df24c91 [git_auth] Add apply_global tests 
Bug: b/351024645
Change-Id: I54e55545c27275165b3435707e2b47095c8fcac9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5739434
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 12 months ago
Robert Iannucci 7762989876 [scm_mock] Expose mocking of system config layer. 
R=ayatane, yiwzhang

Change-Id: I15a48c6af54d2b047b085abc729d2849759816d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5762792
Reviewed-by: Allen Li <ayatane@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 12 months ago
Peter Kasting 5f4fb8c8fb [jumbo] Update various places for changes to C++ standards. 
In particular, the supported headers and <type_traits> members have
changed.

I removed the "legacy C++" headers since these are arcane and long
unsupported.

Also fixed what looked like some missing operators in a couple regexes.

Bug: none
Change-Id: I84a983efeb95ec806eaf6d75866d7079ca1bdd96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5777599
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 12 months ago
Gavin Mak d4c6d40d50 Reduce RebaseChange max tries from 6 to 2 
On failure, gerrit_util always retries HTTP requests the maximum
number of times. This doesn't always make sense, e.g. for RebaseChange
which gets 409 on a merge conflict and can't be retried into
succeeding.

Bug: b/341792235
Change-Id: I6f9e212c5b0365236a99768f056bab2eb60cddc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5773566
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 12 months ago
Andrew Grieve 5f6542c176 autoninja.py: Detect when use_siso=false exists after use_siso=true 
I ran into this from having use_siso=true in an include(), and then
trying to turn it off again via an assignment

Change-Id: Iba70ade68c7a3699755d6a0070816283e0538c6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5769918
Commit-Queue: Junji Watanabe <jwata@google.com>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
 12 months ago
Allen Li 78d32ff67a [scm_mock] Add global_state param to mock 
Change-Id: If0b35ead4804c17d8ec8acdf7bff96cfe73349b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5773569
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
 12 months ago
Allen Li f0f34c47f7 Revert "[git-number] Remove unused git-number script." 
This reverts commit c92e85abb7.

Reason for revert: broke a builder

Original change's description:
> [git-number] Remove unused git-number script.
>
> R=ayatane, yiwzhang
>
> Change-Id: I53430ba4cf4ff83e222b4d9ffdeddfd6299e3330
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5766853
> Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
> Reviewed-by: Allen Li <ayatane@chromium.org>
> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

Change-Id: Iaec18d6e688343ef1276166ff9e6bac033c6de56
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5773571
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Allen Li <ayatane@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago
Allen Li 65acc1df40 [scm_mock] Make params keyword only 
None of the optional params are used currently, so make them keyword
to ease future changes, like adding the global_config in the next CL.

Change-Id: I213cccb945c969b4211adad8ccd9170ef6209e0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5773568
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
 12 months ago
Junji Watanabe 210cac627e Update CIPD client version 
This CL updates the CIPD client in depot_tools to the latest version.
The new cipd client has `-json-output` option for auth-info subcommand. https://crrev.com/c/5467900

Change-Id: Iae0396a159a67c1a59af8dfe5e74b755ccfd1475
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5772153
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
 12 months ago
Robert Iannucci 10d7ebda04 [scm_mock] Remove unused `config` parameter. 
R=ayatane, yiwzhang

Change-Id: I843a967249d9f1f967c94af91f98c3885b319d01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5763524
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Allen Li <ayatane@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
 12 months ago
Robert Iannucci c92e85abb7 [git-number] Remove unused git-number script. 
R=ayatane, yiwzhang

Change-Id: I53430ba4cf4ff83e222b4d9ffdeddfd6299e3330
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5766853
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Allen Li <ayatane@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
 12 months ago
Robert Iannucci 283661a975 [scm] Add key canonicalization to scm's CachedGitConfigState. 
This will allow `git cl` to be much more consistent with regards to
setting and reading git config key values in both production and
testing.

R=ayatane, yiwzhang

Change-Id: I2f1f1c5c6aaab12e2e9dbcf36c181244706cd4a8
Bug: 357688295
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5762199
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
 12 months ago
Allen Li a1c9f5ecef [scm_mock] Fix types 
Change-Id: I3d1dba2d8c3adc5ef4cf475514174b1d3f817010
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5773567
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
 12 months ago
Josip Sokcevic bed17582bf Add a script to copy GCS packages from one DEPS file to another 
This script will be used to roll downstream GCS packages.

Bug: 358435510
Change-Id: I7ea1229eb4e8c4c590cad336573f9d24662f5730
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5765858
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago
Gavin Mak ec800aa077 Add "git cl cherry-pick" for cherry picking a chain of CLs via Gerrit 
Users who want to upload multiple cherry picks usually run "git
cherry-pick" locally, multiple times. Gerrit does not recognize
these changes as cherry picks and neither do other services that
query cherry pick info from Gerrit, e.g. rubber stamper.

For Gerrit to identify a change as a true cherry pick, you need to
use their Cherry Pick Revision REST API endpoint. This new command
uses it to create a chain of cherry pick CLs recognized by Gerrit.

Bug: b/341792235
Change-Id: I4ba75da3901f6ea68c1debd65820e802da681798
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5756161
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 12 months ago
Jiewei Qian 75932421da metadata: relax versioning info check if Chromium is the canonical repo of a dependency 
If Chromium is the canonical repository, the version of the dependency
is essentially Chromium.

Change-Id: Ifcb80dbeee0d36bf71234f8f48423e8f7aa9dcf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5772151
Reviewed-by: Rachael Newitt <renewitt@google.com>
Commit-Queue: Jiewei Qian <qjw@chromium.org>
 12 months ago
Gavin Mak f52dad9747 Handle binaries in presubmit_diff 
presubmit_diff always tries to decode files from Gitiles with UTF-8
but if the file is binary, it gets a UnicodeDecodeError. Don't
assume that a file is text and just write the bytes directly.

Bug: b/358175830
Change-Id: Iaa259051b4157737397933e9d994c00e9da5836c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5771938
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 12 months ago
Allen Li a603aded9a [gclient_scm] Add new auth stack setup to gclient 
Bug: b/356935829
Change-Id: Ie917f142c3fddba398a5351d685a7b131b298a76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5762791
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago
recipe-roller 5a05f6858c Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8740244771060894657

recipe_engine:
a2e7dc4262
  a2e7dc4 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 005642dce877 to be41b8d978e2

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia3a014384b84d75fe087e1861b14aa62ec2bd3b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5769356
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 12 months ago
Junji Watanabe 670ce748be autoninja: Propgate AUTONINJA_BUILD_ID to siso ninja via SISO_BUILD_ID 
Bug: 355127782
Change-Id: Ia7f55696e9282c8719ca98892963bb991caa70f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5734819
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
 12 months ago
Allen Li 2f8e1e499d [git_auth] Improve example comments 
Change-Id: If82a044ef9c832d3d10bacc5a6c496d39aee6841
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5762790
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 12 months ago
Allen Li 03a5043a94 [git_auth] Remove unnecessary quotes 
Not needed with future import

Change-Id: I14d56465dc42ac710b64b301928057329ac9d038
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5762789
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 12 months ago
Allen Li 7a9aca3708 [git_common] Fix memoize_one type check 
pyright doesn't like assigning random functions to function
attributes, as you might imagine.

The new implementation is much cleaner if I say so myself.

The memoize tests also pass FWIW.

Change-Id: Ie37b14f48004b81270c08b4d073c323b8b4ebd54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5762788
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 12 months ago
recipe-roller 6e1a586bf2 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8740339142652832657

recipe_engine:
2fce2a15ca
  2fce2a1 (mohrr@google.com)
      Roll recipe protos

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib9c4dc95f4bfda13658d74817efd224ee2ef9e1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5765729
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 12 months ago
Allen Li 4c050c6f1a [git_common] Use kwarg syntax for memoize_one 
Change-Id: I764670c1a0d90e94e437472d6bc7a8ce1d0a11cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5762198
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 12 months ago
Robert Iannucci a3fb9bad66 [scm] Mock global git config scope globally. 
This will be useful for writing tests which rely on shared 'global'
config between different working directories.

This also adds support for mocking 'system' (global, immutable) and
'workspace' (local, mutable). The workspace scope I think is a bit iffy
though, given how `git cl` is actually built - currently scm.GIT doesn't
really know about clone vs. workspace, and afaik no config adjustements
actually apply to the workspace scope.

Adds tests for mocked git config implementation, including bug fixes
to the current implementation revealed by the tests.

R=ayatane, yiwzhang

Change-Id: Ia56d2a81d8df6ae75d9f8d0497be0d67bdc03651
Bug: 355505750
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5759163
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
 12 months ago
Allen Li cdf5599e67 [git_common] Fix all type checking errors 
Bug: b/351071334
Change-Id: I130300bebd25a62a14ea10202ea9d369f825ed50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5757941
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 12 months ago
Yiwei Zhang b4e97035af redirect stdout and stderr of cipd_bin_setup to /dev/null 
Otherwise, the cipd_bin_setup would print the root of cipd directory
everytime.

Bug: 357131092
Change-Id: I376a1eb9e06db6fce8e7a21ab08a4af40dde3ccd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5762367
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago
Allen Li 40cece20d0 [git_cl] Fix some type checking errors 
Bug: b/351071334
Change-Id: I15b8c7658c5959dbf88168e278525c2b8e2e4b2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5754255
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 1 year ago
Allen Li 0cb94fcfa9 [git_common] Add type annotations 
Bug: b/351071334
Change-Id: I876db267bdd8d876a22d4582bd6505705d1c38ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5754254
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 1 year ago
Allen Li 29838db8fe [gerrit_util] Add type annotations 
Bug: b/351071334
Change-Id: I9e31f14120953e89f6cef3759f595f6aca79cd33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5754253
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 1 year ago
Allen Li 536cf08520 [scm] Add type annotations to GetBranchConfig 
Bug: b/351071334
Change-Id: Ide215e4b73806e8b198104b50fc8b0cb6f5bf8e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5754252
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 1 year ago
Allen Li 72c2f2b6a5 [git_cl] Fix parse_args type checking 
Bug: b/351071334
Change-Id: I1387d88196d06ce6c10fdff3253cebcc21428bbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5754388
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 1 year ago
Allen Li 7815620b1f [git_auth] Auto configure global config also 
Bug: b/351071334
Change-Id: I069443a74cf7e33ce9ebea53ea3d52e272ed3570
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5740605
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 1 year ago
Struan Shrimpton b0024901d3 Add support for tagging bot_update step 
In order to make reproduction steps appear on the bot_update step it
needs to have a tag that matches the instruction set on the invocation.

Bug: 349529661
Change-Id: Idcf75715ea4a64a5c6d9571f4f5485613864b7da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5754258
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
 1 year ago
recipe-roller f99469bf16 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8740798419027221153

recipe_engine:
6eba71f1a4
  6eba71f (mohrr@google.com)
      [post_process] Remove deprecated checks

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8e21fdd4a9b466ed9123c2fd03c511d7878165c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5757378
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
Allen Li be5ff1a6c4 [git_auth] Move auto configure logic 
Bug: b/351071334
Change-Id: Ic6574f86208b22e406e36f8cd45a564ea74ec7f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5742793
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 1 year ago
Allen Li a6cd7589e9 [scm] Fix type errors 
Bug: b/351071334
Change-Id: I43855632ac36a06569047d688fe710b83df4e707
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5751005
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 1 year ago